add some unit test. Update content organization
authorrougeronj
Mon, 12 Nov 2012 16:00:15 +0100
changeset 988 d9dd9dbd22ca
parent 961 61da23337d76
child 989 ede3d5bcbd8b
add some unit test. Update content organization
src/ldt/ldt/ldt_utils/tests/content_tests.py
src/ldt/ldt/ldt_utils/tests/ldt_tests.py
src/ldt/ldt/ldt_utils/tests/project_tests.py
src/ldt/ldt/ldt_utils/views/content.py
--- a/src/ldt/ldt/ldt_utils/tests/content_tests.py	Fri Nov 16 18:37:23 2012 +0100
+++ b/src/ldt/ldt/ldt_utils/tests/content_tests.py	Mon Nov 12 16:00:15 2012 +0100
@@ -16,6 +16,7 @@
 import unittest
 import uuid
 import logging
+import os
 
 class ContentTest(TestCase):
     
@@ -46,8 +47,8 @@
         self.cont13.iri_id = "id113"
         self.cont13.save()
         
-        self.assertEqual(Content.objects.get(iri_id=self.cont13.iri_id), self.cont13) 
-    
+        self.assertEqual(Content.objects.get(iri_id=self.cont13.iri_id), self.cont13)
+        
     #test the deletion of a content without media
     def test_del_content_v1(self):
         self.cont14 = Content(iriurl="id14/iriurl14", duration = 100)
--- a/src/ldt/ldt/ldt_utils/tests/ldt_tests.py	Fri Nov 16 18:37:23 2012 +0100
+++ b/src/ldt/ldt/ldt_utils/tests/ldt_tests.py	Mon Nov 12 16:00:15 2012 +0100
@@ -68,7 +68,6 @@
         self.assertEqual(ldoc.xpath("/iri/medias/media")[1].get("id"), self.cont2.iri_id)
         f.close()
         
-    """
     def test_generate_init(self):
         self.cont3 = Content(iriurl="id3/iriurl3", duration=111)
         self.cont3.iri_id = "id3"
@@ -82,7 +81,6 @@
         ldoc = self.LU.generate_init([], 'ldt.ldt_utils.views.search_ldt')
         self.assertEqual(ldoc.xpath("/iri/files/init")[0].tag, "init")
         self.assertEqual(ldoc.xpath("/iri/files/library")[0].tag, "library")
-    """
     
     def test_create_ldt(self):
         self.cont5 = Content(iriurl="id5/iriurl5", duration=111)
--- a/src/ldt/ldt/ldt_utils/tests/project_tests.py	Fri Nov 16 18:37:23 2012 +0100
+++ b/src/ldt/ldt/ldt_utils/tests/project_tests.py	Mon Nov 12 16:00:15 2012 +0100
@@ -52,4 +52,26 @@
 
         with self.assertRaises(Project.DoesNotExist):
             Project.objects.get(ldt_id=self.project3.ldt_id)
-        
\ No newline at end of file
+    
+    #test deletion of project with annotations  
+    def test_del_project_v2(self):
+        
+        self.project4 = Project(title="titleproj3", owner=self.user)
+        self.project4.ldt = '<iri ldtversion="1.0.3" xmlns:dc="http://dublincore.org/documents/dcmi-namespace/"><project id="af3b99e4-b695-11df-bfde-00145ea4a333" user="admin" title="CA:reponse a TC" abstract=""/> <medias> <media extra="" id="laurentcantet_entrelesmurs" pict="" src="http://amateur.iri.centrepompidou.fr//atelier/static/media/ldt/laurentcantet_entrelesmurs/laurentcantet_entrelesmurs.iri" video="rtmp://media.iri.centrepompidou.fr/ddc_player/video/regardssignes/"/> </medias> <annotations> <content id="laurentcantet_entrelesmurs"> <ensemble id="ens_perso" idProject="fe0d5d4c-2201-11df-8a24-00145ea4a2be" title="Decoupages personnels" author="perso" abstract=""> <decoupage id="c_EFC3FFE7-0204-A086-EBEC-D2A03A0E56CB" author="perso"> <title>CA: prof et admin</title> <abstract/> <elements> <element id="s_442AAB3A-42DA-F9BF-75E7-D2A0663FD5FF" begin="985690" dur="373222" author="" date="2010/09/02" color="16711680" src=""> <title/> <abstract/> <audio source=""/> <tags/> </element> <element id="s_0050F043-3AD2-0A7C-6699-D2A03A1EBA02" begin="5052858" dur="124407" author="" date="2010/09/02" color="10053375" src=""> <title>conseil de classe</title> <abstract>Reprise de la figure precedente</abstract> <audio source="undefined"/> <tags/> </element> </elements> </decoupage> <decoupage id="c_EEEF5C29-86E1-4AAE-E068-04EB5B00E492" author="perso"> <title>TC: prof et admin</title> <abstract/> <elements> <element id="s_880D9D4B-8BC0-BA43-5ECA-04EBA9FC9E59" begin="2426894" dur="141478" author="" date="2010/02/25" color="10053375" src=""> <title>Conseil de classe</title> <abstract/> <audio source=""/> <tags> <tag>Argumentation</tag> </tags> </element> <element id="s_D568A57C-7110-DED2-3165-04EC54387060" begin="5052858" dur="124407" author="" date="2010/02/25" color="10053375" src=""> <title>conseil de classe</title> <abstract>Reprise de la figure precedente</abstract> <audio source="undefined"/> <tags/> </element> </elements> </decoupage> </ensemble> </content> </annotations> <displays> <display id="0" title="Init view" idsel="laurentcantet_entrelesmurs" tc="2426424" zoom="0" scroll="0" infoBAB=""> <audio source=""/> <content id="laurentcantet_entrelesmurs"> <decoupage idens="en_2" id="de_PPP" tagsSelect=""/> <decoupage idens="laurentcantet_entrelesmurs" id="c_14A2E638-1936-97DC-E303-2DBA6A82A8B3" tagsSelect=""/> <decoupage idens="ens_perso" id="c_EEEF5C29-86E1-4AAE-E068-04EB5B00E492" tagsSelect=""/> <decoupage idens="ens_perso" id="c_EFC3FFE7-0204-A086-EBEC-D2A03A0E56CB" tagsSelect=""/> </content> </display> </displays> <edits> <editing id="0" tags=""> <title>Bout a bout 1</title> <abstract/> <edit id="edit1" tags=""> <eList/> <caption/> <audio/> <mList/> </edit> <edit id="edit2" tags=""> <eList/> <caption/> <audio/> <mList/> </edit> </editing> </edits> </iri>'
+        self.project4.id = "444"
+        self.project4.ldt_id = str(uuid.uuid1())
+        self.project4.description = "proj4description"
+        self.project4.save()
+        
+        create_ldt(self.project4, self.user)
+        
+        self.LA = LdtAnnotation(self.project4)
+
+        self.LA.add("id11", "cutting_id", "cutting_title", "title", "text", ["tag1", "tag2"], "800",
+                    "10000", "jdoe", "2011-09-10T09:12:58")
+        self.LA.save()
+        
+        self.project4.delete()
+
+        with self.assertRaises(Project.DoesNotExist):
+            Project.objects.get(ldt_id=self.project4.ldt_id)
\ No newline at end of file
--- a/src/ldt/ldt/ldt_utils/views/content.py	Fri Nov 16 18:37:23 2012 +0100
+++ b/src/ldt/ldt/ldt_utils/views/content.py	Mon Nov 12 16:00:15 2012 +0100
@@ -34,123 +34,6 @@
 import urlparse
 #from django.core.files.temp import NamedTemporaryFile
 
-def media_management(request, media_input_type, cleaned_data, content_form, media_form, form_status):
-    if media_input_type == "none":
-                    media = None
-    elif media_input_type == "link":
-        media = content_form.cleaned_data["media_obj"]
-        created = False
-    elif media_input_type == "create":
-        del cleaned_data["media_file"]
-        if not cleaned_data['videopath']:
-            cleaned_data['videopath'] = settings.STREAM_URL
-        # if the source is already http:// or rtmp:// we don't have to add STREAM_URL
-        if cleaned_data['src'].startswith("rtmp://") or cleaned_data['src'].startswith("http://"):
-            cleaned_data['videopath'] = ''
-            
-            media, created = Media.objects.get_or_create(src=cleaned_data['src'], defaults=cleaned_data) #@UndefinedVariable
-    
-    elif media_input_type == "url" or media_input_type == "upload" :
-        # copy file
-        #complet src
-        destination_file = None
-        source_file = None
-        try:
-            if media_input_type == "url":
-                url = cleaned_data["external_src_url"]
-                source_file = urllib2.urlopen(url)
-                source_filename = source_file.info().get('Content-Disposition', None)
-                if not source_filename:
-                    source_filename = urlparse.urlparse(url).path.rstrip("/").split('/')[-1]
-            elif media_input_type == "upload":
-                #source_file = request.FILES['media-media_file']
-                # At this point the file has already be uploaded thanks to the upload view, and original file name is sent through a post var
-                source_filename = request.POST["media-local_file_name"]
-            
-            source_filename = ldt_utils_path.sanitize_filename(source_filename)
-            destination_filepath = os.path.join(settings.STREAM_PATH, source_filename)
-            base_source_filename = source_filename
-            extension = base_source_filename.split(".")[-1]
-            if extension == base_source_filename:
-                extension = ""
-                base_basename_filename = base_source_filename
-            else:
-                base_basename_filename = base_source_filename[:-1 * (len(extension) + 1)]
-            i = 0
-            
-            while os.path.exists(destination_filepath):
-                base_source_filename = "%s.%d.%s" % (base_basename_filename, i, extension)
-                destination_filepath = os.path.join(settings.STREAM_PATH, base_source_filename)
-                i += 1
-            
-            if media_input_type == "url":
-                # we upload the file if we are in url case
-                destination_file = open(destination_filepath, "wb")
-                chunck = source_file.read(2048)
-                while chunck:
-                    destination_file.write(chunck)
-                    chunck = source_file.read(2048)
-                
-            elif media_input_type == "upload":
-                # The media file has been uploaded in the session temp folder 
-                # so we just have to move to the regular folder and rename it.
-                if os.path.exists(os.path.join(settings.STREAM_PATH, "tmp/" + request.COOKIES[settings.SESSION_COOKIE_NAME] + "/", source_filename)):
-                    os.rename(os.path.join(settings.STREAM_PATH, "tmp/" + request.COOKIES[settings.SESSION_COOKIE_NAME] + "/", source_filename), os.path.join(settings.STREAM_PATH, base_source_filename))
-            
-            
-            src_prefix = settings.STREAM_SRC_PREFIX.rstrip("/")
-            if len(src_prefix) > 0:
-                cleaned_data["src"] = src_prefix + "/" + base_source_filename
-            else:
-                cleaned_data["src"] = base_source_filename
-            
-            
-        except Exception as inst:
-            logging.debug("write_content_base : POST error when processing file:" + str(inst)) #@UndefinedVariable
-            form_status = "error"
-            #set error for form
-            if media_input_type == "url":
-                errors = media_form._errors.setdefault("external_src_url", ErrorList())
-                errors.append(_("Problem when downloading file from url : ") + url)
-            elif media_input_type == "upload":
-                errors = media_form._errors.setdefault("media_file", ErrorList())
-                errors.append(_("Problem when uploading file : ") + str(inst))
-        finally:
-            if media_input_type == "url":
-                if destination_file:
-                    destination_file.close()
-                if source_file:
-                    source_file.close()
-        
-        
-        if form_status != "error":
-            del cleaned_data["media_file"]
-            if not cleaned_data['videopath']:
-                cleaned_data['videopath'] = settings.STREAM_URL
-            mimetype = cleaned_data.get('mimetype_field', None)
-            if not mimetype:
-                mimetype = mimetypes.guess_type(cleaned_data['src'])
-            cleaned_data['mimetype_field'] = mimetype
-            media, created = Media.safe_objects.get_or_create(src=cleaned_data['src'], defaults=cleaned_data) #@UndefinedVariable
-            cached_assign('view_media', request.user, media)
-        else:
-            media = None
-            
-
-    if media and not created:
-        for attribute in ('external_id', 'external_permalink', 'external_publication_url', 'external_src_url', 'media_creation_date', 'videopath', 'duration', 'description', 'title', 'front_project'):
-            setattr(media, attribute, cleaned_data.get(attribute))
-        mimetype = cleaned_data.get('mimetype_field', None)
-        if not mimetype:
-            mimetype = mimetypes.guess_type(media.src)
-        media.mimetype_field = mimetype
-        cached_assign('view_media', request.user, media)
-        cached_assign('change_media', request.user, media)
-        media.save()
-        
-    return media, form_status
-    
-    
 @transaction.commit_manually
 def write_content_base(request, iri_id=None):
     if iri_id:
@@ -229,14 +112,8 @@
                 
                 media_input_type = content_form.cleaned_data["media_input_type"]
                 
-                
-                
-                
                 media, form_status = media_management(request, media_input_type, cleaned_data, content_form, media_form, form_status)
                 
-                
-                
-                
                 if form_status != "error": 
                     content_defaults = {}
                     content_defaults.update(content_form.cleaned_data)
@@ -380,7 +257,7 @@
                 member_list, admin_list = get_userlist_model(content_temp, request.user)
     
     # Deleted is False if an error occurred during deletion
-    if (deleted == False)  or (content_form == False and media_form == False and picture_form == False and form_status == False and current_front_project == False):
+    if (content_form == False and media_form == False and picture_form == False and form_status == False and current_front_project == False):
         message=_("An error occurred - Please try again or contact webmaster")
         title = _("Error")
         logging.error(e)
@@ -410,6 +287,126 @@
                                                                     'elem_list':elem_list, 'member_list': member_list, 'admin_list': admin_list,  'iri_id': iri_id, 'session_key':session_key,
                                                                     'cookie_name':cookie_name, 'img_container': img_container, 'profile_picture_form': picture_form,
                                                                     'current_front_project':current_front_project}, context_instance=RequestContext(request))
+
+
+def media_management(request, media_input_type, cleaned_data, content_form, media_form, form_status):
+    if media_input_type == "none":
+                    media = None
+    elif media_input_type == "link":
+        media = content_form.cleaned_data["media_obj"]
+        created = False
+    elif media_input_type == "create":
+        del cleaned_data["media_file"]
+        if not cleaned_data['videopath']:
+            cleaned_data['videopath'] = settings.STREAM_URL
+        # if the source is already http:// or rtmp:// we don't have to add STREAM_URL
+        if cleaned_data['src'].startswith("rtmp://") or cleaned_data['src'].startswith("http://"):
+            cleaned_data['videopath'] = ''
+            
+            media, created = Media.objects.get_or_create(src=cleaned_data['src'], defaults=cleaned_data) #@UndefinedVariable
+    
+    elif media_input_type == "url" or media_input_type == "upload" :
+        # copy file
+        #complet src
+        destination_file = None
+        source_file = None
+        try:
+            if media_input_type == "url":
+                url = cleaned_data["external_src_url"]
+                source_file = urllib2.urlopen(url)
+                source_filename = source_file.info().get('Content-Disposition', None)
+                if not source_filename:
+                    source_filename = urlparse.urlparse(url).path.rstrip("/").split('/')[-1]
+            elif media_input_type == "upload":
+                #source_file = request.FILES['media-media_file']
+                # At this point the file has already be uploaded thanks to the upload view, and original file name is sent through a post var
+                source_filename = request.POST["media-local_file_name"]
+            
+            source_filename = ldt_utils_path.sanitize_filename(source_filename)
+            destination_filepath = os.path.join(settings.STREAM_PATH, source_filename)
+            base_source_filename = source_filename
+            extension = base_source_filename.split(".")[-1]
+            if extension == base_source_filename:
+                extension = ""
+                base_basename_filename = base_source_filename
+            else:
+                base_basename_filename = base_source_filename[:-1 * (len(extension) + 1)]
+            i = 0
+            
+            while os.path.exists(destination_filepath):
+                base_source_filename = "%s.%d.%s" % (base_basename_filename, i, extension)
+                destination_filepath = os.path.join(settings.STREAM_PATH, base_source_filename)
+                i += 1
+            
+            if media_input_type == "url":
+                # we upload the file if we are in url case
+                destination_file = open(destination_filepath, "wb")
+                chunck = source_file.read(2048)
+                while chunck:
+                    destination_file.write(chunck)
+                    chunck = source_file.read(2048)
+                
+            elif media_input_type == "upload":
+                # The media file has been uploaded in the session temp folder 
+                # so we just have to move to the regular folder and rename it.
+                if os.path.exists(os.path.join(settings.STREAM_PATH, "tmp/" + request.COOKIES[settings.SESSION_COOKIE_NAME] + "/", source_filename)):
+                    os.rename(os.path.join(settings.STREAM_PATH, "tmp/" + request.COOKIES[settings.SESSION_COOKIE_NAME] + "/", source_filename), os.path.join(settings.STREAM_PATH, base_source_filename))
+            
+            
+            src_prefix = settings.STREAM_SRC_PREFIX.rstrip("/")
+            if len(src_prefix) > 0:
+                cleaned_data["src"] = src_prefix + "/" + base_source_filename
+            else:
+                cleaned_data["src"] = base_source_filename
+            
+            
+        except Exception as inst:
+            logging.debug("write_content_base : POST error when processing file:" + str(inst)) #@UndefinedVariable
+            form_status = "error"
+            #set error for form
+            if media_input_type == "url":
+                errors = media_form._errors.setdefault("external_src_url", ErrorList())
+                errors.append(_("Problem when downloading file from url : ") + url)
+            elif media_input_type == "upload":
+                errors = media_form._errors.setdefault("media_file", ErrorList())
+                errors.append(_("Problem when uploading file : ") + str(inst))
+        finally:
+            if media_input_type == "url":
+                if destination_file:
+                    destination_file.close()
+                if source_file:
+                    source_file.close()
+        
+        
+        if form_status != "error":
+            del cleaned_data["media_file"]
+            if not cleaned_data['videopath']:
+                cleaned_data['videopath'] = settings.STREAM_URL
+            mimetype = cleaned_data.get('mimetype_field', None)
+            if not mimetype:
+                mimetype = mimetypes.guess_type(cleaned_data['src'])
+            cleaned_data['mimetype_field'] = mimetype
+            media, created = Media.safe_objects.get_or_create(src=cleaned_data['src'], defaults=cleaned_data) #@UndefinedVariable
+            cached_assign('view_media', request.user, media)
+        else:
+            media = None
+            
+
+    if media and not created:
+        for attribute in ('external_id', 'external_permalink', 'external_publication_url', 'external_src_url', 'media_creation_date', 'videopath', 'duration', 'description', 'title', 'front_project'):
+            setattr(media, attribute, cleaned_data.get(attribute))
+        mimetype = cleaned_data.get('mimetype_field', None)
+        if not mimetype:
+            mimetype = mimetypes.guess_type(media.src)
+        media.mimetype_field = mimetype
+        cached_assign('view_media', request.user, media)
+        cached_assign('change_media', request.user, media)
+        media.save()
+        
+    return media, form_status
+
+
+
 @login_required
 def prepare_delete_content(request, iri_id=None): 
     errors = []