# HG changeset patch # User ymh # Date 1435912751 -7200 # Node ID cc2f7294f1d2c4de5abb7f35e15eeaedd93e1502 # Parent 73d1956402877fd4295fa6d1271e6d69fc908b42 add a 404 when notice are not found when displaying their page diff -r 73d195640287 -r cc2f7294f1d2 src/hdalab/views/pages.py --- a/src/hdalab/views/pages.py Fri Jul 03 00:20:27 2015 +0200 +++ b/src/hdalab/views/pages.py Fri Jul 03 10:39:11 2015 +0200 @@ -8,13 +8,18 @@ import user_agents from hdabo.models import Datasheet, TaggedSheet +from django.http.response import Http404 def datasheet(request, hda_id=None): MAX_TAG = 15 MAX_RELATED = 50 - datasheet = Datasheet.objects.select_related("organisation").get(hda_id=hda_id) + datasheet = None + try: + datasheet = Datasheet.objects.select_related("organisation").get(hda_id=hda_id) + except Datasheet.DoesNotExist: + raise Http404("The datasheet %s is not found."%hda_id) domain = re.findall(r"^https?://(www\.)?([^/]+)",datasheet.url) ordered_tags = TaggedSheet.objects.filter(datasheet=datasheet,order__lte=MAX_TAG).select_related("tag").order_by('order')