diff -r 490d5cc509ed -r cf61fcea0001 wp/wp-admin/includes/user.php
--- a/wp/wp-admin/includes/user.php Tue Jun 09 11:14:17 2015 +0000
+++ b/wp/wp-admin/includes/user.php Mon Oct 14 17:39:30 2019 +0200
@@ -11,7 +11,7 @@
*
* @since 2.0.0
*
- * @return null|WP_Error|int Null when adding user, WP_Error or User ID integer when no parameters.
+ * @return int|WP_Error WP_Error or User ID.
*/
function add_user() {
return edit_user();
@@ -25,10 +25,10 @@
* @since 2.0.0
*
* @param int $user_id Optional. User ID.
- * @return int user id of the updated user
+ * @return int|WP_Error user id of the updated user
*/
function edit_user( $user_id = 0 ) {
- global $wp_roles;
+ $wp_roles = wp_roles();
$user = new stdClass;
if ( $user_id ) {
$update = true;
@@ -59,7 +59,7 @@
// If the new role isn't editable by the logged-in user die with error
$editable_roles = get_editable_roles();
if ( ! empty( $new_role ) && empty( $editable_roles[$new_role] ) )
- wp_die(__('You can’t give users that role.'));
+ wp_die( __( 'Sorry, you are not allowed to give users that role.' ), 403 );
}
if ( isset( $_POST['email'] ))
@@ -91,9 +91,24 @@
}
if ( $update ) {
- $user->rich_editing = isset( $_POST['rich_editing'] ) && 'false' == $_POST['rich_editing'] ? 'false' : 'true';
+ $user->rich_editing = isset( $_POST['rich_editing'] ) && 'false' === $_POST['rich_editing'] ? 'false' : 'true';
+ $user->syntax_highlighting = isset( $_POST['syntax_highlighting'] ) && 'false' === $_POST['syntax_highlighting'] ? 'false' : 'true';
$user->admin_color = isset( $_POST['admin_color'] ) ? sanitize_text_field( $_POST['admin_color'] ) : 'fresh';
$user->show_admin_bar_front = isset( $_POST['admin_bar_front'] ) ? 'true' : 'false';
+ $user->locale = '';
+
+ if ( isset( $_POST['locale'] ) ) {
+ $locale = sanitize_text_field( $_POST['locale'] );
+ if ( 'site-default' === $locale ) {
+ $locale = '';
+ } elseif ( '' === $locale ) {
+ $locale = 'en_US';
+ } elseif ( ! in_array( $locale, get_available_languages(), true ) ) {
+ $locale = '';
+ }
+
+ $user->locale = $locale;
+ }
}
$user->comment_shortcuts = isset( $_POST['comment_shortcuts'] ) && 'true' == $_POST['comment_shortcuts'] ? 'true' : '';
@@ -108,37 +123,36 @@
if ( $user->user_login == '' )
$errors->add( 'user_login', __( 'ERROR: Please enter a username.' ) );
- /* checking the password has been typed twice */
+ /* checking that nickname has been typed */
+ if ( $update && empty( $user->nickname ) ) {
+ $errors->add( 'nickname', __( 'ERROR: Please enter a nickname.' ) );
+ }
+
/**
* Fires before the password and confirm password fields are checked for congruity.
*
* @since 1.5.1
*
* @param string $user_login The username.
- * @param string &$pass1 The password, passed by reference.
- * @param string &$pass2 The confirmed password, passed by reference.
+ * @param string $pass1 The password (passed by reference).
+ * @param string $pass2 The confirmed password (passed by reference).
*/
do_action_ref_array( 'check_passwords', array( $user->user_login, &$pass1, &$pass2 ) );
- if ( $update ) {
- if ( empty($pass1) && !empty($pass2) )
- $errors->add( 'pass', __( 'ERROR: You entered your new password only once.' ), array( 'form-field' => 'pass1' ) );
- elseif ( !empty($pass1) && empty($pass2) )
- $errors->add( 'pass', __( 'ERROR: You entered your new password only once.' ), array( 'form-field' => 'pass2' ) );
- } else {
- if ( empty($pass1) )
- $errors->add( 'pass', __( 'ERROR: Please enter your password.' ), array( 'form-field' => 'pass1' ) );
- elseif ( empty($pass2) )
- $errors->add( 'pass', __( 'ERROR: Please enter your password twice.' ), array( 'form-field' => 'pass2' ) );
+ // Check for blank password when adding a user.
+ if ( ! $update && empty( $pass1 ) ) {
+ $errors->add( 'pass', __( 'ERROR: Please enter a password.' ), array( 'form-field' => 'pass1' ) );
}
- /* Check for "\" in password */
- if ( false !== strpos( wp_unslash( $pass1 ), "\\" ) )
+ // Check for "\" in password.
+ if ( false !== strpos( wp_unslash( $pass1 ), "\\" ) ) {
$errors->add( 'pass', __( 'ERROR: Passwords may not contain the character "\\".' ), array( 'form-field' => 'pass1' ) );
+ }
- /* checking the password has been typed twice the same */
- if ( $pass1 != $pass2 )
- $errors->add( 'pass', __( 'ERROR: Please enter the same password in the two password fields.' ), array( 'form-field' => 'pass1' ) );
+ // Checking the password has been typed twice the same.
+ if ( ( $update || ! empty( $pass1 ) ) && $pass1 != $pass2 ) {
+ $errors->add( 'pass', __( 'ERROR: Please enter the same password in both password fields.' ), array( 'form-field' => 'pass1' ) );
+ }
if ( !empty( $pass1 ) )
$user->user_pass = $pass1;
@@ -149,9 +163,16 @@
if ( !$update && username_exists( $user->user_login ) )
$errors->add( 'user_login', __( 'ERROR: This username is already registered. Please choose another one.' ));
- /* checking e-mail address */
+ /** This filter is documented in wp-includes/user.php */
+ $illegal_logins = (array) apply_filters( 'illegal_user_logins', array() );
+
+ if ( in_array( strtolower( $user->user_login ), array_map( 'strtolower', $illegal_logins ) ) ) {
+ $errors->add( 'invalid_username', __( 'ERROR: Sorry, that username is not allowed.' ) );
+ }
+
+ /* checking email address */
if ( empty( $user->user_email ) ) {
- $errors->add( 'empty_email', __( 'ERROR: Please enter an e-mail address.' ), array( 'form-field' => 'email' ) );
+ $errors->add( 'empty_email', __( 'ERROR: Please enter an email address.' ), array( 'form-field' => 'email' ) );
} elseif ( !is_email( $user->user_email ) ) {
$errors->add( 'invalid_email', __( 'ERROR: The email address isn’t correct.' ), array( 'form-field' => 'email' ) );
} elseif ( ( $owner_id = email_exists($user->user_email) ) && ( !$update || ( $owner_id != $user->ID ) ) ) {
@@ -163,9 +184,9 @@
*
* @since 2.8.0
*
- * @param array &$errors An array of user profile update errors, passed by reference.
- * @param bool $update Whether this is a user update.
- * @param WP_User &$user WP_User object, passed by reference.
+ * @param WP_Error $errors WP_Error object (passed by reference).
+ * @param bool $update Whether this is a user update.
+ * @param stdClass $user User object (passed by reference).
*/
do_action_ref_array( 'user_profile_update_errors', array( &$errors, $update, &$user ) );
@@ -176,7 +197,18 @@
$user_id = wp_update_user( $user );
} else {
$user_id = wp_insert_user( $user );
- wp_new_user_notification( $user_id, isset( $_POST['send_password'] ) ? wp_unslash( $pass1 ) : '' );
+ $notify = isset( $_POST['send_user_notification'] ) ? 'both' : 'admin';
+
+ /**
+ * Fires after a new user has been created.
+ *
+ * @since 4.4.0
+ *
+ * @param int $user_id ID of the newly created user.
+ * @param string $notify Type of notification that should happen. See wp_send_new_user_notifications()
+ * for more information on possible values.
+ */
+ do_action( 'edit_user_created_user', $user_id, $notify );
}
return $user_id;
}
@@ -198,12 +230,10 @@
* @return array
*/
function get_editable_roles() {
- global $wp_roles;
-
- $all_roles = $wp_roles->roles;
+ $all_roles = wp_roles()->roles;
/**
- * Filter the list of editable roles.
+ * Filters the list of editable roles.
*
* @since 2.8.0
*
@@ -236,6 +266,8 @@
*
* @since 2.0.0
*
+ * @global wpdb $wpdb WordPress database abstraction object.
+ *
* @param int $user_id User ID.
* @return array
*/
@@ -244,7 +276,7 @@
$query = $wpdb->prepare("SELECT ID, post_title FROM $wpdb->posts WHERE post_type = 'post' AND post_status = 'draft' AND post_author = %d ORDER BY post_modified DESC", $user_id);
/**
- * Filter the user's drafts query string.
+ * Filters the user's drafts query string.
*
* @since 2.0.0
*
@@ -258,12 +290,14 @@
* Remove user and optionally reassign posts and links to another user.
*
* If the $reassign parameter is not assigned to a User ID, then all posts will
- * be deleted of that user. The action 'delete_user' that is passed the User ID
+ * be deleted of that user. The action {@see 'delete_user'} that is passed the User ID
* being deleted will be run after the posts are either reassigned or deleted.
* The user meta will also be deleted that are for that User ID.
*
* @since 2.0.0
*
+ * @global wpdb $wpdb WordPress database abstraction object.
+ *
* @param int $id User ID.
* @param int $reassign Optional. Reassign posts and links to new User ID.
* @return bool True when finished.
@@ -271,6 +305,10 @@
function wp_delete_user( $id, $reassign = null ) {
global $wpdb;
+ if ( ! is_numeric( $id ) ) {
+ return false;
+ }
+
$id = (int) $id;
$user = new WP_User( $id );
@@ -306,7 +344,7 @@
}
/**
- * Filter the list of post types to delete with a user.
+ * Filters the list of post types to delete with a user.
*
* @since 3.4.0
*
@@ -384,9 +422,12 @@
$user->remove_all_caps();
}
-add_action('admin_init', 'default_password_nag_handler');
/**
* @since 2.8.0
+ *
+ * @global int $user_ID
+ *
+ * @param false $errors Deprecated.
*/
function default_password_nag_handler($errors = false) {
global $user_ID;
@@ -401,10 +442,11 @@
}
}
-add_action('profile_update', 'default_password_nag_edit_user', 10, 2);
-
/**
* @since 2.8.0
+ *
+ * @param int $user_ID
+ * @param object $old_data
*/
function default_password_nag_edit_user($user_ID, $old_data) {
// Short-circuit it.
@@ -420,10 +462,10 @@
}
}
-add_action('admin_notices', 'default_password_nag');
-
/**
* @since 2.8.0
+ *
+ * @global string $pagenow
*/
function default_password_nag() {
global $pagenow;
@@ -434,9 +476,1111 @@
echo '
';
echo '
';
echo '' . __('Notice:') . ' ';
- _e('You’re using the auto-generated password for your account. Would you like to change it to something easier to remember?');
+ _e('You’re using the auto-generated password for your account. Would you like to change it?');
echo '