diff -r 34716fd837a4 -r be944660c56a wp/wp-admin/js/customize-controls.js --- a/wp/wp-admin/js/customize-controls.js Tue Dec 15 15:52:01 2020 +0100 +++ b/wp/wp-admin/js/customize-controls.js Wed Sep 21 18:19:35 2022 +0200 @@ -289,7 +289,7 @@ collection.focusContainer.focus(); } } else if ( collection.previousActiveElement ) { - $( collection.previousActiveElement ).focus(); + $( collection.previousActiveElement ).trigger( 'focus' ); collection.previousActiveElement = null; } @@ -1342,10 +1342,10 @@ template = wp.template( 'customize-' + container.containerType + '-default' ); } if ( template && container.container ) { - return $.trim( template( _.extend( + return template( _.extend( { id: container.id }, container.params - ) ) ); + ) ).toString().trim(); } return '
  • '; @@ -1592,12 +1592,12 @@ if ( args.unchanged ) { expand = args.completeCallback; } else { - expand = $.proxy( function() { + expand = function() { section._animateChangeExpanded( function() { sectionTitle.attr( 'tabindex', '-1' ); backBtn.attr( 'tabindex', '0' ); - backBtn.focus(); + backBtn.trigger( 'focus' ); content.css( 'top', '' ); container.scrollTop( 0 ); @@ -1609,7 +1609,7 @@ content.addClass( 'open' ); overlay.addClass( 'section-open' ); api.state( 'expandedSection' ).set( section ); - }, this ); + }.bind( this ); } if ( ! args.allowMultiple ) { @@ -1645,7 +1645,7 @@ backBtn.attr( 'tabindex', '-1' ); sectionTitle.attr( 'tabindex', '0' ); - sectionTitle.focus(); + sectionTitle.trigger( 'focus' ); content.css( 'top', '' ); if ( args.completeCallback ) { @@ -2696,12 +2696,12 @@ if ( args.unchanged ) { expand = args.completeCallback; } else { - expand = $.proxy( function() { + expand = function() { section._animateChangeExpanded( function() { sectionTitle.attr( 'tabindex', '-1' ); backBtn.attr( 'tabindex', '0' ); - backBtn.focus(); + backBtn.trigger( 'focus' ); content.css( 'top', '' ); container.scrollTop( 0 ); @@ -2711,7 +2711,7 @@ } ); content.addClass( 'open' ); - }, this ); + }.bind( this ); } if ( section.panel() ) { @@ -2734,7 +2734,7 @@ backBtn.attr( 'tabindex', '-1' ); sectionTitle.attr( 'tabindex', '0' ); - sectionTitle.focus(); + sectionTitle.trigger( 'focus' ); content.css( 'top', '' ); if ( args.completeCallback ) { @@ -2956,7 +2956,7 @@ topPanel.attr( 'tabindex', '-1' ); backBtn.attr( 'tabindex', '0' ); - backBtn.focus(); + backBtn.trigger( 'focus' ); accordionSection.css( 'top', '' ); container.scrollTop( 0 ); @@ -3700,8 +3700,8 @@ parentContainer = ( section.contentContainer.is( 'ul' ) ) ? section.contentContainer : section.contentContainer.find( 'ul:first' ); if ( ! control.container.parent().is( parentContainer ) ) { parentContainer.append( control.container ); - control.renderContent(); } + control.renderContent(); control.deferred.embedded.resolve(); }); }); @@ -3874,9 +3874,9 @@ control.container.toggleClass( 'has-notifications', 0 !== notifications.length ); control.container.toggleClass( 'has-error', hasError ); - container.empty().append( $.trim( - control.notificationsTemplate( { notifications: notifications, altNotice: Boolean( control.altNotice ) } ) - ) ); + container.empty().append( + control.notificationsTemplate( { notifications: notifications, altNotice: Boolean( control.altNotice ) } ).trim() + ); }, /** @@ -4485,7 +4485,7 @@ y = control.settings.y.get(); inputValue = String( x ) + ' ' + String( y ); radioInput = control.container.find( 'input[name="background-position"][value="' + inputValue + '"]' ); - radioInput.click(); + radioInput.trigger( 'click' ); } ); control.settings.x.bind( updateRadios ); control.settings.y.bind( updateRadios ); @@ -5452,7 +5452,7 @@ controls = section.controls(); controlIndex = controls.indexOf( control ); if ( controls.length === controlIndex + 1 ) { - $( '#customize-footer-actions .collapse-sidebar' ).focus(); + $( '#customize-footer-actions .collapse-sidebar' ).trigger( 'focus' ); } else { controls[ controlIndex + 1 ].container.find( ':focusable:first' ).focus(); } @@ -6336,7 +6336,7 @@ } ) ); } ); previewFrame.container.append( form ); - form.submit(); + form.trigger( 'submit' ); form.remove(); // No need to keep the form around after submitted. } @@ -7081,7 +7081,7 @@ // Restore focus if there was a reflow and there was an active (focused) element. if ( wasReflowed && activeElement ) { - activeElement.focus(); + activeElement.trigger( 'focus' ); } api.trigger( 'pane-contents-reflowed' ); }, api ); @@ -7712,7 +7712,7 @@ /** * Trash the current changes. * - * Revert the Customizer to it's previously-published state. + * Revert the Customizer to its previously-published state. * * @since 4.9.0 * @@ -8397,10 +8397,10 @@ } // Button bindings. - saveBtn.click( function( event ) { + saveBtn.on( 'click', function( event ) { api.previewer.save(); event.preventDefault(); - }).keydown( function( event ) { + }).on( 'keydown', function( event ) { if ( 9 === event.which ) { // Tab. return; } @@ -8410,7 +8410,7 @@ event.preventDefault(); }); - closeBtn.keydown( function( event ) { + closeBtn.on( 'keydown', function( event ) { if ( 9 === event.which ) { // Tab. return; } @@ -8452,6 +8452,13 @@ return; } + // Abort if we're inside of a block editor instance. + if ( event.target.closest( '.block-editor-writing-flow' ) !== null || + event.target.closest( '.block-editor-block-list__block-popover' ) !== null + ) { + return; + } + // Check for expanded expandable controls (e.g. widgets and nav menus items), sections, and panels. api.control.each( function( control ) { if ( control.expanded && control.expanded() && _.isFunction( control.collapse ) ) { @@ -8752,7 +8759,8 @@ if ( title.length ) { api( 'blogname', function( setting ) { var updateTitle = function() { - title.text( $.trim( setting() ) || api.l10n.untitledBlogName ); + var blogTitle = setting() || ''; + title.text( blogTitle.toString().trim() || api.l10n.untitledBlogName ); }; setting.bind( updateTitle ); updateTitle();