diff -r 3d4e9c994f10 -r a86126ab1dd4 wp/wp-admin/plugins.php --- a/wp/wp-admin/plugins.php Tue Oct 22 16:11:46 2019 +0200 +++ b/wp/wp-admin/plugins.php Tue Dec 15 13:49:49 2020 +0100 @@ -7,7 +7,7 @@ */ /** WordPress Administration Bootstrap */ -require_once( dirname( __FILE__ ) . '/admin.php' ); +require_once __DIR__ . '/admin.php'; if ( ! current_user_can( 'activate_plugins' ) ) { wp_die( __( 'Sorry, you are not allowed to manage plugins for this site.' ) ); @@ -22,7 +22,21 @@ $s = isset( $_REQUEST['s'] ) ? urlencode( wp_unslash( $_REQUEST['s'] ) ) : ''; // Clean up request URI from temporary args for screen options/paging uri's to work as expected. -$_SERVER['REQUEST_URI'] = remove_query_arg( array( 'error', 'deleted', 'activate', 'activate-multi', 'deactivate', 'deactivate-multi', '_error_nonce' ), $_SERVER['REQUEST_URI'] ); +$query_args_to_remove = array( + 'error', + 'deleted', + 'activate', + 'activate-multi', + 'deactivate', + 'deactivate-multi', + 'enabled-auto-update', + 'disabled-auto-update', + 'enabled-auto-update-multi', + 'disabled-auto-update-multi', + '_error_nonce', +); + +$_SERVER['REQUEST_URI'] = remove_query_arg( $query_args_to_remove, $_SERVER['REQUEST_URI'] ); wp_enqueue_script( 'updates' ); @@ -43,7 +57,7 @@ $result = activate_plugin( $plugin, self_admin_url( 'plugins.php?error=true&plugin=' . urlencode( $plugin ) ), is_network_admin() ); if ( is_wp_error( $result ) ) { - if ( 'unexpected_output' == $result->get_error_code() ) { + if ( 'unexpected_output' === $result->get_error_code() ) { $redirect = self_admin_url( 'plugins.php?error=true&charsout=' . strlen( $result->get_error_data() ) . '&plugin=' . urlencode( $plugin ) . "&plugin_status=$status&paged=$page&s=$s" ); wp_redirect( add_query_arg( '_error_nonce', wp_create_nonce( 'plugin-activation-error_' . $plugin ), $redirect ) ); exit; @@ -62,12 +76,14 @@ update_site_option( 'recently_activated', $recent ); } - if ( isset( $_GET['from'] ) && 'import' == $_GET['from'] ) { - wp_redirect( self_admin_url( 'import.php?import=' . str_replace( '-importer', '', dirname( $plugin ) ) ) ); // overrides the ?error=true one above and redirects to the Imports page, stripping the -importer suffix - } elseif ( isset( $_GET['from'] ) && 'press-this' == $_GET['from'] ) { + if ( isset( $_GET['from'] ) && 'import' === $_GET['from'] ) { + // Overrides the ?error=true one above and redirects to the Imports page, stripping the -importer suffix. + wp_redirect( self_admin_url( 'import.php?import=' . str_replace( '-importer', '', dirname( $plugin ) ) ) ); + } elseif ( isset( $_GET['from'] ) && 'press-this' === $_GET['from'] ) { wp_redirect( self_admin_url( 'press-this.php' ) ); } else { - wp_redirect( self_admin_url( "plugins.php?activate=true&plugin_status=$status&paged=$page&s=$s" ) ); // overrides the ?error=true one above + // Overrides the ?error=true one above. + wp_redirect( self_admin_url( "plugins.php?activate=true&plugin_status=$status&paged=$page&s=$s" ) ); } exit; @@ -141,7 +157,7 @@ $parent_file = 'plugins.php'; wp_enqueue_script( 'updates' ); - require_once( ABSPATH . 'wp-admin/admin-header.php' ); + require_once ABSPATH . 'wp-admin/admin-header.php'; echo '
'; echo '

' . esc_html( $title ) . '

'; @@ -151,7 +167,7 @@ echo ""; echo '
'; - require_once( ABSPATH . 'wp-admin/admin-footer.php' ); + require_once ABSPATH . 'wp-admin/admin-footer.php'; exit; case 'error_scrape': @@ -170,8 +186,8 @@ error_reporting( E_CORE_ERROR | E_CORE_WARNING | E_COMPILE_ERROR | E_ERROR | E_WARNING | E_PARSE | E_USER_ERROR | E_USER_WARNING | E_RECOVERABLE_ERROR ); } - @ini_set( 'display_errors', true ); //Ensure that Fatal errors are displayed. - // Go back to "sandbox" scope so we get the same errors as before + ini_set( 'display_errors', true ); // Ensure that fatal errors are displayed. + // Go back to "sandbox" scope so we get the same errors as before. plugin_sandbox_scrape( $plugin ); /** This action is documented in wp-admin/includes/plugin.php */ do_action( "activate_{$plugin}" ); @@ -254,44 +270,48 @@ check_admin_referer( 'bulk-plugins' ); - //$_POST = from the plugin form; $_GET = from the FTP details screen. + // $_POST = from the plugin form; $_GET = from the FTP details screen. $plugins = isset( $_REQUEST['checked'] ) ? (array) wp_unslash( $_REQUEST['checked'] ) : array(); if ( empty( $plugins ) ) { wp_redirect( self_admin_url( "plugins.php?plugin_status=$status&paged=$page&s=$s" ) ); exit; } - $plugins = array_filter( $plugins, 'is_plugin_inactive' ); // Do not allow to delete Activated plugins. + $plugins = array_filter( $plugins, 'is_plugin_inactive' ); // Do not allow to delete activated plugins. if ( empty( $plugins ) ) { wp_redirect( self_admin_url( "plugins.php?error=true&main=true&plugin_status=$status&paged=$page&s=$s" ) ); exit; } // Bail on all if any paths are invalid. - // validate_file() returns truthy for invalid files + // validate_file() returns truthy for invalid files. $invalid_plugin_files = array_filter( $plugins, 'validate_file' ); if ( $invalid_plugin_files ) { wp_redirect( self_admin_url( "plugins.php?plugin_status=$status&paged=$page&s=$s" ) ); exit; } - include( ABSPATH . 'wp-admin/update.php' ); + require ABSPATH . 'wp-admin/update.php'; $parent_file = 'plugins.php'; if ( ! isset( $_REQUEST['verify-delete'] ) ) { wp_enqueue_script( 'jquery' ); - require_once( ABSPATH . 'wp-admin/admin-header.php' ); + require_once ABSPATH . 'wp-admin/admin-header.php'; + ?> -
+
$data ) { $plugin_info[ $plugin_file ] = _get_plugin_data_markup_translate( $plugin_file, $data ); $plugin_info[ $plugin_file ]['is_uninstallable'] = is_uninstallable_plugin( $plugin ); @@ -311,9 +332,11 @@ } } } - $plugins_to_delete = count( $plugin_info ); + + $plugins_to_delete = count( $plugin_info ); + ?> - +

@@ -328,67 +351,77 @@

'; } + ?>
-
+
'true' ), $redirect ); + } elseif ( 'disable-auto-update' === $action ) { + $auto_updates = array_diff( $auto_updates, array( $plugin ) ); + $redirect = add_query_arg( array( 'disabled-auto-update' => 'true' ), $redirect ); + } else { + $plugins = (array) wp_unslash( $_POST['checked'] ); + + if ( 'enable-auto-update-selected' === $action ) { + $new_auto_updates = array_merge( $auto_updates, $plugins ); + $new_auto_updates = array_unique( $new_auto_updates ); + $query_args = array( 'enabled-auto-update-multi' => 'true' ); + } else { + $new_auto_updates = array_diff( $auto_updates, $plugins ); + $query_args = array( 'disabled-auto-update-multi' => 'true' ); + } + + // Return early if all selected plugins already have auto-updates enabled or disabled. + // Must use non-strict comparison, so that array order is not treated as significant. + if ( $new_auto_updates == $auto_updates ) { // phpcs:ignore WordPress.PHP.StrictComparisons.LooseComparison + wp_redirect( $redirect ); + exit; + } + + $auto_updates = $new_auto_updates; + $redirect = add_query_arg( $query_args, $redirect ); + } + + /** This filter is documented in wp-admin/includes/class-wp-plugins-list-table.php */ + $all_items = apply_filters( 'all_plugins', get_plugins() ); + + // Remove plugins that don't exist or have been deleted since the option was last updated. + $auto_updates = array_intersect( $auto_updates, array_keys( $all_items ) ); + + update_site_option( 'auto_update_plugins', $auto_updates ); + + wp_redirect( $redirect ); + exit; default: if ( isset( $_POST['checked'] ) ) { check_admin_referer( 'bulk-plugins' ); - $plugins = isset( $_POST['checked'] ) ? (array) wp_unslash( $_POST['checked'] ) : array(); - $sendback = wp_get_referer(); - /** This action is documented in wp-admin/edit-comments.php */ - $sendback = apply_filters( 'handle_bulk_actions-' . get_current_screen()->id, $sendback, $action, $plugins ); + $screen = get_current_screen()->id; + $sendback = wp_get_referer(); + $plugins = isset( $_POST['checked'] ) ? (array) wp_unslash( $_POST['checked'] ) : array(); + + /** This action is documented in wp-admin/edit.php */ + $sendback = apply_filters( "handle_bulk_actions-{$screen}", $sendback, $action, $plugins ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores wp_safe_redirect( $sendback ); exit; } @@ -436,11 +542,11 @@ 'id' => 'overview', 'title' => __( 'Overview' ), 'content' => - '

' . __( 'Plugins extend and expand the functionality of WordPress. Once a plugin is installed, you may activate it or deactivate it here.' ) . '

' . - '

' . __( 'The search for installed plugins will search for terms in their name, description, or author.' ) . ' ' . __( 'The search results will be updated as you type.' ) . '

' . + '

' . __( 'Plugins extend and expand the functionality of WordPress. Once a plugin is installed, you may activate it or deactivate it here.' ) . '

' . + '

' . __( 'The search for installed plugins will search for terms in their name, description, or author.' ) . ' ' . __( 'The search results will be updated as you type.' ) . '

' . '

' . sprintf( - /* translators: %s: WordPress Plugin Directory URL */ - __( 'If you would like to see more plugins to choose from, click on the “Add New” button and you will be able to browse or search for additional plugins from the WordPress Plugin Directory. Plugins in the WordPress Plugin Directory are designed and developed by third parties, and are compatible with the license WordPress uses. Oh, and they’re free!' ), + /* translators: %s: WordPress Plugin Directory URL. */ + __( 'If you would like to see more plugins to choose from, click on the “Add New” button and you will be able to browse or search for additional plugins from the WordPress Plugin Directory. Plugins in the WordPress Plugin Directory are designed and developed by third parties, and are compatible with the license WordPress uses. Oh, and they’re free!' ), __( 'https://wordpress.org/plugins/' ) ) . '

', ) @@ -450,18 +556,36 @@ 'id' => 'compatibility-problems', 'title' => __( 'Troubleshooting' ), 'content' => - '

' . __( 'Most of the time, plugins play nicely with the core of WordPress and with other plugins. Sometimes, though, a plugin’s code will get in the way of another plugin, causing compatibility issues. If your site starts doing strange things, this may be the problem. Try deactivating all your plugins and re-activating them in various combinations until you isolate which one(s) caused the issue.' ) . '

' . + '

' . __( 'Most of the time, plugins play nicely with the core of WordPress and with other plugins. Sometimes, though, a plugin’s code will get in the way of another plugin, causing compatibility issues. If your site starts doing strange things, this may be the problem. Try deactivating all your plugins and re-activating them in various combinations until you isolate which one(s) caused the issue.' ) . '

' . '

' . sprintf( - /* translators: WP_PLUGIN_DIR constant value */ - __( 'If something goes wrong with a plugin and you can’t use WordPress, delete or rename that file in the %s directory and it will be automatically deactivated.' ), + /* translators: %s: WP_PLUGIN_DIR constant value. */ + __( 'If something goes wrong with a plugin and you can’t use WordPress, delete or rename that file in the %s directory and it will be automatically deactivated.' ), '' . WP_PLUGIN_DIR . '' ) . '

', ) ); +$help_sidebar_autoupdates = ''; + +if ( current_user_can( 'update_plugins' ) && wp_is_auto_update_enabled_for_type( 'plugin' ) ) { + get_current_screen()->add_help_tab( + array( + 'id' => 'plugins-themes-auto-updates', + 'title' => __( 'Auto-updates' ), + 'content' => + '

' . __( 'Auto-updates can be enabled or disabled for each individual plugin. Plugins with auto-updates enabled will display the estimated date of the next auto-update. Auto-updates depends on the WP-Cron task scheduling system.' ) . '

' . + '

' . __( 'Auto-updates are only available for plugins recognized by WordPress.org, or that include a compatible update system.' ) . '

' . + '

' . __( 'Please note: Third-party themes and plugins, or custom code, may override WordPress scheduling.' ) . '

', + ) + ); + + $help_sidebar_autoupdates = '

' . __( 'Learn more: Auto-updates documentation' ) . '

'; +} + get_current_screen()->set_help_sidebar( '

' . __( 'For more information:' ) . '

' . - '

' . __( 'Documentation on Managing Plugins' ) . '

' . + '

' . __( 'Documentation on Managing Plugins' ) . '

' . + $help_sidebar_autoupdates . '

' . __( 'Support' ) . '

' ); @@ -476,30 +600,29 @@ $title = __( 'Plugins' ); $parent_file = 'plugins.php'; -require_once( ABSPATH . 'wp-admin/admin-header.php' ); +require_once ABSPATH . 'wp-admin/admin-header.php'; $invalid = validate_active_plugins(); if ( ! empty( $invalid ) ) { foreach ( $invalid as $plugin_file => $error ) { echo '

'; printf( - /* translators: 1: plugin file, 2: error message */ - __( 'The plugin %1$s has been deactivated due to an error: %2$s' ), + /* translators: 1: Plugin file, 2: Error message. */ + __( 'The plugin %1$s has been deactivated due to an error: %2$s' ), '' . esc_html( $plugin_file ) . '', $error->get_error_message() ); echo '

'; } } -?> -unexpected output during activation.', 'The plugin generated %d characters of unexpected output during activation.', @@ -513,9 +636,11 @@ } else { $errmsg = __( 'Plugin could not be activated because it triggered a fatal error.' ); } + ?>

- +
-

get_error_message() ); ?>

+
+

+ get_error_message() + ); + ?> +

+

deleted.' ); + if ( 1 === (int) $_GET['deleted'] ) { + _e( 'The selected plugin has been deleted.' ); } else { - _e( 'The selected plugins have been deleted.' ); + _e( 'The selected plugins have been deleted.' ); } ?>

- + -

activated.' ); ?>

+

-

activated.' ); ?>

+

-

deactivated.' ); ?>

+

-

deactivated.' ); ?>

- +

+

-

resumed.' ); ?>

+

+ +

+ +

+ +

+ +

@@ -582,7 +727,7 @@ } if ( strlen( $s ) ) { - /* translators: %s: search keywords */ + /* translators: %s: Search query. */ printf( '' . __( 'Search results for “%s”' ) . '', esc_html( urldecode( $s ) ) ); } ?> @@ -627,4 +772,4 @@ wp_print_admin_notice_templates(); wp_print_update_row_templates(); -include( ABSPATH . 'wp-admin/admin-footer.php' ); +require_once ABSPATH . 'wp-admin/admin-footer.php';