diff -r 3d4e9c994f10 -r a86126ab1dd4 wp/wp-admin/includes/class-theme-installer-skin.php --- a/wp/wp-admin/includes/class-theme-installer-skin.php Tue Oct 22 16:11:46 2019 +0200 +++ b/wp/wp-admin/includes/class-theme-installer-skin.php Tue Dec 15 13:49:49 2020 +0100 @@ -18,37 +18,78 @@ class Theme_Installer_Skin extends WP_Upgrader_Skin { public $api; public $type; + public $url; + public $overwrite; + + private $is_downgrading = false; /** * @param array $args */ public function __construct( $args = array() ) { $defaults = array( - 'type' => 'web', - 'url' => '', - 'theme' => '', - 'nonce' => '', - 'title' => '', + 'type' => 'web', + 'url' => '', + 'theme' => '', + 'nonce' => '', + 'title' => '', + 'overwrite' => '', ); $args = wp_parse_args( $args, $defaults ); - $this->type = $args['type']; - $this->api = isset( $args['api'] ) ? $args['api'] : array(); + $this->type = $args['type']; + $this->url = $args['url']; + $this->api = isset( $args['api'] ) ? $args['api'] : array(); + $this->overwrite = $args['overwrite']; parent::__construct( $args ); } /** + * Action to perform before installing a theme. + * + * @since 2.8.0 */ public function before() { if ( ! empty( $this->api ) ) { - $this->upgrader->strings['process_success'] = sprintf( $this->upgrader->strings['process_success_specific'], $this->api->name, $this->api->version ); + $this->upgrader->strings['process_success'] = sprintf( + $this->upgrader->strings['process_success_specific'], + $this->api->name, + $this->api->version + ); } } /** + * Hides the `process_failed` error when updating a theme by uploading a zip file. + * + * @since 5.5.0 + * + * @param WP_Error $wp_error WP_Error. + * @return bool + */ + public function hide_process_failed( $wp_error ) { + if ( + 'upload' === $this->type && + '' === $this->overwrite && + $wp_error->get_error_code() === 'folder_exists' + ) { + return true; + } + + return false; + } + + /** + * Action to perform following a single theme install. + * + * @since 2.8.0 */ public function after() { + if ( $this->do_overwrite() ) { + return; + } + if ( empty( $this->upgrader->result['destination_name'] ) ) { return; } @@ -75,35 +116,59 @@ $install_actions = array(); if ( current_user_can( 'edit_theme_options' ) && current_user_can( 'customize' ) ) { - $customize_url = add_query_arg( + $customize_url = add_query_arg( array( 'theme' => urlencode( $stylesheet ), 'return' => urlencode( admin_url( 'web' === $this->type ? 'theme-install.php' : 'themes.php' ) ), ), admin_url( 'customize.php' ) ); - $install_actions['preview'] = ''; - $install_actions['activate'] .= '' . sprintf( __( 'Activate “%s”' ), $name ) . ''; + + $install_actions['activate'] = sprintf( + ' '; - /* translators: %s: theme name */ - $install_actions['activate'] .= '' . + '%s', + esc_url( $activate_link ), + __( 'Activate' ), + /* translators: %s: Theme name. */ + sprintf( _x( 'Activate “%s”', 'theme' ), $name ) + ); if ( is_network_admin() && current_user_can( 'manage_network_themes' ) ) { - $install_actions['network_enable'] = '' . __( 'Network Enable' ) . ''; + $install_actions['network_enable'] = sprintf( + '%s', + esc_url( wp_nonce_url( 'themes.php?action=enable&theme=' . urlencode( $stylesheet ), 'enable-theme_' . $stylesheet ) ), + __( 'Network Enable' ) + ); } - if ( $this->type == 'web' ) { - $install_actions['themes_page'] = '' . __( 'Return to Theme Installer' ) . ''; + if ( 'web' === $this->type ) { + $install_actions['themes_page'] = sprintf( + '%s', + self_admin_url( 'theme-install.php' ), + __( 'Return to Theme Installer' ) + ); } elseif ( current_user_can( 'switch_themes' ) || current_user_can( 'edit_theme_options' ) ) { - $install_actions['themes_page'] = '' . __( 'Return to Themes page' ) . ''; + $install_actions['themes_page'] = sprintf( + '%s', + self_admin_url( 'themes.php' ), + __( 'Return to Themes page' ) + ); } if ( ! $this->result || is_wp_error( $this->result ) || is_network_admin() || ! current_user_can( 'switch_themes' ) ) { unset( $install_actions['activate'], $install_actions['preview'] ); + } elseif ( get_option( 'template' ) === $stylesheet ) { + unset( $install_actions['activate'] ); } /** @@ -121,4 +186,199 @@ $this->feedback( implode( ' | ', (array) $install_actions ) ); } } + + /** + * Check if the theme can be overwritten and output the HTML for overwriting a theme on upload. + * + * @since 5.5.0 + * + * @return bool Whether the theme can be overwritten and HTML was outputted. + */ + private function do_overwrite() { + if ( 'upload' !== $this->type || ! is_wp_error( $this->result ) || 'folder_exists' !== $this->result->get_error_code() ) { + return false; + } + + $folder = $this->result->get_error_data( 'folder_exists' ); + $folder = rtrim( $folder, '/' ); + + $current_theme_data = false; + $all_themes = wp_get_themes( array( 'errors' => null ) ); + + foreach ( $all_themes as $theme ) { + $stylesheet_dir = wp_normalize_path( $theme->get_stylesheet_directory() ); + + if ( rtrim( $stylesheet_dir, '/' ) !== $folder ) { + continue; + } + + $current_theme_data = $theme; + } + + $new_theme_data = $this->upgrader->new_theme_data; + + if ( ! $current_theme_data || ! $new_theme_data ) { + return false; + } + + echo '
'; + + $install_actions['preview'] = sprintf( + ' ', + esc_url( $customize_url ), + __( 'Live Preview' ), + /* translators: %s: Theme name. */ + sprintf( __( 'Live Preview “%s”' ), $name ) + ); } - $install_actions['activate'] = '' . esc_html( __( 'Current' ) ) . ' | ' . esc_html( __( 'Uploaded' ) ) . ' | ||
---|---|---|---|
' . $label . ' | ' . wp_strip_all_tags( $old_value ) . ' | '; + $table .= ( $diff_field || $diff_version || $invalid_parent ) ? '' : ' | '; + $table .= wp_strip_all_tags( $new_value ) . ' |
' . esc_html( __( 'The theme cannot be updated due to the following:' ) ) . '
'; + $blocked_message .= '' . $warning . '
'; + + $overwrite = $this->is_downgrading ? 'downgrade-theme' : 'update-theme'; + + $install_actions['overwrite_theme'] = sprintf( + '%s', + wp_nonce_url( add_query_arg( 'overwrite', $overwrite, $this->url ), 'theme-upload' ), + __( 'Replace current with uploaded' ) + ); + } else { + echo $blocked_message; + } + + $cancel_url = add_query_arg( 'action', 'upload-theme-cancel-overwrite', $this->url ); + + $install_actions['themes_page'] = sprintf( + '%s', + wp_nonce_url( $cancel_url, 'theme-upload-cancel-overwrite' ), + __( 'Cancel and go back' ) + ); + + /** + * Filters the list of action links available following a single theme installation + * failure when overwriting is allowed. + * + * @since 5.5.0 + * + * @param string[] $install_actions Array of theme action links. + * @param object $api Object containing WordPress.org API theme data. + * @param array $new_theme_data Array with uploaded theme data. + */ + $install_actions = apply_filters( 'install_theme_overwrite_actions', $install_actions, $this->api, $new_theme_data ); + + if ( ! empty( $install_actions ) ) { + printf( + ' ', + __( 'The uploaded file has expired. Please go back and upload it again.' ) + ); + echo '' . implode( ' ', (array) $install_actions ) . '
'; + } + + return true; + } }