diff -r c7c34916027a -r 177826044cd9 wp/wp-includes/customize/class-wp-customize-nav-menu-setting.php --- a/wp/wp-includes/customize/class-wp-customize-nav-menu-setting.php Mon Oct 14 18:06:33 2019 +0200 +++ b/wp/wp-includes/customize/class-wp-customize-nav-menu-setting.php Mon Oct 14 18:28:13 2019 +0200 @@ -206,9 +206,9 @@ return false; } - $undefined = new stdClass(); + $undefined = new stdClass(); $is_placeholder = ( $this->term_id < 0 ); - $is_dirty = ( $undefined !== $this->post_value( $undefined ) ); + $is_dirty = ( $undefined !== $this->post_value( $undefined ) ); if ( ! $is_placeholder && ! $is_dirty ) { return false; } @@ -232,9 +232,9 @@ * * @see wp_get_nav_menus() * - * @param array $menus An array of menu objects. - * @param array $args An array of arguments used to retrieve menu objects. - * @return array + * @param WP_Term[] $menus An array of menu objects. + * @param array $args An array of arguments used to retrieve menu objects. + * @return WP_Term[] Array of menu objects. */ public function filter_wp_get_nav_menus( $menus, $args ) { if ( get_current_blog_id() !== $this->_previewed_blog_id ) { @@ -242,8 +242,8 @@ } $setting_value = $this->value(); - $is_delete = ( false === $setting_value ); - $index = -1; + $is_delete = ( false === $setting_value ); + $index = -1; // Find the existing menu item's position in the list. foreach ( $menus as $i => $menu ) { @@ -260,24 +260,30 @@ } } else { // Handle menus being updated or inserted. - $menu_obj = (object) array_merge( array( - 'term_id' => $this->term_id, - 'term_taxonomy_id' => $this->term_id, - 'slug' => sanitize_title( $setting_value['name'] ), - 'count' => 0, - 'term_group' => 0, - 'taxonomy' => self::TAXONOMY, - 'filter' => 'raw', - ), $setting_value ); + $menu_obj = (object) array_merge( + array( + 'term_id' => $this->term_id, + 'term_taxonomy_id' => $this->term_id, + 'slug' => sanitize_title( $setting_value['name'] ), + 'count' => 0, + 'term_group' => 0, + 'taxonomy' => self::TAXONOMY, + 'filter' => 'raw', + ), + $setting_value + ); array_splice( $menus, $index, ( -1 === $index ? 0 : 1 ), array( $menu_obj ) ); } // Make sure the menu objects get re-sorted after an update/insert. if ( ! $is_delete && ! empty( $args['orderby'] ) ) { - $menus = wp_list_sort( $menus, array( - $args['orderby'] => 'ASC', - ) ); + $menus = wp_list_sort( + $menus, + array( + $args['orderby'] => 'ASC', + ) + ); } // @todo add support for $args['hide_empty'] === true @@ -353,7 +359,8 @@ return $menu_obj; } - $menu_obj = (object) array_merge( array( + $menu_obj = (object) array_merge( + array( 'term_id' => $this->term_id, 'term_taxonomy_id' => $this->term_id, 'slug' => sanitize_title( $setting_value['name'] ), @@ -361,7 +368,9 @@ 'term_group' => 0, 'taxonomy' => self::TAXONOMY, 'filter' => 'raw', - ), $setting_value ); + ), + $setting_value + ); return $menu_obj; } @@ -379,7 +388,7 @@ return $nav_menu_options; } - $menu = $this->value(); + $menu = $this->value(); $nav_menu_options = $this->filter_nav_menu_options_value( $nav_menu_options, $this->term_id, @@ -418,8 +427,8 @@ 'parent' => 0, 'auto_add' => false, ); - $value = array_merge( $default, $value ); - $value = wp_array_slice_assoc( $value, array_keys( $default ) ); + $value = array_merge( $default, $value ); + $value = wp_array_slice_assoc( $value, array_keys( $default ) ); $value['name'] = trim( esc_html( $value['name'] ) ); // This sanitization code is used in wp-admin/nav-menus.php. $value['description'] = sanitize_text_field( $value['description'] ); @@ -494,23 +503,23 @@ $this->update_error = $r; } else { $this->update_status = 'deleted'; - $auto_add = false; + $auto_add = false; } } } else { // Insert or update menu. - $menu_data = wp_array_slice_assoc( $value, array( 'description', 'parent' ) ); + $menu_data = wp_array_slice_assoc( $value, array( 'description', 'parent' ) ); $menu_data['menu-name'] = $value['name']; - $menu_id = $is_placeholder ? 0 : $this->term_id; - $r = wp_update_nav_menu_object( $menu_id, wp_slash( $menu_data ) ); - $original_name = $menu_data['menu-name']; + $menu_id = $is_placeholder ? 0 : $this->term_id; + $r = wp_update_nav_menu_object( $menu_id, wp_slash( $menu_data ) ); + $original_name = $menu_data['menu-name']; $name_conflict_suffix = 1; while ( is_wp_error( $r ) && 'menu_exists' === $r->get_error_code() ) { $name_conflict_suffix += 1; /* translators: 1: original menu name, 2: duplicate count */ $menu_data['menu-name'] = sprintf( __( '%1$s (%2$d)' ), $original_name, $name_conflict_suffix ); - $r = wp_update_nav_menu_object( $menu_id, wp_slash( $menu_data ) ); + $r = wp_update_nav_menu_object( $menu_id, wp_slash( $menu_data ) ); } if ( is_wp_error( $r ) ) { @@ -565,7 +574,7 @@ } $widget_instance['nav_menu'] = $this->term_id; - $updated_widget_instance = $this->manager->widgets->sanitize_widget_js_instance( $widget_instance ); + $updated_widget_instance = $this->manager->widgets->sanitize_widget_js_instance( $widget_instance ); $this->manager->set_post_value( $nav_menu_widget_setting->id, $updated_widget_instance ); $nav_menu_widget_setting->save(); @@ -633,7 +642,7 @@ $data['widget_nav_menu_updates'], $this->_widget_nav_menu_updates ); - $this->_widget_nav_menu_updates = array(); + $this->_widget_nav_menu_updates = array(); return $data; }