diff -r c7c34916027a -r 177826044cd9 wp/wp-admin/user-edit.php --- a/wp/wp-admin/user-edit.php Mon Oct 14 18:06:33 2019 +0200 +++ b/wp/wp-admin/user-edit.php Mon Oct 14 18:28:13 2019 +0200 @@ -11,19 +11,21 @@ wp_reset_vars( array( 'action', 'user_id', 'wp_http_referer' ) ); -$user_id = (int) $user_id; +$user_id = (int) $user_id; $current_user = wp_get_current_user(); -if ( ! defined( 'IS_PROFILE_PAGE' ) ) +if ( ! defined( 'IS_PROFILE_PAGE' ) ) { define( 'IS_PROFILE_PAGE', ( $user_id == $current_user->ID ) ); +} -if ( ! $user_id && IS_PROFILE_PAGE ) +if ( ! $user_id && IS_PROFILE_PAGE ) { $user_id = $current_user->ID; -elseif ( ! $user_id && ! IS_PROFILE_PAGE ) - wp_die(__( 'Invalid user ID.' ) ); -elseif ( ! get_userdata( $user_id ) ) - wp_die( __('Invalid user ID.') ); +} elseif ( ! $user_id && ! IS_PROFILE_PAGE ) { + wp_die( __( 'Invalid user ID.' ) ); +} elseif ( ! get_userdata( $user_id ) ) { + wp_die( __( 'Invalid user ID.' ) ); +} -wp_enqueue_script('user-profile'); +wp_enqueue_script( 'user-profile' ); if ( IS_PROFILE_PAGE ) { $title = __( 'Profile' ); @@ -32,34 +34,38 @@ $title = __( 'Edit User %s' ); } -if ( current_user_can('edit_users') && !IS_PROFILE_PAGE ) +if ( current_user_can( 'edit_users' ) && ! IS_PROFILE_PAGE ) { $submenu_file = 'users.php'; -else +} else { $submenu_file = 'profile.php'; +} -if ( current_user_can('edit_users') && !is_user_admin() ) +if ( current_user_can( 'edit_users' ) && ! is_user_admin() ) { $parent_file = 'users.php'; -else +} else { $parent_file = 'profile.php'; +} -$profile_help = '
' . __('Your profile contains information about you (your “account”) as well as some personal options related to using WordPress.') . '
' . - '' . __('You can change your password, turn on keyboard shortcuts, change the color scheme of your WordPress administration screens, and turn off the WYSIWYG (Visual) editor, among other things. You can hide the Toolbar (formerly called the Admin Bar) from the front end of your site, however it cannot be disabled on the admin screens.') . '
' . +$profile_help = '' . __( 'Your profile contains information about you (your “account”) as well as some personal options related to using WordPress.' ) . '
' . + '' . __( 'You can change your password, turn on keyboard shortcuts, change the color scheme of your WordPress administration screens, and turn off the WYSIWYG (Visual) editor, among other things. You can hide the Toolbar (formerly called the Admin Bar) from the front end of your site, however it cannot be disabled on the admin screens.' ) . '
' . '' . __( 'You can select the language you wish to use while using the WordPress administration screen without affecting the language site visitors see.' ) . '
' . - '' . __('Your username cannot be changed, but you can use other fields to enter your real name or a nickname, and change which name to display on your posts.') . '
' . + '' . __( 'Your username cannot be changed, but you can use other fields to enter your real name or a nickname, and change which name to display on your posts.' ) . '
' . '' . __( 'You can log out of other devices, such as your phone or a public computer, by clicking the Log Out Everywhere Else button.' ) . '
' . - '' . __('Required fields are indicated; the rest are optional. Profile information will only be displayed if your theme is set up to do so.') . '
' . - '' . __('Remember to click the Update Profile button when you are finished.') . '
'; + '' . __( 'Required fields are indicated; the rest are optional. Profile information will only be displayed if your theme is set up to do so.' ) . '
' . + '' . __( 'Remember to click the Update Profile button when you are finished.' ) . '
'; -get_current_screen()->add_help_tab( array( - 'id' => 'overview', - 'title' => __('Overview'), - 'content' => $profile_help, -) ); +get_current_screen()->add_help_tab( + array( + 'id' => 'overview', + 'title' => __( 'Overview' ), + 'content' => $profile_help, + ) +); get_current_screen()->set_help_sidebar( - '' . __('For more information:') . '
' . - '' . __('Documentation on User Profiles') . '
' . - '' . __('Support Forums') . '
' + '' . __( 'For more information:' ) . '
' . + '' . __( 'Documentation on User Profiles' ) . '
' . + '' . __( 'Support' ) . '
' ); $wp_http_referer = remove_query_arg( array( 'update', 'delete_count', 'user_id' ), $wp_http_referer ); @@ -88,12 +94,12 @@ } // Execute confirmed email change. See send_confirmation_on_profile_email(). -if ( IS_PROFILE_PAGE && isset( $_GET[ 'newuseremail' ] ) && $current_user->ID ) { +if ( IS_PROFILE_PAGE && isset( $_GET['newuseremail'] ) && $current_user->ID ) { $new_email = get_user_meta( $current_user->ID, '_new_email', true ); - if ( $new_email && hash_equals( $new_email[ 'hash' ], $_GET[ 'newuseremail' ] ) ) { - $user = new stdClass; - $user->ID = $current_user->ID; - $user->user_email = esc_html( trim( $new_email[ 'newemail' ] ) ); + if ( $new_email && hash_equals( $new_email['hash'], $_GET['newuseremail'] ) ) { + $user = new stdClass; + $user->ID = $current_user->ID; + $user->user_email = esc_html( trim( $new_email['newemail'] ) ); if ( is_multisite() && $wpdb->get_var( $wpdb->prepare( "SELECT user_login FROM {$wpdb->signups} WHERE user_login = %s", $current_user->user_login ) ) ) { $wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->signups} SET user_email = %s WHERE user_login = %s", $user->user_email, $current_user->user_login ) ); } @@ -107,132 +113,141 @@ } elseif ( IS_PROFILE_PAGE && ! empty( $_GET['dismiss'] ) && $current_user->ID . '_new_email' === $_GET['dismiss'] ) { check_admin_referer( 'dismiss-' . $current_user->ID . '_new_email' ); delete_user_meta( $current_user->ID, '_new_email' ); - wp_redirect( add_query_arg( array('updated' => 'true'), self_admin_url( 'profile.php' ) ) ); + wp_redirect( add_query_arg( array( 'updated' => 'true' ), self_admin_url( 'profile.php' ) ) ); die(); } -switch ($action) { -case 'update': +switch ( $action ) { + case 'update': + check_admin_referer( 'update-user_' . $user_id ); -check_admin_referer('update-user_' . $user_id); - -if ( !current_user_can('edit_user', $user_id) ) - wp_die(__('Sorry, you are not allowed to edit this user.')); + if ( ! current_user_can( 'edit_user', $user_id ) ) { + wp_die( __( 'Sorry, you are not allowed to edit this user.' ) ); + } -if ( IS_PROFILE_PAGE ) { - /** - * Fires before the page loads on the 'Your Profile' editing screen. - * - * The action only fires if the current user is editing their own profile. - * - * @since 2.0.0 - * - * @param int $user_id The user ID. - */ - do_action( 'personal_options_update', $user_id ); -} else { - /** - * Fires before the page loads on the 'Edit User' screen. - * - * @since 2.7.0 - * - * @param int $user_id The user ID. - */ - do_action( 'edit_user_profile_update', $user_id ); -} + if ( IS_PROFILE_PAGE ) { + /** + * Fires before the page loads on the 'Your Profile' editing screen. + * + * The action only fires if the current user is editing their own profile. + * + * @since 2.0.0 + * + * @param int $user_id The user ID. + */ + do_action( 'personal_options_update', $user_id ); + } else { + /** + * Fires before the page loads on the 'Edit User' screen. + * + * @since 2.7.0 + * + * @param int $user_id The user ID. + */ + do_action( 'edit_user_profile_update', $user_id ); + } -// Update the email address in signups, if present. -if ( is_multisite() ) { - $user = get_userdata( $user_id ); + // Update the email address in signups, if present. + if ( is_multisite() ) { + $user = get_userdata( $user_id ); - if ( $user->user_login && isset( $_POST[ 'email' ] ) && is_email( $_POST[ 'email' ] ) && $wpdb->get_var( $wpdb->prepare( "SELECT user_login FROM {$wpdb->signups} WHERE user_login = %s", $user->user_login ) ) ) { - $wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->signups} SET user_email = %s WHERE user_login = %s", $_POST[ 'email' ], $user_login ) ); - } -} + if ( $user->user_login && isset( $_POST['email'] ) && is_email( $_POST['email'] ) && $wpdb->get_var( $wpdb->prepare( "SELECT user_login FROM {$wpdb->signups} WHERE user_login = %s", $user->user_login ) ) ) { + $wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->signups} SET user_email = %s WHERE user_login = %s", $_POST['email'], $user_login ) ); + } + } -// Update the user. -$errors = edit_user( $user_id ); + // Update the user. + $errors = edit_user( $user_id ); -// Grant or revoke super admin status if requested. -if ( is_multisite() && is_network_admin() && !IS_PROFILE_PAGE && current_user_can( 'manage_network_options' ) && !isset($super_admins) && empty( $_POST['super_admin'] ) == is_super_admin( $user_id ) ) { - empty( $_POST['super_admin'] ) ? revoke_super_admin( $user_id ) : grant_super_admin( $user_id ); -} + // Grant or revoke super admin status if requested. + if ( is_multisite() && is_network_admin() && ! IS_PROFILE_PAGE && current_user_can( 'manage_network_options' ) && ! isset( $super_admins ) && empty( $_POST['super_admin'] ) == is_super_admin( $user_id ) ) { + empty( $_POST['super_admin'] ) ? revoke_super_admin( $user_id ) : grant_super_admin( $user_id ); + } -if ( !is_wp_error( $errors ) ) { - $redirect = add_query_arg( 'updated', true, get_edit_user_link( $user_id ) ); - if ( $wp_http_referer ) - $redirect = add_query_arg('wp_http_referer', urlencode($wp_http_referer), $redirect); - wp_redirect($redirect); - exit; -} + if ( ! is_wp_error( $errors ) ) { + $redirect = add_query_arg( 'updated', true, get_edit_user_link( $user_id ) ); + if ( $wp_http_referer ) { + $redirect = add_query_arg( 'wp_http_referer', urlencode( $wp_http_referer ), $redirect ); + } + wp_redirect( $redirect ); + exit; + } -default: -$profileuser = get_user_to_edit($user_id); + // Intentional fall-through to display $errors. + default: + $profileuser = get_user_to_edit( $user_id ); -if ( !current_user_can('edit_user', $user_id) ) - wp_die(__('Sorry, you are not allowed to edit this user.')); + if ( ! current_user_can( 'edit_user', $user_id ) ) { + wp_die( __( 'Sorry, you are not allowed to edit this user.' ) ); + } -$title = sprintf( $title, $profileuser->display_name ); -$sessions = WP_Session_Tokens::get_instance( $profileuser->ID ); + $title = sprintf( $title, $profileuser->display_name ); + $sessions = WP_Session_Tokens::get_instance( $profileuser->ID ); -include(ABSPATH . 'wp-admin/admin-header.php'); -?> + include( ABSPATH . 'wp-admin/admin-header.php' ); + ?> -ID ) && current_user_can( 'manage_network_options' ) ) { ?> -
\n
", $errors->get_error_messages() ); ?>