diff -r c7c34916027a -r 177826044cd9 wp/wp-admin/custom-background.php --- a/wp/wp-admin/custom-background.php Mon Oct 14 18:06:33 2019 +0200 +++ b/wp/wp-admin/custom-background.php Mon Oct 14 18:28:13 2019 +0200 @@ -44,8 +44,8 @@ * @param callable $admin_header_callback * @param callable $admin_image_div_callback Optional custom image div output callback. */ - public function __construct($admin_header_callback = '', $admin_image_div_callback = '') { - $this->admin_header_callback = $admin_header_callback; + public function __construct( $admin_header_callback = '', $admin_image_div_callback = '' ) { + $this->admin_header_callback = $admin_header_callback; $this->admin_image_div_callback = $admin_image_div_callback; add_action( 'admin_menu', array( $this, 'init' ) ); @@ -82,25 +82,27 @@ * @since 3.0.0 */ public function admin_load() { - get_current_screen()->add_help_tab( array( - 'id' => 'overview', - 'title' => __('Overview'), - 'content' => - '

' . __( 'You can customize the look of your site without touching any of your theme’s code by using a custom background. Your background can be an image or a color.' ) . '

' . - '

' . __( 'To use a background image, simply upload it or choose an image that has already been uploaded to your Media Library by clicking the “Choose Image” button. You can display a single instance of your image, or tile it to fill the screen. You can have your background fixed in place, so your site content moves on top of it, or you can have it scroll with your site.' ) . '

' . - '

' . __( 'You can also choose a background color by clicking the Select Color button and either typing in a legitimate HTML hex value, e.g. “#ff0000” for red, or by choosing a color using the color picker.' ) . '

' . - '

' . __( 'Don’t forget to click on the Save Changes button when you are finished.' ) . '

' - ) ); + get_current_screen()->add_help_tab( + array( + 'id' => 'overview', + 'title' => __( 'Overview' ), + 'content' => + '

' . __( 'You can customize the look of your site without touching any of your theme’s code by using a custom background. Your background can be an image or a color.' ) . '

' . + '

' . __( 'To use a background image, simply upload it or choose an image that has already been uploaded to your Media Library by clicking the “Choose Image” button. You can display a single instance of your image, or tile it to fill the screen. You can have your background fixed in place, so your site content moves on top of it, or you can have it scroll with your site.' ) . '

' . + '

' . __( 'You can also choose a background color by clicking the Select Color button and either typing in a legitimate HTML hex value, e.g. “#ff0000” for red, or by choosing a color using the color picker.' ) . '

' . + '

' . __( 'Don’t forget to click on the Save Changes button when you are finished.' ) . '

', + ) + ); get_current_screen()->set_help_sidebar( '

' . __( 'For more information:' ) . '

' . '

' . __( 'Documentation on Custom Background' ) . '

' . - '

' . __( 'Support Forums' ) . '

' + '

' . __( 'Support' ) . '

' ); wp_enqueue_media(); - wp_enqueue_script('custom-background'); - wp_enqueue_style('wp-color-picker'); + wp_enqueue_script( 'custom-background' ); + wp_enqueue_style( 'wp-color-picker' ); } /** @@ -109,22 +111,23 @@ * @since 3.0.0 */ public function take_action() { - if ( empty($_POST) ) + if ( empty( $_POST ) ) { return; + } - if ( isset($_POST['reset-background']) ) { - check_admin_referer('custom-background-reset', '_wpnonce-custom-background-reset'); - remove_theme_mod('background_image'); - remove_theme_mod('background_image_thumb'); + if ( isset( $_POST['reset-background'] ) ) { + check_admin_referer( 'custom-background-reset', '_wpnonce-custom-background-reset' ); + remove_theme_mod( 'background_image' ); + remove_theme_mod( 'background_image_thumb' ); $this->updated = true; return; } - if ( isset($_POST['remove-background']) ) { + if ( isset( $_POST['remove-background'] ) ) { // @TODO: Uploaded files are not removed here. - check_admin_referer('custom-background-remove', '_wpnonce-custom-background-remove'); - set_theme_mod('background_image', ''); - set_theme_mod('background_image_thumb', ''); + check_admin_referer( 'custom-background-remove', '_wpnonce-custom-background-remove' ); + set_theme_mod( 'background_image', '' ); + set_theme_mod( 'background_image_thumb', '' ); $this->updated = true; wp_safe_redirect( $_POST['_wp_http_referer'] ); return; @@ -199,13 +202,14 @@ set_theme_mod( 'background_attachment', $attachment ); } - if ( isset($_POST['background-color']) ) { - check_admin_referer('custom-background'); - $color = preg_replace('/[^0-9a-fA-F]/', '', $_POST['background-color']); - if ( strlen($color) == 6 || strlen($color) == 3 ) - set_theme_mod('background_color', $color); - else - set_theme_mod('background_color', ''); + if ( isset( $_POST['background-color'] ) ) { + check_admin_referer( 'custom-background' ); + $color = preg_replace( '/[^0-9a-fA-F]/', '', $_POST['background-color'] ); + if ( strlen( $color ) == 6 || strlen( $color ) == 3 ) { + set_theme_mod( 'background_color', $color ); + } else { + set_theme_mod( 'background_color', '' ); + } } $this->updated = true; @@ -217,63 +221,64 @@ * @since 3.0.0 */ public function admin_page() { -?> + ?>

- +

- Customizer.' ), - admin_url( 'customize.php?autofocus[control]=background_image' ) - ); - ?> + Customizer.' ), + admin_url( 'customize.php?autofocus[control]=background_image' ) + ); + ?>

- + -updated ) ) { ?> + updated ) ) { ?>

Visit your site to see how it looks.' ), home_url( '/' ) ); ?>

- + -

+

- +
- + - + - + - - + + - + - + - + - + - + -

+

- +
- + - array( 'label' => __( 'Top Left' ), 'icon' => 'dashicons dashicons-arrow-left-alt' ), - 'center top' => array( 'label' => __( 'Top' ), 'icon' => 'dashicons dashicons-arrow-up-alt' ), - 'right top' => array( 'label' => __( 'Top Right' ), 'icon' => 'dashicons dashicons-arrow-right-alt' ), - ), - array( - 'left center' => array( 'label' => __( 'Left' ), 'icon' => 'dashicons dashicons-arrow-left-alt' ), - 'center center' => array( 'label' => __( 'Center' ), 'icon' => 'background-position-center-icon' ), - 'right center' => array( 'label' => __( 'Right' ), 'icon' => 'dashicons dashicons-arrow-right-alt' ), - ), - array( - 'left bottom' => array( 'label' => __( 'Bottom Left' ), 'icon' => 'dashicons dashicons-arrow-left-alt' ), - 'center bottom' => array( 'label' => __( 'Bottom' ), 'icon' => 'dashicons dashicons-arrow-down-alt' ), - 'right bottom' => array( 'label' => __( 'Bottom Right' ), 'icon' => 'dashicons dashicons-arrow-right-alt' ), - ), -); -?> + $background_position_options = array( + array( + 'left top' => array( + 'label' => __( 'Top Left' ), + 'icon' => 'dashicons dashicons-arrow-left-alt', + ), + 'center top' => array( + 'label' => __( 'Top' ), + 'icon' => 'dashicons dashicons-arrow-up-alt', + ), + 'right top' => array( + 'label' => __( 'Top Right' ), + 'icon' => 'dashicons dashicons-arrow-right-alt', + ), + ), + array( + 'left center' => array( + 'label' => __( 'Left' ), + 'icon' => 'dashicons dashicons-arrow-left-alt', + ), + 'center center' => array( + 'label' => __( 'Center' ), + 'icon' => 'background-position-center-icon', + ), + 'right center' => array( + 'label' => __( 'Right' ), + 'icon' => 'dashicons dashicons-arrow-right-alt', + ), + ), + array( + 'left bottom' => array( + 'label' => __( 'Bottom Left' ), + 'icon' => 'dashicons dashicons-arrow-left-alt', + ), + 'center bottom' => array( + 'label' => __( 'Bottom' ), + 'icon' => 'dashicons dashicons-arrow-down-alt', + ), + 'right bottom' => array( + 'label' => __( 'Bottom Right' ), + 'icon' => 'dashicons dashicons-arrow-right-alt', + ), + ), + ); + ?> - - + +
- false); + check_admin_referer( 'custom-background-upload', '_wpnonce-custom-background-upload' ); + $overrides = array( 'test_form' => false ); $uploaded_file = $_FILES['import']; - $wp_filetype = wp_check_filetype_and_ext( $uploaded_file['tmp_name'], $uploaded_file['name'] ); - if ( ! wp_match_mime_types( 'image', $wp_filetype['type'] ) ) + $wp_filetype = wp_check_filetype_and_ext( $uploaded_file['tmp_name'], $uploaded_file['name'] ); + if ( ! wp_match_mime_types( 'image', $wp_filetype['type'] ) ) { wp_die( __( 'The uploaded file is not a valid image. Please try again.' ) ); + } - $file = wp_handle_upload($uploaded_file, $overrides); + $file = wp_handle_upload( $uploaded_file, $overrides ); - if ( isset($file['error']) ) + if ( isset( $file['error'] ) ) { wp_die( $file['error'] ); + } - $url = $file['url']; - $type = $file['type']; - $file = $file['file']; - $filename = basename($file); + $url = $file['url']; + $type = $file['type']; + $file = $file['file']; + $filename = wp_basename( $file ); // Construct the object array $object = array( - 'post_title' => $filename, - 'post_content' => $url, + 'post_title' => $filename, + 'post_content' => $url, 'post_mime_type' => $type, - 'guid' => $url, - 'context' => 'custom-background' + 'guid' => $url, + 'context' => 'custom-background', ); // Save the data - $id = wp_insert_attachment($object, $file); + $id = wp_insert_attachment( $object, $file ); // Add the meta-data wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $file ) ); - update_post_meta( $id, '_wp_attachment_is_custom_background', get_option('stylesheet' ) ); + update_post_meta( $id, '_wp_attachment_is_custom_background', get_option( 'stylesheet' ) ); - set_theme_mod('background_image', esc_url_raw($url)); + set_theme_mod( 'background_image', esc_url_raw( $url ) ); $thumbnail = wp_get_attachment_image_src( $id, 'thumbnail' ); - set_theme_mod('background_image_thumb', esc_url_raw( $thumbnail[0] ) ); + set_theme_mod( 'background_image_thumb', esc_url_raw( $thumbnail[0] ) ); /** This action is documented in wp-admin/custom-header.php */ do_action( 'wp_create_file_in_uploads', $file, $id ); // For replication @@ -489,7 +525,7 @@ /** * Ajax handler for adding custom background context to an attachment. * - * Triggered when the user adds a new background image from the + * Triggers when the user adds a new background image from the * Media Manager. * * @since 4.1.0 @@ -512,7 +548,6 @@ } /** - * * @since 3.4.0 * @deprecated 3.5.0 * @@ -524,7 +559,6 @@ } /** - * * @since 3.4.0 * @deprecated 3.5.0 * @@ -536,21 +570,33 @@ } /** - * * @since 3.4.0 * @deprecated 3.5.0 */ public function wp_set_background_image() { - if ( ! current_user_can('edit_theme_options') || ! isset( $_POST['attachment_id'] ) ) exit; - $attachment_id = absint($_POST['attachment_id']); + if ( ! current_user_can( 'edit_theme_options' ) || ! isset( $_POST['attachment_id'] ) ) { + exit; + } + $attachment_id = absint( $_POST['attachment_id'] ); /** This filter is documented in wp-admin/includes/media.php */ - $sizes = array_keys(apply_filters( 'image_size_names_choose', array('thumbnail' => __('Thumbnail'), 'medium' => __('Medium'), 'large' => __('Large'), 'full' => __('Full Size')) )); - $size = 'thumbnail'; - if ( in_array( $_POST['size'], $sizes ) ) + $sizes = array_keys( + apply_filters( + 'image_size_names_choose', + array( + 'thumbnail' => __( 'Thumbnail' ), + 'medium' => __( 'Medium' ), + 'large' => __( 'Large' ), + 'full' => __( 'Full Size' ), + ) + ) + ); + $size = 'thumbnail'; + if ( in_array( $_POST['size'], $sizes ) ) { $size = esc_attr( $_POST['size'] ); + } - update_post_meta( $attachment_id, '_wp_attachment_is_custom_background', get_option('stylesheet' ) ); - $url = wp_get_attachment_image_src( $attachment_id, $size ); + update_post_meta( $attachment_id, '_wp_attachment_is_custom_background', get_option( 'stylesheet' ) ); + $url = wp_get_attachment_image_src( $attachment_id, $size ); $thumbnail = wp_get_attachment_image_src( $attachment_id, 'thumbnail' ); set_theme_mod( 'background_image', esc_url_raw( $url[0] ) ); set_theme_mod( 'background_image_thumb', esc_url_raw( $thumbnail[0] ) );