wp/wp-admin/includes/class-wp-filesystem-ftpext.php
changeset 9 177826044cd9
parent 7 cf61fcea0001
child 16 a86126ab1dd4
--- a/wp/wp-admin/includes/class-wp-filesystem-ftpext.php	Mon Oct 14 18:06:33 2019 +0200
+++ b/wp/wp-admin/includes/class-wp-filesystem-ftpext.php	Mon Oct 14 18:28:13 2019 +0200
@@ -14,9 +14,17 @@
  * @see WP_Filesystem_Base
  */
 class WP_Filesystem_FTPext extends WP_Filesystem_Base {
+
+	/**
+	 * @since 2.5.0
+	 * @var resource
+	 */
 	public $link;
 
 	/**
+	 * Constructor.
+	 *
+	 * @since 2.5.0
 	 *
 	 * @param array $opt
 	 */
@@ -25,66 +33,80 @@
 		$this->errors = new WP_Error();
 
 		// Check if possible to use ftp functions.
-		if ( ! extension_loaded('ftp') ) {
-			$this->errors->add('no_ftp_ext', __('The ftp PHP extension is not available'));
+		if ( ! extension_loaded( 'ftp' ) ) {
+			$this->errors->add( 'no_ftp_ext', __( 'The ftp PHP extension is not available' ) );
 			return;
 		}
 
 		// This Class uses the timeout on a per-connection basis, Others use it on a per-action basis.
 
-		if ( ! defined('FS_TIMEOUT') )
-			define('FS_TIMEOUT', 240);
+		if ( ! defined( 'FS_TIMEOUT' ) ) {
+			define( 'FS_TIMEOUT', 240 );
+		}
 
-		if ( empty($opt['port']) )
+		if ( empty( $opt['port'] ) ) {
 			$this->options['port'] = 21;
-		else
+		} else {
 			$this->options['port'] = $opt['port'];
+		}
 
-		if ( empty($opt['hostname']) )
-			$this->errors->add('empty_hostname', __('FTP hostname is required'));
-		else
+		if ( empty( $opt['hostname'] ) ) {
+			$this->errors->add( 'empty_hostname', __( 'FTP hostname is required' ) );
+		} else {
 			$this->options['hostname'] = $opt['hostname'];
+		}
 
 		// Check if the options provided are OK.
-		if ( empty($opt['username']) )
-			$this->errors->add('empty_username', __('FTP username is required'));
-		else
+		if ( empty( $opt['username'] ) ) {
+			$this->errors->add( 'empty_username', __( 'FTP username is required' ) );
+		} else {
 			$this->options['username'] = $opt['username'];
+		}
 
-		if ( empty($opt['password']) )
-			$this->errors->add('empty_password', __('FTP password is required'));
-		else
+		if ( empty( $opt['password'] ) ) {
+			$this->errors->add( 'empty_password', __( 'FTP password is required' ) );
+		} else {
 			$this->options['password'] = $opt['password'];
+		}
 
 		$this->options['ssl'] = false;
-		if ( isset($opt['connection_type']) && 'ftps' == $opt['connection_type'] )
+		if ( isset( $opt['connection_type'] ) && 'ftps' == $opt['connection_type'] ) {
 			$this->options['ssl'] = true;
+		}
 	}
 
 	/**
+	 * Connects filesystem.
 	 *
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @return bool True on success, false on failure.
 	 */
 	public function connect() {
-		if ( isset($this->options['ssl']) && $this->options['ssl'] && function_exists('ftp_ssl_connect') )
-			$this->link = @ftp_ssl_connect($this->options['hostname'], $this->options['port'], FS_CONNECT_TIMEOUT);
-		else
-			$this->link = @ftp_connect($this->options['hostname'], $this->options['port'], FS_CONNECT_TIMEOUT);
+		if ( isset( $this->options['ssl'] ) && $this->options['ssl'] && function_exists( 'ftp_ssl_connect' ) ) {
+			$this->link = @ftp_ssl_connect( $this->options['hostname'], $this->options['port'], FS_CONNECT_TIMEOUT );
+		} else {
+			$this->link = @ftp_connect( $this->options['hostname'], $this->options['port'], FS_CONNECT_TIMEOUT );
+		}
 
 		if ( ! $this->link ) {
-			$this->errors->add( 'connect',
+			$this->errors->add(
+				'connect',
 				/* translators: %s: hostname:port */
-				sprintf( __( 'Failed to connect to FTP Server %s' ),
+				sprintf(
+					__( 'Failed to connect to FTP Server %s' ),
 					$this->options['hostname'] . ':' . $this->options['port']
 				)
 			);
 			return false;
 		}
 
-		if ( ! @ftp_login( $this->link,$this->options['username'], $this->options['password'] ) ) {
-			$this->errors->add( 'auth',
+		if ( ! @ftp_login( $this->link, $this->options['username'], $this->options['password'] ) ) {
+			$this->errors->add(
+				'auth',
 				/* translators: %s: username */
-				sprintf( __( 'Username/Password incorrect for %s' ),
+				sprintf(
+					__( 'Username/Password incorrect for %s' ),
 					$this->options['username']
 				)
 			);
@@ -93,24 +115,25 @@
 
 		// Set the Connection to use Passive FTP
 		@ftp_pasv( $this->link, true );
-		if ( @ftp_get_option($this->link, FTP_TIMEOUT_SEC) < FS_TIMEOUT )
-			@ftp_set_option($this->link, FTP_TIMEOUT_SEC, FS_TIMEOUT);
+		if ( @ftp_get_option( $this->link, FTP_TIMEOUT_SEC ) < FS_TIMEOUT ) {
+			@ftp_set_option( $this->link, FTP_TIMEOUT_SEC, FS_TIMEOUT );
+		}
 
 		return true;
 	}
 
 	/**
-	 * Retrieves the file contents.
+	 * Reads entire file into a string.
 	 *
 	 * @since 2.5.0
 	 *
-	 * @param string $file Filename.
-	 * @return string|false File contents on success, false if no temp file could be opened,
+	 * @param string $file Name of the file to read.
+	 * @return string|false Read data on success, false if no temporary file could be opened,
 	 *                      or if the file couldn't be retrieved.
 	 */
 	public function get_contents( $file ) {
-		$tempfile = wp_tempnam($file);
-		$temp = fopen($tempfile, 'w+');
+		$tempfile = wp_tempnam( $file );
+		$temp     = fopen( $tempfile, 'w+' );
 
 		if ( ! $temp ) {
 			unlink( $tempfile );
@@ -126,33 +149,41 @@
 		fseek( $temp, 0 ); // Skip back to the start of the file being written to
 		$contents = '';
 
-		while ( ! feof($temp) )
-			$contents .= fread($temp, 8192);
+		while ( ! feof( $temp ) ) {
+			$contents .= fread( $temp, 8 * KB_IN_BYTES );
+		}
 
-		fclose($temp);
-		unlink($tempfile);
+		fclose( $temp );
+		unlink( $tempfile );
 		return $contents;
 	}
 
 	/**
+	 * Reads entire file into an array.
 	 *
-	 * @param string $file
-	 * @return array
+	 * @since 2.5.0
+	 *
+	 * @param string $file Path to the file.
+	 * @return array|false File contents in an array on success, false on failure.
 	 */
-	public function get_contents_array($file) {
-		return explode("\n", $this->get_contents($file));
+	public function get_contents_array( $file ) {
+		return explode( "\n", $this->get_contents( $file ) );
 	}
 
 	/**
+	 * Writes a string to a file.
 	 *
-	 * @param string $file
-	 * @param string $contents
-	 * @param bool|int $mode
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string    $file     Remote path to the file where to write the data.
+	 * @param string    $contents The data to write.
+	 * @param int|false $mode     Optional. The file permissions as octal number, usually 0644.
+	 *                            Default false.
+	 * @return bool True on success, false on failure.
 	 */
-	public function put_contents($file, $contents, $mode = false ) {
-		$tempfile = wp_tempnam($file);
-		$temp = fopen( $tempfile, 'wb+' );
+	public function put_contents( $file, $contents, $mode = false ) {
+		$tempfile = wp_tempnam( $file );
+		$temp     = fopen( $tempfile, 'wb+' );
 
 		if ( ! $temp ) {
 			unlink( $tempfile );
@@ -161,7 +192,7 @@
 
 		mbstring_binary_safe_encoding();
 
-		$data_length = strlen( $contents );
+		$data_length   = strlen( $contents );
 		$bytes_written = fwrite( $temp, $contents );
 
 		reset_mbstring_encoding();
@@ -176,334 +207,429 @@
 
 		$ret = @ftp_fput( $this->link, $file, $temp, FTP_BINARY );
 
-		fclose($temp);
-		unlink($tempfile);
+		fclose( $temp );
+		unlink( $tempfile );
 
-		$this->chmod($file, $mode);
+		$this->chmod( $file, $mode );
 
 		return $ret;
 	}
 
 	/**
+	 * Gets the current working directory.
 	 *
-	 * @return string
+	 * @since 2.5.0
+	 *
+	 * @return string|false The current working directory on success, false on failure.
 	 */
 	public function cwd() {
-		$cwd = @ftp_pwd($this->link);
-		if ( $cwd )
-			$cwd = trailingslashit($cwd);
+		$cwd = @ftp_pwd( $this->link );
+		if ( $cwd ) {
+			$cwd = trailingslashit( $cwd );
+		}
 		return $cwd;
 	}
 
 	/**
+	 * Changes current directory.
 	 *
-	 * @param string $dir
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string $dir The new current directory.
+	 * @return bool True on success, false on failure.
 	 */
-	public function chdir($dir) {
-		return @ftp_chdir($this->link, $dir);
+	public function chdir( $dir ) {
+		return @ftp_chdir( $this->link, $dir );
 	}
 
 	/**
+	 * Changes filesystem permissions.
 	 *
-	 * @param string $file
-	 * @param int $mode
-	 * @param bool $recursive
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string    $file      Path to the file.
+	 * @param int|false $mode      Optional. The permissions as octal number, usually 0644 for files,
+	 *                             0755 for directories. Default false.
+	 * @param bool      $recursive Optional. If set to true, changes file group recursively.
+	 *                             Default false.
+	 * @return bool True on success, false on failure.
 	 */
-	public function chmod($file, $mode = false, $recursive = false) {
+	public function chmod( $file, $mode = false, $recursive = false ) {
 		if ( ! $mode ) {
-			if ( $this->is_file($file) )
+			if ( $this->is_file( $file ) ) {
 				$mode = FS_CHMOD_FILE;
-			elseif ( $this->is_dir($file) )
+			} elseif ( $this->is_dir( $file ) ) {
 				$mode = FS_CHMOD_DIR;
-			else
+			} else {
 				return false;
+			}
 		}
 
 		// chmod any sub-objects if recursive.
-		if ( $recursive && $this->is_dir($file) ) {
-			$filelist = $this->dirlist($file);
-			foreach ( (array)$filelist as $filename => $filemeta )
-				$this->chmod($file . '/' . $filename, $mode, $recursive);
+		if ( $recursive && $this->is_dir( $file ) ) {
+			$filelist = $this->dirlist( $file );
+			foreach ( (array) $filelist as $filename => $filemeta ) {
+				$this->chmod( $file . '/' . $filename, $mode, $recursive );
+			}
 		}
 
 		// chmod the file or directory
-		if ( ! function_exists('ftp_chmod') )
-			return (bool)@ftp_site($this->link, sprintf('CHMOD %o %s', $mode, $file));
-		return (bool)@ftp_chmod($this->link, $mode, $file);
+		if ( ! function_exists( 'ftp_chmod' ) ) {
+			return (bool) @ftp_site( $this->link, sprintf( 'CHMOD %o %s', $mode, $file ) );
+		}
+		return (bool) @ftp_chmod( $this->link, $mode, $file );
 	}
 
 	/**
+	 * Gets the file owner.
 	 *
-	 * @param string $file
-	 * @return string
+	 * @since 2.5.0
+	 *
+	 * @param string $file Path to the file.
+	 * @return string|false Username of the owner on success, false on failure.
 	 */
-	public function owner($file) {
-		$dir = $this->dirlist($file);
-		return $dir[$file]['owner'];
+	public function owner( $file ) {
+		$dir = $this->dirlist( $file );
+		return $dir[ $file ]['owner'];
 	}
+
 	/**
+	 * Gets the permissions of the specified file or filepath in their octal format.
+	 *
+	 * @since 2.5.0
 	 *
-	 * @param string $file
-	 * @return string
+	 * @param string $file Path to the file.
+	 * @return string Mode of the file (the last 3 digits).
 	 */
-	public function getchmod($file) {
-		$dir = $this->dirlist($file);
-		return $dir[$file]['permsn'];
+	public function getchmod( $file ) {
+		$dir = $this->dirlist( $file );
+		return $dir[ $file ]['permsn'];
 	}
 
 	/**
+	 * Gets the file's group.
 	 *
-	 * @param string $file
-	 * @return string
+	 * @since 2.5.0
+	 *
+	 * @param string $file Path to the file.
+	 * @return string|false The group on success, false on failure.
 	 */
-	public function group($file) {
-		$dir = $this->dirlist($file);
-		return $dir[$file]['group'];
+	public function group( $file ) {
+		$dir = $this->dirlist( $file );
+		return $dir[ $file ]['group'];
 	}
 
 	/**
+	 * Copies a file.
 	 *
-	 * @param string $source
-	 * @param string $destination
-	 * @param bool   $overwrite
-	 * @param string|bool $mode
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string    $source      Path to the source file.
+	 * @param string    $destination Path to the destination file.
+	 * @param bool      $overwrite   Optional. Whether to overwrite the destination file if it exists.
+	 *                               Default false.
+	 * @param int|false $mode        Optional. The permissions as octal number, usually 0644 for files,
+	 *                               0755 for dirs. Default false.
+	 * @return bool True on success, false on failure.
 	 */
-	public function copy($source, $destination, $overwrite = false, $mode = false) {
-		if ( ! $overwrite && $this->exists($destination) )
+	public function copy( $source, $destination, $overwrite = false, $mode = false ) {
+		if ( ! $overwrite && $this->exists( $destination ) ) {
 			return false;
-		$content = $this->get_contents($source);
-		if ( false === $content )
+		}
+		$content = $this->get_contents( $source );
+		if ( false === $content ) {
 			return false;
-		return $this->put_contents($destination, $content, $mode);
+		}
+		return $this->put_contents( $destination, $content, $mode );
 	}
 
 	/**
+	 * Moves a file.
 	 *
-	 * @param string $source
-	 * @param string $destination
-	 * @param bool $overwrite
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string $source      Path to the source file.
+	 * @param string $destination Path to the destination file.
+	 * @param bool   $overwrite   Optional. Whether to overwrite the destination file if it exists.
+	 *                            Default false.
+	 * @return bool True on success, false on failure.
 	 */
-	public function move($source, $destination, $overwrite = false) {
-		return ftp_rename($this->link, $source, $destination);
+	public function move( $source, $destination, $overwrite = false ) {
+		return ftp_rename( $this->link, $source, $destination );
 	}
 
 	/**
+	 * Deletes a file or directory.
 	 *
-	 * @param string $file
-	 * @param bool $recursive
-	 * @param string $type
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string       $file      Path to the file or directory.
+	 * @param bool         $recursive Optional. If set to true, changes file group recursively.
+	 *                                Default false.
+	 * @param string|false $type      Type of resource. 'f' for file, 'd' for directory.
+	 *                                Default false.
+	 * @return bool True on success, false on failure.
 	 */
-	public function delete($file, $recursive = false, $type = false) {
-		if ( empty($file) )
+	public function delete( $file, $recursive = false, $type = false ) {
+		if ( empty( $file ) ) {
 			return false;
-		if ( 'f' == $type || $this->is_file($file) )
-			return @ftp_delete($this->link, $file);
-		if ( !$recursive )
-			return @ftp_rmdir($this->link, $file);
+		}
+		if ( 'f' == $type || $this->is_file( $file ) ) {
+			return @ftp_delete( $this->link, $file );
+		}
+		if ( ! $recursive ) {
+			return @ftp_rmdir( $this->link, $file );
+		}
 
-		$filelist = $this->dirlist( trailingslashit($file) );
-		if ( !empty($filelist) )
-			foreach ( $filelist as $delete_file )
-				$this->delete( trailingslashit($file) . $delete_file['name'], $recursive, $delete_file['type'] );
-		return @ftp_rmdir($this->link, $file);
+		$filelist = $this->dirlist( trailingslashit( $file ) );
+		if ( ! empty( $filelist ) ) {
+			foreach ( $filelist as $delete_file ) {
+				$this->delete( trailingslashit( $file ) . $delete_file['name'], $recursive, $delete_file['type'] );
+			}
+		}
+		return @ftp_rmdir( $this->link, $file );
 	}
 
 	/**
+	 * Checks if a file or directory exists.
 	 *
-	 * @param string $file
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string $file Path to file or directory.
+	 * @return bool Whether $file exists or not.
 	 */
-	public function exists($file) {
-		$list = @ftp_nlist($this->link, $file);
+	public function exists( $file ) {
+		$list = @ftp_nlist( $this->link, $file );
 
 		if ( empty( $list ) && $this->is_dir( $file ) ) {
 			return true; // File is an empty directory.
 		}
 
-		return !empty($list); //empty list = no file, so invert.
+		return ! empty( $list ); //empty list = no file, so invert.
 	}
 
 	/**
+	 * Checks if resource is a file.
 	 *
-	 * @param string $file
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string $file File path.
+	 * @return bool Whether $file is a file.
 	 */
-	public function is_file($file) {
-		return $this->exists($file) && !$this->is_dir($file);
+	public function is_file( $file ) {
+		return $this->exists( $file ) && ! $this->is_dir( $file );
 	}
 
 	/**
+	 * Checks if resource is a directory.
 	 *
-	 * @param string $path
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string $path Directory path.
+	 * @return bool Whether $path is a directory.
 	 */
-	public function is_dir($path) {
-		$cwd = $this->cwd();
-		$result = @ftp_chdir($this->link, trailingslashit($path) );
+	public function is_dir( $path ) {
+		$cwd    = $this->cwd();
+		$result = @ftp_chdir( $this->link, trailingslashit( $path ) );
 		if ( $result && $path == $this->cwd() || $this->cwd() != $cwd ) {
-			@ftp_chdir($this->link, $cwd);
+			@ftp_chdir( $this->link, $cwd );
 			return true;
 		}
 		return false;
 	}
 
 	/**
+	 * Checks if a file is readable.
 	 *
-	 * @param string $file
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string $file Path to file.
+	 * @return bool Whether $file is readable.
 	 */
-	public function is_readable($file) {
-		return true;
-	}
-
-	/**
-	 *
-	 * @param string $file
-	 * @return bool
-	 */
-	public function is_writable($file) {
+	public function is_readable( $file ) {
 		return true;
 	}
 
 	/**
-	 *
-	 * @param string $file
-	 * @return bool
-	 */
-	public function atime($file) {
-		return false;
-	}
-
-	/**
+	 * Checks if a file or directory is writable.
 	 *
-	 * @param string $file
-	 * @return int
-	 */
-	public function mtime($file) {
-		return ftp_mdtm($this->link, $file);
-	}
-
-	/**
+	 * @since 2.5.0
 	 *
-	 * @param string $file
-	 * @return int
+	 * @param string $file Path to file or directory.
+	 * @return bool Whether $file is writable.
 	 */
-	public function size($file) {
-		return ftp_size($this->link, $file);
-	}
-
-	/**
-	 *
-	 * @param string $file
-	 * @return bool
-	 */
-	public function touch($file, $time = 0, $atime = 0) {
-		return false;
-	}
-
-	/**
-	 *
-	 * @param string $path
-	 * @param mixed $chmod
-	 * @param mixed $chown
-	 * @param mixed $chgrp
-	 * @return bool
-	 */
-	public function mkdir($path, $chmod = false, $chown = false, $chgrp = false) {
-		$path = untrailingslashit($path);
-		if ( empty($path) )
-			return false;
-
-		if ( !@ftp_mkdir($this->link, $path) )
-			return false;
-		$this->chmod($path, $chmod);
+	public function is_writable( $file ) {
 		return true;
 	}
 
 	/**
+	 * Gets the file's last access time.
 	 *
-	 * @param string $path
-	 * @param bool $recursive
-	 * @return bool
+	 * @since 2.5.0
+	 *
+	 * @param string $file Path to file.
+	 * @return int|false Unix timestamp representing last access time, false on failure.
 	 */
-	public function rmdir($path, $recursive = false) {
-		return $this->delete($path, $recursive);
+	public function atime( $file ) {
+		return false;
+	}
+
+	/**
+	 * Gets the file modification time.
+	 *
+	 * @since 2.5.0
+	 *
+	 * @param string $file Path to file.
+	 * @return int|false Unix timestamp representing modification time, false on failure.
+	 */
+	public function mtime( $file ) {
+		return ftp_mdtm( $this->link, $file );
+	}
+
+	/**
+	 * Gets the file size (in bytes).
+	 *
+	 * @since 2.5.0
+	 *
+	 * @param string $file Path to file.
+	 * @return int|false Size of the file in bytes on success, false on failure.
+	 */
+	public function size( $file ) {
+		return ftp_size( $this->link, $file );
 	}
 
 	/**
+	 * Sets the access and modification times of a file.
 	 *
+	 * Note: If $file doesn't exist, it will be created.
+	 *
+	 * @since 2.5.0
+	 *
+	 * @param string $file  Path to file.
+	 * @param int    $time  Optional. Modified time to set for file.
+	 *                      Default 0.
+	 * @param int    $atime Optional. Access time to set for file.
+	 *                      Default 0.
+	 * @return bool True on success, false on failure.
+	 */
+	public function touch( $file, $time = 0, $atime = 0 ) {
+		return false;
+	}
+
+	/**
+	 * Creates a directory.
+	 *
+	 * @since 2.5.0
+	 *
+	 * @param string     $path  Path for new directory.
+	 * @param int|false  $chmod Optional. The permissions as octal number (or false to skip chmod).
+	 *                          Default false.
+	 * @param string|int $chown Optional. A user name or number (or false to skip chown).
+	 *                          Default false.
+	 * @param string|int $chgrp Optional. A group name or number (or false to skip chgrp).
+	 *                          Default false.
+	 * @return bool True on success, false on failure.
+	 */
+	public function mkdir( $path, $chmod = false, $chown = false, $chgrp = false ) {
+		$path = untrailingslashit( $path );
+		if ( empty( $path ) ) {
+			return false;
+		}
+
+		if ( ! @ftp_mkdir( $this->link, $path ) ) {
+			return false;
+		}
+		$this->chmod( $path, $chmod );
+		return true;
+	}
+
+	/**
+	 * Deletes a directory.
+	 *
+	 * @since 2.5.0
+	 *
+	 * @param string $path      Path to directory.
+	 * @param bool   $recursive Optional. Whether to recursively remove files/directories.
+	 *                          Default false.
+	 * @return bool True on success, false on failure.
+	 */
+	public function rmdir( $path, $recursive = false ) {
+		return $this->delete( $path, $recursive );
+	}
+
+	/**
 	 * @staticvar bool $is_windows
 	 * @param string $line
 	 * @return array
 	 */
-	public function parselisting($line) {
+	public function parselisting( $line ) {
 		static $is_windows = null;
-		if ( is_null($is_windows) )
-			$is_windows = stripos( ftp_systype($this->link), 'win') !== false;
+		if ( is_null( $is_windows ) ) {
+			$is_windows = stripos( ftp_systype( $this->link ), 'win' ) !== false;
+		}
 
-		if ( $is_windows && preg_match('/([0-9]{2})-([0-9]{2})-([0-9]{2}) +([0-9]{2}):([0-9]{2})(AM|PM) +([0-9]+|<DIR>) +(.+)/', $line, $lucifer) ) {
+		if ( $is_windows && preg_match( '/([0-9]{2})-([0-9]{2})-([0-9]{2}) +([0-9]{2}):([0-9]{2})(AM|PM) +([0-9]+|<DIR>) +(.+)/', $line, $lucifer ) ) {
 			$b = array();
-			if ( $lucifer[3] < 70 )
-				$lucifer[3] +=2000;
-			else
+			if ( $lucifer[3] < 70 ) {
+				$lucifer[3] += 2000;
+			} else {
 				$lucifer[3] += 1900; // 4digit year fix
-			$b['isdir'] = ( $lucifer[7] == '<DIR>');
-			if ( $b['isdir'] )
+			}
+			$b['isdir'] = ( $lucifer[7] == '<DIR>' );
+			if ( $b['isdir'] ) {
 				$b['type'] = 'd';
-			else
+			} else {
 				$b['type'] = 'f';
-			$b['size'] = $lucifer[7];
-			$b['month'] = $lucifer[1];
-			$b['day'] = $lucifer[2];
-			$b['year'] = $lucifer[3];
-			$b['hour'] = $lucifer[4];
+			}
+			$b['size']   = $lucifer[7];
+			$b['month']  = $lucifer[1];
+			$b['day']    = $lucifer[2];
+			$b['year']   = $lucifer[3];
+			$b['hour']   = $lucifer[4];
 			$b['minute'] = $lucifer[5];
-			$b['time'] = @mktime($lucifer[4] + (strcasecmp($lucifer[6], "PM") == 0 ? 12 : 0), $lucifer[5], 0, $lucifer[1], $lucifer[2], $lucifer[3]);
-			$b['am/pm'] = $lucifer[6];
-			$b['name'] = $lucifer[8];
-		} elseif ( !$is_windows && $lucifer = preg_split('/[ ]/', $line, 9, PREG_SPLIT_NO_EMPTY)) {
+			$b['time']   = @mktime( $lucifer[4] + ( strcasecmp( $lucifer[6], 'PM' ) == 0 ? 12 : 0 ), $lucifer[5], 0, $lucifer[1], $lucifer[2], $lucifer[3] );
+			$b['am/pm']  = $lucifer[6];
+			$b['name']   = $lucifer[8];
+		} elseif ( ! $is_windows && $lucifer = preg_split( '/[ ]/', $line, 9, PREG_SPLIT_NO_EMPTY ) ) {
 			//echo $line."\n";
-			$lcount = count($lucifer);
-			if ( $lcount < 8 )
+			$lcount = count( $lucifer );
+			if ( $lcount < 8 ) {
 				return '';
-			$b = array();
-			$b['isdir'] = $lucifer[0]{0} === 'd';
+			}
+			$b           = array();
+			$b['isdir']  = $lucifer[0]{0} === 'd';
 			$b['islink'] = $lucifer[0]{0} === 'l';
-			if ( $b['isdir'] )
+			if ( $b['isdir'] ) {
 				$b['type'] = 'd';
-			elseif ( $b['islink'] )
+			} elseif ( $b['islink'] ) {
 				$b['type'] = 'l';
-			else
+			} else {
 				$b['type'] = 'f';
-			$b['perms'] = $lucifer[0];
+			}
+			$b['perms']  = $lucifer[0];
 			$b['permsn'] = $this->getnumchmodfromh( $b['perms'] );
 			$b['number'] = $lucifer[1];
-			$b['owner'] = $lucifer[2];
-			$b['group'] = $lucifer[3];
-			$b['size'] = $lucifer[4];
+			$b['owner']  = $lucifer[2];
+			$b['group']  = $lucifer[3];
+			$b['size']   = $lucifer[4];
 			if ( $lcount == 8 ) {
-				sscanf($lucifer[5], '%d-%d-%d', $b['year'], $b['month'], $b['day']);
-				sscanf($lucifer[6], '%d:%d', $b['hour'], $b['minute']);
-				$b['time'] = @mktime($b['hour'], $b['minute'], 0, $b['month'], $b['day'], $b['year']);
+				sscanf( $lucifer[5], '%d-%d-%d', $b['year'], $b['month'], $b['day'] );
+				sscanf( $lucifer[6], '%d:%d', $b['hour'], $b['minute'] );
+				$b['time'] = @mktime( $b['hour'], $b['minute'], 0, $b['month'], $b['day'], $b['year'] );
 				$b['name'] = $lucifer[7];
 			} else {
 				$b['month'] = $lucifer[5];
-				$b['day'] = $lucifer[6];
-				if ( preg_match('/([0-9]{2}):([0-9]{2})/', $lucifer[7], $l2) ) {
-					$b['year'] = date("Y");
-					$b['hour'] = $l2[1];
+				$b['day']   = $lucifer[6];
+				if ( preg_match( '/([0-9]{2}):([0-9]{2})/', $lucifer[7], $l2 ) ) {
+					$b['year']   = date( 'Y' );
+					$b['hour']   = $l2[1];
 					$b['minute'] = $l2[2];
 				} else {
-					$b['year'] = $lucifer[7];
-					$b['hour'] = 0;
+					$b['year']   = $lucifer[7];
+					$b['hour']   = 0;
 					$b['minute'] = 0;
 				}
-				$b['time'] = strtotime( sprintf('%d %s %d %02d:%02d', $b['day'], $b['month'], $b['year'], $b['hour'], $b['minute']) );
+				$b['time'] = strtotime( sprintf( '%d %s %d %02d:%02d', $b['day'], $b['month'], $b['year'], $b['hour'], $b['minute'] ) );
 				$b['name'] = $lucifer[8];
 			}
 		}
@@ -517,54 +643,79 @@
 	}
 
 	/**
+	 * Gets details for files in a directory or a specific file.
 	 *
-	 * @param string $path
-	 * @param bool $include_hidden
-	 * @param bool $recursive
-	 * @return bool|array
+	 * @since 2.5.0
+	 *
+	 * @param string $path           Path to directory or file.
+	 * @param bool   $include_hidden Optional. Whether to include details of hidden ("." prefixed) files.
+	 *                               Default true.
+	 * @param bool   $recursive      Optional. Whether to recursively include file details in nested directories.
+	 *                               Default false.
+	 * @return array|false {
+	 *     Array of files. False if unable to list directory contents.
+	 *
+	 *     @type string $name        Name of the file or directory.
+	 *     @type string $perms       *nix representation of permissions.
+	 *     @type int    $permsn      Octal representation of permissions.
+	 *     @type string $owner       Owner name or ID.
+	 *     @type int    $size        Size of file in bytes.
+	 *     @type int    $lastmodunix Last modified unix timestamp.
+	 *     @type mixed  $lastmod     Last modified month (3 letter) and day (without leading 0).
+	 *     @type int    $time        Last modified time.
+	 *     @type string $type        Type of resource. 'f' for file, 'd' for directory.
+	 *     @type mixed  $files       If a directory and $recursive is true, contains another array of files.
+	 * }
 	 */
-	public function dirlist($path = '.', $include_hidden = true, $recursive = false) {
-		if ( $this->is_file($path) ) {
-			$limit_file = basename($path);
-			$path = dirname($path) . '/';
+	public function dirlist( $path = '.', $include_hidden = true, $recursive = false ) {
+		if ( $this->is_file( $path ) ) {
+			$limit_file = basename( $path );
+			$path       = dirname( $path ) . '/';
 		} else {
 			$limit_file = false;
 		}
 
-		$pwd = @ftp_pwd($this->link);
-		if ( ! @ftp_chdir($this->link, $path) ) // Cant change to folder = folder doesn't exist
+		$pwd = @ftp_pwd( $this->link );
+		if ( ! @ftp_chdir( $this->link, $path ) ) { // Can't change to folder = folder doesn't exist.
 			return false;
-		$list = @ftp_rawlist($this->link, '-a', false);
-		@ftp_chdir($this->link, $pwd);
+		}
+		$list = @ftp_rawlist( $this->link, '-a', false );
+		@ftp_chdir( $this->link, $pwd );
 
-		if ( empty($list) ) // Empty array = non-existent folder (real folder will show . at least)
+		if ( empty( $list ) ) { // Empty array = non-existent folder (real folder will show . at least).
 			return false;
+		}
 
 		$dirlist = array();
 		foreach ( $list as $k => $v ) {
-			$entry = $this->parselisting($v);
-			if ( empty($entry) )
+			$entry = $this->parselisting( $v );
+			if ( empty( $entry ) ) {
 				continue;
+			}
 
-			if ( '.' == $entry['name'] || '..' == $entry['name'] )
+			if ( '.' == $entry['name'] || '..' == $entry['name'] ) {
 				continue;
+			}
 
-			if ( ! $include_hidden && '.' == $entry['name'][0] )
+			if ( ! $include_hidden && '.' == $entry['name'][0] ) {
 				continue;
+			}
 
-			if ( $limit_file && $entry['name'] != $limit_file)
+			if ( $limit_file && $entry['name'] != $limit_file ) {
 				continue;
+			}
 
 			$dirlist[ $entry['name'] ] = $entry;
 		}
 
 		$ret = array();
-		foreach ( (array)$dirlist as $struc ) {
+		foreach ( (array) $dirlist as $struc ) {
 			if ( 'd' == $struc['type'] ) {
-				if ( $recursive )
-					$struc['files'] = $this->dirlist($path . '/' . $struc['name'], $include_hidden, $recursive);
-				else
+				if ( $recursive ) {
+					$struc['files'] = $this->dirlist( $path . '/' . $struc['name'], $include_hidden, $recursive );
+				} else {
 					$struc['files'] = array();
+				}
 			}
 
 			$ret[ $struc['name'] ] = $struc;
@@ -573,9 +724,13 @@
 	}
 
 	/**
+	 * Destructor.
+	 *
+	 * @since 2.5.0
 	 */
 	public function __destruct() {
-		if ( $this->link )
-			ftp_close($this->link);
+		if ( $this->link ) {
+			ftp_close( $this->link );
+		}
 	}
 }