enmi-conf.org: comparison wp/wp-includes/theme.php

equal deleted inserted replaced

-:34716fd837a4
+:be944660c56a
 * Validates the theme requirements for WordPress version and PHP version.
 *
 * Uses the information from `Requires at least` and `Requires PHP` headers
 * defined in the theme's `style.css` file.
 *
-* If the headers are not present in the theme's stylesheet file,
-* `readme.txt` is also checked as a fallback.
-*
 * @since 5.5.0
+* @since 5.8.0 Removed support for using `readme.txt` as a fallback.
 *
 * @param string $stylesheet Directory name for the theme.
 * @return true|WP_Error True if requirements are met, WP_Error on failure.
 */
 function validate_theme_requirements( $stylesheet ) {
 	$theme = wp_get_theme( $stylesheet );
+	// If the theme is a Full Site Editing theme, check for the presence of the Gutenberg plugin.
+	$theme_tags = $theme->get( 'Tags' );
+	if ( ! empty( $theme_tags ) && in_array( 'full-site-editing', $theme_tags, true ) && ! function_exists( 'gutenberg_is_fse_theme' ) ) {
+		return new WP_Error(
+			'theme_requires_gutenberg_plugin',
+			sprintf(
+					/* translators: %s: Theme name. */
+				_x( '<strong>Error:</strong> This theme (%s) uses Full Site Editing, which requires the Gutenberg plugin to be activated.', 'theme' ),
+				$theme->display( 'Name' )
+			)
+		);
+	}
 	$requirements = array(
 		'requires'     => ! empty( $theme->get( 'RequiresWP' ) ) ? $theme->get( 'RequiresWP' ) : '',
 		'requires_php' => ! empty( $theme->get( 'RequiresPHP' ) ) ? $theme->get( 'RequiresPHP' ) : '',
 	);
-	$readme_file = $theme->theme_root . '/' . $stylesheet . '/readme.txt';
-	if ( file_exists( $readme_file ) ) {
-		$readme_headers = get_file_data(
-			$readme_file,
-			array(
-				'requires'     => 'Requires at least',
-				'requires_php' => 'Requires PHP',
-			),
-			'theme'
-		);
-		$requirements = array_merge( $readme_headers, $requirements );
-	}
 	$compatible_wp  = is_wp_version_compatible( $requirements['requires'] );
 	$compatible_php = is_php_version_compatible( $requirements['requires_php'] );
 	if ( ! $compatible_wp && ! $compatible_php ) {
 	}
 	if ( is_string( $default ) ) {
 		// Only run the replacement if an sprintf() string format pattern was found.
 		if ( preg_match( '#(?<!%)%(?:\d+\$?)?s#', $default ) ) {
+			// Remove a single trailing percent sign.
+			$default = preg_replace( '#(?<!%)%$#', '', $default );
 			$default = sprintf( $default, get_template_directory_uri(), get_stylesheet_directory_uri() );
 		}
 	}
 	/** This filter is documented in wp-includes/theme.php */
 /**
 * Updates theme modification value for the current theme.
 *
 * @since 2.1.0
+* @since 5.6.0 A return value was added.
 *
 * @param string $name  Theme modification name.
 * @param mixed  $value Theme modification value.
+* @return bool True if the value was updated, false otherwise.
 */
 function set_theme_mod( $name, $value ) {
 	$mods      = get_theme_mods();
 	$old_value = isset( $mods[ $name ] ) ? $mods[ $name ] : false;
 	 * @param string $old_value The current value of the theme modification.
 	 */
 	$mods[ $name ] = apply_filters( "pre_set_theme_mod_{$name}", $value, $old_value );
 	$theme = get_option( 'stylesheet' );
-	update_option( "theme_mods_$theme", $mods );
+	return update_option( "theme_mods_$theme", $mods );
 }
 /**
 * Removes theme modification name from current theme list.
 *
 	if ( empty( $mods ) ) {
 		remove_theme_mods();
 		return;
 	}
 	$theme = get_option( 'stylesheet' );
 	update_option( "theme_mods_$theme", $mods );
 }
 /**
 * Removes theme modifications option for current theme.
 	// Old style.
 	$theme_name = get_option( 'current_theme' );
 	if ( false === $theme_name ) {
 		$theme_name = wp_get_theme()->get( 'Name' );
 	}
 	delete_option( 'mods_' . $theme_name );
 }
 /**
 * Retrieves the custom header text color in 3- or 6-digit hexadecimal form.
 		'widgets'   => array(
 			'text_business_info' => array(
 				'text',
 				array(
 					'title'  => _x( 'Find Us', 'Theme starter content' ),
-					'text'   => join(
+					'text'   => implode(
 						'',
 						array(
 							'<strong>' . _x( 'Address', 'Theme starter content' ) . "</strong>\n",
 							_x( '123 Main Street', 'Theme starter content' ) . "\n" . _x( 'New York, NY 10001', 'Theme starter content' ) . "\n\n",
 							'<strong>' . _x( 'Hours', 'Theme starter content' ) . "</strong>\n",
 * @since 5.3.0 The `html5` feature now also accepts 'script' and 'style'.
 * @since 5.3.0 Formalized the existing and already documented `...$args` parameter
 *              by adding it to the function signature.
 * @since 5.5.0 The `core-block-patterns` feature was added and is enabled by default.
 * @since 5.5.0 The `custom-logo` feature now also accepts 'unlink-homepage-logo'.
+* @since 5.6.0 The `post-formats` feature warns if no array is passed.
+* @since 5.8.0 The `widgets-block-editor` feature enables the Widgets block editor.
 *
 * @global array $_wp_theme_features
 *
-* @param string $feature The feature being added. Likely core values include 'post-formats', 'post-thumbnails',
+* @param string $feature The feature being added. Likely core values include:
-*                        'custom-header', 'custom-background', 'custom-logo', 'menus', 'automatic-feed-links',
+*                          - 'admin-bar'
-*                        'html5', 'title-tag', 'customize-selective-refresh-widgets', 'starter-content',
+*                          - 'align-wide'
-*                        'responsive-embeds', 'align-wide', 'dark-editor-style', 'disable-custom-colors',
+*                          - 'automatic-feed-links'
-*                        'disable-custom-font-sizes', 'editor-color-palette', 'editor-font-sizes',
+*                          - 'core-block-patterns'
-*                        'editor-styles', 'wp-block-styles', and 'core-block-patterns'.
+*                          - 'custom-background'
+*                          - 'custom-header'
+*                          - 'custom-line-height'
+*                          - 'custom-logo'
+*                          - 'customize-selective-refresh-widgets'
+*                          - 'custom-spacing'
+*                          - 'custom-units'
+*                          - 'dark-editor-style'
+*                          - 'disable-custom-colors'
+*                          - 'disable-custom-font-sizes'
+*                          - 'editor-color-palette'
+*                          - 'editor-gradient-presets'
+*                          - 'editor-font-sizes'
+*                          - 'editor-styles'
+*                          - 'featured-content'
+*                          - 'html5'
+*                          - 'menus'
+*                          - 'post-formats'
+*                          - 'post-thumbnails'
+*                          - 'responsive-embeds'
+*                          - 'starter-content'
+*                          - 'title-tag'
+*                          - 'wp-block-styles'
+*                          - 'widgets'
+*                          - 'widgets-block-editor'
 * @param mixed  ...$args Optional extra arguments to pass along with certain features.
-* @return void|bool False on failure, void otherwise.
+* @return void|false Void on success, false on failure.
 */
 function add_theme_support( $feature, ...$args ) {
 	global $_wp_theme_features;
 	if ( ! $args ) {
 			if ( isset( $args[0] ) && is_array( $args[0] ) ) {
 				$post_formats = get_post_format_slugs();
 				unset( $post_formats['standard'] );
 				$args[0] = array_intersect( $args[0], array_keys( $post_formats ) );
+			} else {
+				_doing_it_wrong( "add_theme_support( 'post-formats' )", __( 'You need to pass an array of post formats.' ), '5.6.0' );
+				return false;
 			}
 			break;
 		case 'html5':
 			// You can't just pass 'html5', you need to pass an array of types.

changeset 18	be944660c56a
parent 16	a86126ab1dd4
child 19	3d72ae0968f4