enmi-conf.org: comparison wp/wp-includes/class-wp-xmlrpc-server.php

equal deleted inserted replaced

-:3d4e9c994f10
+:a86126ab1dd4
 	 *
 	 * @since 1.5.0
 	 */
 	public function __construct() {
 		$this->methods = array(
-			// WordPress API
+			// WordPress API.
 			'wp.getUsersBlogs'                 => 'this:wp_getUsersBlogs',
 			'wp.newPost'                       => 'this:wp_newPost',
 			'wp.editPost'                      => 'this:wp_editPost',
 			'wp.deletePost'                    => 'this:wp_deletePost',
 			'wp.getPost'                       => 'this:wp_getPost',
 			'wp.newPage'                       => 'this:wp_newPage',
 			'wp.deletePage'                    => 'this:wp_deletePage',
 			'wp.editPage'                      => 'this:wp_editPage',
 			'wp.getPageList'                   => 'this:wp_getPageList',
 			'wp.getAuthors'                    => 'this:wp_getAuthors',
-			'wp.getCategories'                 => 'this:mw_getCategories',     // Alias
+			'wp.getCategories'                 => 'this:mw_getCategories',     // Alias.
 			'wp.getTags'                       => 'this:wp_getTags',
 			'wp.newCategory'                   => 'this:wp_newCategory',
 			'wp.deleteCategory'                => 'this:wp_deleteCategory',
 			'wp.suggestCategories'             => 'this:wp_suggestCategories',
-			'wp.uploadFile'                    => 'this:mw_newMediaObject',    // Alias
+			'wp.uploadFile'                    => 'this:mw_newMediaObject',    // Alias.
-			'wp.deleteFile'                    => 'this:wp_deletePost',        // Alias
+			'wp.deleteFile'                    => 'this:wp_deletePost',        // Alias.
 			'wp.getCommentCount'               => 'this:wp_getCommentCount',
 			'wp.getPostStatusList'             => 'this:wp_getPostStatusList',
 			'wp.getPageStatusList'             => 'this:wp_getPageStatusList',
 			'wp.getPageTemplates'              => 'this:wp_getPageTemplates',
 			'wp.getOptions'                    => 'this:wp_getOptions',
 			'wp.getPostType'                   => 'this:wp_getPostType',
 			'wp.getPostTypes'                  => 'this:wp_getPostTypes',
 			'wp.getRevisions'                  => 'this:wp_getRevisions',
 			'wp.restoreRevision'               => 'this:wp_restoreRevision',
-			// Blogger API
+			// Blogger API.
 			'blogger.getUsersBlogs'            => 'this:blogger_getUsersBlogs',
 			'blogger.getUserInfo'              => 'this:blogger_getUserInfo',
 			'blogger.getPost'                  => 'this:blogger_getPost',
 			'blogger.getRecentPosts'           => 'this:blogger_getRecentPosts',
 			'blogger.newPost'                  => 'this:blogger_newPost',
 			'blogger.editPost'                 => 'this:blogger_editPost',
 			'blogger.deletePost'               => 'this:blogger_deletePost',
-			// MetaWeblog API (with MT extensions to structs)
+			// MetaWeblog API (with MT extensions to structs).
 			'metaWeblog.newPost'               => 'this:mw_newPost',
 			'metaWeblog.editPost'              => 'this:mw_editPost',
 			'metaWeblog.getPost'               => 'this:mw_getPost',
 			'metaWeblog.getRecentPosts'        => 'this:mw_getRecentPosts',
 			'metaWeblog.getCategories'         => 'this:mw_getCategories',
 			'metaWeblog.newMediaObject'        => 'this:mw_newMediaObject',
-			// MetaWeblog API aliases for Blogger API
+			// MetaWeblog API aliases for Blogger API.
-			// see http://www.xmlrpc.com/stories/storyReader$2460
+			// See http://www.xmlrpc.com/stories/storyReader$2460
 			'metaWeblog.deletePost'            => 'this:blogger_deletePost',
 			'metaWeblog.getUsersBlogs'         => 'this:blogger_getUsersBlogs',
-			// MovableType API
+			// MovableType API.
 			'mt.getCategoryList'               => 'this:mt_getCategoryList',
 			'mt.getRecentPostTitles'           => 'this:mt_getRecentPostTitles',
 			'mt.getPostCategories'             => 'this:mt_getPostCategories',
 			'mt.setPostCategories'             => 'this:mt_setPostCategories',
 			'mt.supportedMethods'              => 'this:mt_supportedMethods',
 			'mt.supportedTextFilters'          => 'this:mt_supportedTextFilters',
 			'mt.getTrackbackPings'             => 'this:mt_getTrackbackPings',
 			'mt.publishPost'                   => 'this:mt_publishPost',
-			// PingBack
+			// Pingback.
 			'pingback.ping'                    => 'this:pingback_ping',
 			'pingback.extensions.getPingbacks' => 'this:pingback_extensions_getPingbacks',
 			'demo.sayHello'                    => 'this:sayHello',
 			'demo.addTwoNumbers'               => 'this:addTwoNumbers',
 		 *
 		 * This filter can be used to add new methods, and remove built-in methods.
 		 *
 		 * @since 1.5.0
 		 *
-		 * @param array $methods An array of XML-RPC methods.
+		 * @param string[] $methods An array of XML-RPC methods, keyed by their methodName.
 		 */
 		$this->methods = apply_filters( 'xmlrpc_methods', $this->methods );
 	}
 	/**
 	 * Make private/protected methods readable for backward compatibility.
 	 *
 	 * @since 4.0.0
 	 *
-	 * @param string   $name      Method to call.
+	 * @param string $name      Method to call.
-	 * @param array    $arguments Arguments to pass when calling.
+	 * @param array  $arguments Arguments to pass when calling.
 	 * @return array|IXR_Error|false Return value of the callback, false otherwise.
 	 */
 	public function __call( $name, $arguments ) {
 		if ( '_multisite_getUsersBlogs' === $name ) {
-			return call_user_func_array( array( $this, $name ), $arguments );
+			return $this->_multisite_getUsersBlogs( ...$arguments );
 		}
 		return false;
 	}
 	/**
 	/**
 	 * Test XMLRPC API by adding two numbers for client.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int $number1 A number to add.
 	 *     @type int $number2 A second number to add.
 	 * }
 		}
 		if ( is_wp_error( $user ) ) {
 			$this->error = new IXR_Error( 403, __( 'Incorrect username or password.' ) );
-			// Flag that authentication has failed once on this wp_xmlrpc_server instance
+			// Flag that authentication has failed once on this wp_xmlrpc_server instance.
 			$this->auth_failed = true;
 			/**
 			 * Filters the XML-RPC user login error message.
 			 *
 			 * @since 3.5.0
 			 *
-			 * @param string  $error The XML-RPC error message.
+			 * @param string   $error The XML-RPC error message.
-			 * @param WP_User $user  WP_User object.
+			 * @param WP_Error $user  WP_Error object.
 			 */
 			$this->error = apply_filters( 'xmlrpc_login_error', $this->error, $user );
 			return false;
 		}
 	/**
 	 * Set custom fields for post.
 	 *
 	 * @since 2.5.0
 	 *
-	 * @param int $post_id Post ID.
+	 * @param int   $post_id Post ID.
-	 * @param array $fields Custom fields.
+	 * @param array $fields  Custom fields.
 	 */
 	public function set_custom_fields( $post_id, $fields ) {
 		$post_id = (int) $post_id;
 		foreach ( (array) $fields as $meta ) {
 	/**
 	 * Set custom fields for a term.
 	 *
 	 * @since 4.9.0
 	 *
-	 * @param int $term_id Term ID.
+	 * @param int   $term_id Term ID.
-	 * @param array $fields Custom fields.
+	 * @param array $fields  Custom fields.
 	 */
 	public function set_term_custom_fields( $term_id, $fields ) {
 		$term_id = (int) $term_id;
 		foreach ( (array) $fields as $meta ) {
 	 *
 	 * @since 2.6.0
 	 */
 	public function initialise_blog_option_info() {
 		$this->blog_options = array(
-			// Read only options
+			// Read-only options.
 			'software_name'           => array(
 				'desc'     => __( 'Software Name' ),
 				'readonly' => true,
 				'value'    => 'WordPress',
 			),
 				'desc'     => __( 'Post Thumbnail' ),
 				'readonly' => true,
 				'value'    => current_theme_supports( 'post-thumbnails' ),
 			),
-			// Updatable options
+			// Updatable options.
 			'time_zone'               => array(
 				'desc'     => __( 'Time Zone' ),
 				'readonly' => false,
 				'option'   => 'gmt_offset',
 			),
 				'desc'     => __( 'Large size image height' ),
 				'readonly' => false,
 				'option'   => 'large_size_h',
 			),
 			'default_comment_status'  => array(
-				'desc'     => __( 'Allow people to post comments on new articles' ),
+				'desc'     => __( 'Allow people to submit comments on new posts.' ),
 				'readonly' => false,
 				'option'   => 'default_comment_status',
 			),
 			'default_ping_status'     => array(
-				'desc'     => __( 'Allow link notifications from other blogs (pingbacks and trackbacks) on new articles' ),
+				'desc'     => __( 'Allow link notifications from other blogs (pingbacks and trackbacks) on new posts.' ),
 				'readonly' => false,
 				'option'   => 'default_ping_status',
 			),
 		);
 	public function wp_getUsersBlogs( $args ) {
 		if ( ! $this->minimum_args( $args, 2 ) ) {
 			return $this->error;
 		}
-		// If this isn't on WPMU then just use blogger_getUsersBlogs
+		// If this isn't on WPMU then just use blogger_getUsersBlogs().
 		if ( ! is_multisite() ) {
 			array_unshift( $args, 1 );
 			return $this->blogger_getUsersBlogs( $args );
 		}
 		$this->escape( $args );
 		$username = $args[0];
 		$password = $args[1];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/**
 		 * Fires after the XML-RPC user has been authenticated but before the rest of
 			$primary_blog_id = (int) $active_blog->blog_id;
 		}
 		foreach ( $blogs as $blog ) {
 			// Don't include blogs that aren't hosted at this site.
-			if ( $blog->site_id != get_current_network_id() ) {
+			if ( get_current_network_id() != $blog->site_id ) {
 				continue;
 			}
 			$blog_id = $blog->userblog_id;
 	/**
 	 * Checks if the method received at least the minimum number of arguments.
 	 *
 	 * @since 3.4.0
 	 *
-	 * @param string|array $args Sanitize single string or array of strings.
+	 * @param array $args  An array of arguments to check.
-	 * @param int $count         Minimum number of arguments.
+	 * @param int   $count Minimum number of arguments.
-	 * @return bool if `$args` contains at least $count arguments.
+	 * @return bool True if `$args` contains at least `$count` arguments, false otherwise.
 	 */
 	protected function minimum_args( $args, $count ) {
-		if ( count( $args ) < $count ) {
+		if ( ! is_array( $args ) || count( $args ) < $count ) {
 			$this->error = new IXR_Error( 400, __( 'Insufficient arguments passed to this XML-RPC method.' ) );
 			return false;
 		}
 		return true;
 	/**
 	 * Prepares taxonomy data for return in an XML-RPC object.
 	 *
 	 * @param object $taxonomy The unprepared taxonomy data.
-	 * @param array $fields    The subset of taxonomy fields to return.
+	 * @param array  $fields   The subset of taxonomy fields to return.
 	 * @return array The prepared taxonomy data.
 	 */
 	protected function _prepare_taxonomy( $taxonomy, $fields ) {
 		$_taxonomy = array(
 			'name'         => $taxonomy->name,
 			'public'       => (bool) $taxonomy->public,
 			'show_ui'      => (bool) $taxonomy->show_ui,
 			'_builtin'     => (bool) $taxonomy->_builtin,
 		);
-		if ( in_array( 'labels', $fields ) ) {
+		if ( in_array( 'labels', $fields, true ) ) {
 			$_taxonomy['labels'] = (array) $taxonomy->labels;
 		}
-		if ( in_array( 'cap', $fields ) ) {
+		if ( in_array( 'cap', $fields, true ) ) {
 			$_taxonomy['cap'] = (array) $taxonomy->cap;
 		}
-		if ( in_array( 'menu', $fields ) ) {
+		if ( in_array( 'menu', $fields, true ) ) {
 			$_taxonomy['show_in_menu'] = (bool) $_taxonomy->show_in_menu;
 		}
-		if ( in_array( 'object_type', $fields ) ) {
+		if ( in_array( 'object_type', $fields, true ) ) {
 			$_taxonomy['object_type'] = array_unique( (array) $taxonomy->object_type );
 		}
 		/**
 		 * Filters XML-RPC-prepared data for the given taxonomy.
 	 *
 	 * @param string $date Date string to convert.
 	 * @return IXR_Date IXR_Date object.
 	 */
 	protected function _convert_date( $date ) {
-		if ( $date === '0000-00-00 00:00:00' ) {
+		if ( '0000-00-00 00:00:00' === $date ) {
 			return new IXR_Date( '00000000T00:00:00Z' );
 		}
 		return new IXR_Date( mysql2date( 'Ymd\TH:i:s', $date, false ) );
 	}
 	 * @param string $date_gmt WordPress GMT date string.
 	 * @param string $date     Date string.
 	 * @return IXR_Date IXR_Date object.
 	 */
 	protected function _convert_date_gmt( $date_gmt, $date ) {
-		if ( $date !== '0000-00-00 00:00:00' && $date_gmt === '0000-00-00 00:00:00' ) {
+		if ( '0000-00-00 00:00:00' !== $date && '0000-00-00 00:00:00' === $date_gmt ) {
 			return new IXR_Date( get_gmt_from_date( mysql2date( 'Y-m-d H:i:s', $date, false ), 'Ymd\TH:i:s' ) );
 		}
 		return $this->_convert_date( $date_gmt );
 	}
 			'link'              => get_permalink( $post['ID'] ),
 			'guid'              => $post['guid'],
 			'menu_order'        => intval( $post['menu_order'] ),
 			'comment_status'    => $post['comment_status'],
 			'ping_status'       => $post['ping_status'],
-			'sticky'            => ( $post['post_type'] === 'post' && is_sticky( $post['ID'] ) ),
+			'sticky'            => ( 'post' === $post['post_type'] && is_sticky( $post['ID'] ) ),
 		);
 		// Thumbnail.
 		$post_fields['post_thumbnail'] = array();
 		$thumbnail_id                  = get_post_thumbnail_id( $post['ID'] );
 			$thumbnail_size                = current_theme_supports( 'post-thumbnail' ) ? 'post-thumbnail' : 'thumbnail';
 			$post_fields['post_thumbnail'] = $this->_prepare_media_item( get_post( $thumbnail_id ), $thumbnail_size );
 		}
 		// Consider future posts as published.
-		if ( $post_fields['post_status'] === 'future' ) {
+		if ( 'future' === $post_fields['post_status'] ) {
 			$post_fields['post_status'] = 'publish';
 		}
 		// Fill in blank post format.
 		$post_fields['post_format'] = get_post_format( $post['ID'] );
 		if ( empty( $post_fields['post_format'] ) ) {
 			$post_fields['post_format'] = 'standard';
 		}
 		// Merge requested $post_fields fields into $_post.
-		if ( in_array( 'post', $fields ) ) {
+		if ( in_array( 'post', $fields, true ) ) {
 			$_post = array_merge( $_post, $post_fields );
 		} else {
 			$requested_fields = array_intersect_key( $post_fields, array_flip( $fields ) );
 			$_post            = array_merge( $_post, $requested_fields );
 		}
-		$all_taxonomy_fields = in_array( 'taxonomies', $fields );
+		$all_taxonomy_fields = in_array( 'taxonomies', $fields, true );
-		if ( $all_taxonomy_fields || in_array( 'terms', $fields ) ) {
+		if ( $all_taxonomy_fields || in_array( 'terms', $fields, true ) ) {
 			$post_type_taxonomies = get_object_taxonomies( $post['post_type'], 'names' );
 			$terms                = wp_get_object_terms( $post['ID'], $post_type_taxonomies );
 			$_post['terms']       = array();
 			foreach ( $terms as $term ) {
 				$_post['terms'][] = $this->_prepare_term( $term );
 			}
 		}
-		if ( in_array( 'custom_fields', $fields ) ) {
+		if ( in_array( 'custom_fields', $fields, true ) ) {
 			$_post['custom_fields'] = $this->get_custom_fields( $post['ID'] );
 		}
-		if ( in_array( 'enclosure', $fields ) ) {
+		if ( in_array( 'enclosure', $fields, true ) ) {
 			$_post['enclosure'] = array();
 			$enclosures         = (array) get_post_meta( $post['ID'], 'enclosure' );
 			if ( ! empty( $enclosures ) ) {
 				$encdata                      = explode( "\n", $enclosures[0] );
 				$_post['enclosure']['url']    = trim( htmlspecialchars( $encdata[0] ) );
 			'_builtin'     => (bool) $post_type->_builtin,
 			'has_archive'  => (bool) $post_type->has_archive,
 			'supports'     => get_all_post_type_supports( $post_type->name ),
 		);
-		if ( in_array( 'labels', $fields ) ) {
+		if ( in_array( 'labels', $fields, true ) ) {
 			$_post_type['labels'] = (array) $post_type->labels;
 		}
-		if ( in_array( 'cap', $fields ) ) {
+		if ( in_array( 'cap', $fields, true ) ) {
 			$_post_type['cap']          = (array) $post_type->cap;
 			$_post_type['map_meta_cap'] = (bool) $post_type->map_meta_cap;
 		}
-		if ( in_array( 'menu', $fields ) ) {
+		if ( in_array( 'menu', $fields, true ) ) {
 			$_post_type['menu_position'] = (int) $post_type->menu_position;
 			$_post_type['menu_icon']     = $post_type->menu_icon;
 			$_post_type['show_in_menu']  = (bool) $post_type->show_in_menu;
 		}
-		if ( in_array( 'taxonomies', $fields ) ) {
+		if ( in_array( 'taxonomies', $fields, true ) ) {
 			$_post_type['taxonomies'] = get_object_taxonomies( $post_type->name, 'names' );
 		}
 		/**
 		 * Filters XML-RPC-prepared date for the given post type.
 		// Format page date.
 		$comment_date_gmt = $this->_convert_date_gmt( $comment->comment_date_gmt, $comment->comment_date );
 		if ( '0' == $comment->comment_approved ) {
 			$comment_status = 'hold';
-		} elseif ( 'spam' == $comment->comment_approved ) {
+		} elseif ( 'spam' === $comment->comment_approved ) {
 			$comment_status = 'spam';
 		} elseif ( '1' == $comment->comment_approved ) {
 			$comment_status = 'approve';
 		} else {
 			$comment_status = $comment->comment_approved;
 			'url'          => $user->user_url,
 			'display_name' => $user->display_name,
 			'roles'        => $user->roles,
 		);
-		if ( in_array( 'all', $fields ) ) {
+		if ( in_array( 'all', $fields, true ) ) {
 			$_user = array_merge( $_user, $user_fields );
 		} else {
-			if ( in_array( 'basic', $fields ) ) {
+			if ( in_array( 'basic', $fields, true ) ) {
 				$basic_fields = array( 'username', 'email', 'registered', 'display_name', 'nicename' );
 				$fields       = array_merge( $fields, $basic_fields );
 			}
 			$requested_fields = array_intersect_key( $user_fields, array_flip( $fields ) );
 			$_user            = array_merge( $_user, $requested_fields );
 	 *
 	 * @since 3.4.0
 	 *
 	 * @link https://en.wikipedia.org/wiki/RSS_enclosure for information on RSS enclosures.
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: top-level arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id        Blog ID (unused).
 	 *     @type string $username       Username.
 	 *     @type string $password       Password.
 		$username       = $args[1];
 		$password       = $args[2];
 		$content_struct = $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
-			return $this->error;
+		if ( ! $user ) {
-		}
+			return $this->error;
+		}
-		// convert the date field back to IXR form
+		// Convert the date field back to IXR form.
 		if ( isset( $content_struct['post_date'] ) && ! ( $content_struct['post_date'] instanceof IXR_Date ) ) {
 			$content_struct['post_date'] = $this->_convert_date( $content_struct['post_date'] );
 		}
-		// ignore the existing GMT date if it is empty or a non-GMT date was supplied in $content_struct,
+		/*
-		// since _insert_post will ignore the non-GMT date if the GMT date is set
+		 * Ignore the existing GMT date if it is empty or a non-GMT date was supplied in $content_struct,
+		 * since _insert_post() will ignore the non-GMT date if the GMT date is set.
+		 */
 		if ( isset( $content_struct['post_date_gmt'] ) && ! ( $content_struct['post_date_gmt'] instanceof IXR_Date ) ) {
-			if ( $content_struct['post_date_gmt'] == '0000-00-00 00:00:00' || isset( $content_struct['post_date'] ) ) {
+			if ( '0000-00-00 00:00:00' === $content_struct['post_date_gmt'] || isset( $content_struct['post_date'] ) ) {
 				unset( $content_struct['post_date_gmt'] );
 			} else {
 				$content_struct['post_date_gmt'] = $this->_convert_date( $content_struct['post_date_gmt'] );
 			}
 		}
 				return new IXR_Error( 401, __( 'Invalid post ID.' ) );
 			}
 			if ( ! current_user_can( 'edit_post', $post_data['ID'] ) ) {
 				return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit this post.' ) );
 			}
-			if ( $post_data['post_type'] != get_post_type( $post_data['ID'] ) ) {
+			if ( get_post_type( $post_data['ID'] ) !== $post_data['post_type'] ) {
 				return new IXR_Error( 401, __( 'The post type may not be changed.' ) );
 			}
 		} else {
 			if ( ! current_user_can( $post_type->cap->create_posts ) || ! current_user_can( $post_type->cap->edit_posts ) ) {
 				return new IXR_Error( 401, __( 'Sorry, you are not allowed to post on this site.' ) );
 			}
 		} else {
 			$post_data['post_author'] = $user->ID;
 		}
-		if ( isset( $post_data['comment_status'] ) && $post_data['comment_status'] != 'open' && $post_data['comment_status'] != 'closed' ) {
+		if ( isset( $post_data['comment_status'] ) && 'open' !== $post_data['comment_status'] && 'closed' !== $post_data['comment_status'] ) {
 			unset( $post_data['comment_status'] );
 		}
-		if ( isset( $post_data['ping_status'] ) && $post_data['ping_status'] != 'open' && $post_data['ping_status'] != 'closed' ) {
+		if ( isset( $post_data['ping_status'] ) && 'open' !== $post_data['ping_status'] && 'closed' !== $post_data['ping_status'] ) {
 			unset( $post_data['ping_status'] );
 		}
 		// Do some timestamp voodoo.
 		if ( ! empty( $post_data['post_date_gmt'] ) ) {
 		// Default to not flagging the post date to be edited unless it's intentional.
 		$post_data['edit_date'] = false;
 		if ( ! empty( $dateCreated ) ) {
-			$post_data['post_date']     = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
+			$post_data['post_date']     = iso8601_to_datetime( $dateCreated );
-			$post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' );
+			$post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'gmt' );
 			// Flag the post date to be edited.
 			$post_data['edit_date'] = true;
 		}
 		if ( ! isset( $post_data['ID'] ) ) {
 			$post_data['ID'] = get_default_post_to_edit( $post_data['post_type'], true )->ID;
 		}
 		$post_ID = $post_data['ID'];
-		if ( $post_data['post_type'] == 'post' ) {
+		if ( 'post' === $post_data['post_type'] ) {
 			$error = $this->_toggle_sticky( $post_data, $update );
 			if ( $error ) {
 				return $error;
 			}
 		}
 		if ( isset( $post_data['post_thumbnail'] ) ) {
-			// empty value deletes, non-empty value adds/updates.
+			// Empty value deletes, non-empty value adds/updates.
 			if ( ! $post_data['post_thumbnail'] ) {
 				delete_post_thumbnail( $post_ID );
 			} elseif ( ! get_post( absint( $post_data['post_thumbnail'] ) ) ) {
 				return new IXR_Error( 404, __( 'Invalid attachment ID.' ) );
 			}
 			// First validate the terms specified by ID.
 			if ( isset( $post_data['terms'] ) && is_array( $post_data['terms'] ) ) {
 				$taxonomies = array_keys( $post_data['terms'] );
-				// Validating term ids.
+				// Validating term IDs.
 				foreach ( $taxonomies as $taxonomy ) {
 					if ( ! array_key_exists( $taxonomy, $post_type_taxonomies ) ) {
 						return new IXR_Error( 401, __( 'Sorry, one of the given taxonomies is not supported by the post type.' ) );
 					}
 					 * in the hierarchy share the same name.
 					 */
 					$ambiguous_terms = array();
 					if ( is_taxonomy_hierarchical( $taxonomy ) ) {
 						$tax_term_names = get_terms(
-							$taxonomy,
 							array(
+								'taxonomy'   => $taxonomy,
 								'fields'     => 'names',
 								'hide_empty' => false,
 							)
 						);
 						$ambiguous_terms = array_keys( $ambiguous_tax_term_counts );
 					}
 					$term_names = $post_data['terms_names'][ $taxonomy ];
 					foreach ( $term_names as $term_name ) {
-						if ( in_array( $term_name, $ambiguous_terms ) ) {
+						if ( in_array( $term_name, $ambiguous_terms, true ) ) {
 							return new IXR_Error( 401, __( 'Ambiguous term name used in a hierarchical taxonomy. Please use term ID instead.' ) );
 						}
 						$term = get_term_by( 'name', $term_name, $taxonomy );
 		if ( is_wp_error( $post_ID ) ) {
 			return new IXR_Error( 500, $post_ID->get_error_message() );
 		}
 		if ( ! $post_ID ) {
-			return new IXR_Error( 401, __( 'Sorry, your entry could not be posted.' ) );
+			if ( $update ) {
+				return new IXR_Error( 401, __( 'Sorry, the post could not be updated.' ) );
+			} else {
+				return new IXR_Error( 401, __( 'Sorry, the post could not be created.' ) );
+			}
 		}
 		return strval( $post_ID );
 	}
 	 * The $content_struct parameter only needs to contain fields that
 	 * should be changed. All other fields will retain their existing values.
 	 *
 	 * @since 3.4.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id        Blog ID (unused).
 	 *     @type string $username       Username.
 	 *     @type string $password       Password.
 		$username       = $args[1];
 		$password       = $args[2];
 		$post_id        = (int) $args[3];
 		$content_struct = $args[4];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.editPost' );
 		/*
 		 * Ignore the existing GMT date if it is empty or a non-GMT date was supplied in $content_struct,
 		 * since _insert_post() will ignore the non-GMT date if the GMT date is set.
 		 */
-		if ( $post['post_date_gmt'] == '0000-00-00 00:00:00' || isset( $content_struct['post_date'] ) ) {
+		if ( '0000-00-00 00:00:00' === $post['post_date_gmt'] || isset( $content_struct['post_date'] ) ) {
 			unset( $post['post_date_gmt'] );
 		} else {
 			$post['post_date_gmt'] = $this->_convert_date( $post['post_date_gmt'] );
 		}
+		/*
+		 * If the API client did not provide 'post_date', then we must not perpetuate the value that
+		 * was stored in the database, or it will appear to be an intentional edit. Conveying it here
+		 * as if it was coming from the API client will cause an otherwise zeroed out 'post_date_gmt'
+		 * to get set with the value that was originally stored in the database when the draft was created.
+		 */
+		if ( ! isset( $content_struct['post_date'] ) ) {
+			unset( $post['post_date'] );
+		}
 		$this->escape( $post );
 		$merged_content_struct = array_merge( $post, $content_struct );
 		$retval = $this->_insert_post( $user, $merged_content_struct );
 		if ( $retval instanceof IXR_Error ) {
 	 *
 	 * @since 3.4.0
 	 *
 	 * @see wp_delete_post()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id  Blog ID (unused).
 	 *     @type string $username Username.
 	 *     @type string $password Password.
 		$username = $args[1];
 		$password = $args[2];
 		$post_id  = (int) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.deletePost' );
 		}
 		$result = wp_delete_post( $post_id );
 		if ( ! $result ) {
-			return new IXR_Error( 500, __( 'The post cannot be deleted.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the post could not be deleted.' ) );
 		}
 		return true;
 	}
 			 * @param string $method Method name.
 			 */
 			$fields = apply_filters( 'xmlrpc_default_post_fields', array( 'post', 'terms', 'custom_fields' ), 'wp.getPost' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getPost' );
 		} else {
 			/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 			$fields = apply_filters( 'xmlrpc_default_post_fields', array( 'post', 'terms', 'custom_fields' ), 'wp.getPosts' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getPosts' );
 		$username       = $args[1];
 		$password       = $args[2];
 		$content_struct = $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.newTerm' );
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to create terms in this taxonomy.' ) );
 		}
 		$taxonomy = (array) $taxonomy;
-		// hold the data of the term
+		// Hold the data of the term.
 		$term_data = array();
 		$term_data['name'] = trim( $content_struct['name'] );
 		if ( empty( $term_data['name'] ) ) {
 			return new IXR_Error( 403, __( 'The term name cannot be empty.' ) );
 		if ( is_wp_error( $term ) ) {
 			return new IXR_Error( 500, $term->get_error_message() );
 		}
 		if ( ! $term ) {
-			return new IXR_Error( 500, __( 'Sorry, your term could not be created.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the term could not be created.' ) );
 		}
 		// Add term meta.
 		if ( isset( $content_struct['custom_fields'] ) ) {
 			$this->set_term_custom_fields( $term['term_id'], $content_struct['custom_fields'] );
 		$username       = $args[1];
 		$password       = $args[2];
 		$term_id        = (int) $args[3];
 		$content_struct = $args[4];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.editTerm' );
 		$taxonomy = get_taxonomy( $content_struct['taxonomy'] );
 		$taxonomy = (array) $taxonomy;
-		// hold the data of the term
+		// Hold the data of the term.
 		$term_data = array();
 		$term = get_term( $term_id, $content_struct['taxonomy'] );
 		if ( is_wp_error( $term ) ) {
 	 *
 	 * @since 3.4.0
 	 *
 	 * @see wp_delete_term()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id      Blog ID (unused).
 	 *     @type string $username     Username.
 	 *     @type string $password     Password.
 		$username = $args[1];
 		$password = $args[2];
 		$taxonomy = $args[3];
 		$term_id  = (int) $args[4];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.deleteTerm' );
 	 *
 	 * @since 3.4.0
 	 *
 	 * @see get_term()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id  Blog ID (unused).
 	 *     @type string $username Username.
 	 *     @type string $password Password.
 		$username = $args[1];
 		$password = $args[2];
 		$taxonomy = $args[3];
 		$term_id  = (int) $args[4];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getTerm' );
 	 * The optional $filter parameter modifies the query used to retrieve terms.
 	 * Accepted keys are 'number', 'offset', 'orderby', 'order', 'hide_empty', and 'search'.
 	 *
 	 * @see get_terms()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id  Blog ID (unused).
 	 *     @type string $username Username.
 	 *     @type string $password Password.
 		$username = $args[1];
 		$password = $args[2];
 		$taxonomy = $args[3];
 		$filter   = isset( $args[4] ) ? $args[4] : array();
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getTerms' );
 		if ( ! current_user_can( $taxonomy->cap->assign_terms ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to assign terms in this taxonomy.' ) );
 		}
-		$query = array();
+		$query = array( 'taxonomy' => $taxonomy->name );
 		if ( isset( $filter['number'] ) ) {
 			$query['number'] = absint( $filter['number'] );
 		}
 		if ( isset( $filter['search'] ) ) {
 			$query['search'] = $filter['search'];
 		}
-		$terms = get_terms( $taxonomy->name, $query );
+		$terms = get_terms( $query );
 		if ( is_wp_error( $terms ) ) {
 			return new IXR_Error( 500, $terms->get_error_message() );
 		}
 	 *
 	 * @since 3.4.0
 	 *
 	 * @see get_taxonomy()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id  Blog ID (unused).
 	 *     @type string $username Username.
 	 *     @type string $password Password.
 			 * @param string $method The method name.
 			 */
 			$fields = apply_filters( 'xmlrpc_default_taxonomy_fields', array( 'labels', 'cap', 'object_type' ), 'wp.getTaxonomy' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getTaxonomy' );
 	 *
 	 * @since 3.4.0
 	 *
 	 * @see get_taxonomies()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id  Blog ID (unused).
 	 *     @type string $username Username.
 	 *     @type string $password Password.
 		} else {
 			/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 			$fields = apply_filters( 'xmlrpc_default_taxonomy_fields', array( 'labels', 'cap', 'object_type' ), 'wp.getTaxonomies' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getTaxonomies' );
 		$taxonomies = get_taxonomies( $filter, 'objects' );
-		// holds all the taxonomy data
+		// Holds all the taxonomy data.
 		$struct = array();
 		foreach ( $taxonomies as $taxonomy ) {
-			// capability check for post_types
+			// Capability check for post types.
 			if ( ! current_user_can( $taxonomy->cap->assign_terms ) ) {
 				continue;
 			}
 			$struct[] = $this->_prepare_taxonomy( $taxonomy, $fields );
 	 * names can be used to specify multiple fields. The available conceptual
 	 * groups are 'basic' and 'all'.
 	 *
 	 * @uses get_userdata()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 			 * @param string $method The method name.
 			 */
 			$fields = apply_filters( 'xmlrpc_default_user_fields', array( 'all' ), 'wp.getUser' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getUser' );
 	 * in the response array.
 	 *
 	 * @uses get_users()
 	 * @see wp_getUser() for more on $fields and return values
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		} else {
 			/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 			$fields = apply_filters( 'xmlrpc_default_user_fields', array( 'all' ), 'wp.getUsers' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getUsers' );
 	/**
 	 * Retrieve information about the requesting user.
 	 *
 	 * @uses get_userdata()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		} else {
 			/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 			$fields = apply_filters( 'xmlrpc_default_user_fields', array( 'all' ), 'wp.getProfile' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getProfile' );
 	/**
 	 * Edit user's profile.
 	 *
 	 * @uses wp_update_user()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username       = $args[1];
 		$password       = $args[2];
 		$content_struct = $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.editProfile' );
 		if ( ! current_user_can( 'edit_user', $user->ID ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit your profile.' ) );
 		}
-		// holds data of the user
+		// Holds data of the user.
 		$user_data       = array();
 		$user_data['ID'] = $user->ID;
-		// only set the user details if it was given
+		// Only set the user details if they were given.
 		if ( isset( $content_struct['first_name'] ) ) {
 			$user_data['first_name'] = $content_struct['first_name'];
 		}
 		if ( isset( $content_struct['last_name'] ) ) {
 		if ( is_wp_error( $result ) ) {
 			return new IXR_Error( 500, $result->get_error_message() );
 		}
 		if ( ! $result ) {
-			return new IXR_Error( 500, __( 'Sorry, the user cannot be updated.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the user could not be updated.' ) );
 		}
 		return true;
 	}
 	/**
 	 * Retrieve page.
 	 *
 	 * @since 2.2.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type int    $page_id
 	 *     @type string $username
 		$page_id  = (int) $args[1];
 		$username = $args[2];
 		$password = $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		$page = get_post( $page_id );
 		if ( ! $page ) {
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getPage' );
 		// If we found the page then format the data.
-		if ( $page->ID && ( $page->post_type == 'page' ) ) {
+		if ( $page->ID && ( 'page' === $page->post_type ) ) {
 			return $this->_prepare_page( $page );
 		} else {
-			// If the page doesn't exist indicate that.
+			// If the page doesn't exist, indicate that.
 			return new IXR_Error( 404, __( 'Sorry, no such page.' ) );
 		}
 	}
 	/**
 	 * Retrieve Pages.
 	 *
 	 * @since 2.2.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username  = $args[1];
 		$password  = $args[2];
 		$num_pages = isset( $args[3] ) ? (int) $args[3] : 10;
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_pages' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit pages.' ) );
 	 *
 	 * @since 2.2.0
 	 *
 	 * @see wp_xmlrpc_server::mw_newPost()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 	 *     @type array  $content_struct
 	 * }
 	 * @return int|IXR_Error
 	 */
 	public function wp_newPage( $args ) {
-		// Items not escaped here will be escaped in newPost.
+		// Items not escaped here will be escaped in wp_newPost().
 		$username = $this->escape( $args[1] );
 		$password = $this->escape( $args[2] );
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.newPage' );
 		// Mark this as content for a page.
 		$args[3]['post_type'] = 'page';
-		// Let mw_newPost do all of the heavy lifting.
+		// Let mw_newPost() do all of the heavy lifting.
 		return $this->mw_newPost( $args );
 	}
 	/**
 	 * Delete page.
 	 *
 	 * @since 2.2.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username = $args[1];
 		$password = $args[2];
 		$page_id  = (int) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.deletePage' );
-		// Get the current page based on the page_id and
+		// Get the current page based on the 'page_id' and
 		// make sure it is a page and not a post.
 		$actual_page = get_post( $page_id, ARRAY_A );
-		if ( ! $actual_page || ( $actual_page['post_type'] != 'page' ) ) {
+		if ( ! $actual_page || ( 'page' !== $actual_page['post_type'] ) ) {
 			return new IXR_Error( 404, __( 'Sorry, no such page.' ) );
 		}
 		// Make sure the user can delete pages.
 		if ( ! current_user_can( 'delete_page', $page_id ) ) {
 		 * @since 3.4.0
 		 *
 		 * @param int   $page_id ID of the deleted page.
 		 * @param array $args    An array of arguments to delete the page.
 		 */
-		do_action( 'xmlrpc_call_success_wp_deletePage', $page_id, $args );
+		do_action( 'xmlrpc_call_success_wp_deletePage', $page_id, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return true;
 	}
 	/**
 	 * Edit page.
 	 *
 	 * @since 2.2.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type int    $page_id
 	 *     @type string $username
 	 *     @type string $publish
 	 * }
 	 * @return array|IXR_Error
 	 */
 	public function wp_editPage( $args ) {
-		// Items will be escaped in mw_editPost.
+		// Items will be escaped in mw_editPost().
 		$page_id  = (int) $args[1];
 		$username = $args[2];
 		$password = $args[3];
 		$content  = $args[4];
 		$publish  = $args[5];
 		$escaped_username = $this->escape( $username );
 		$escaped_password = $this->escape( $password );
-		if ( ! $user = $this->login( $escaped_username, $escaped_password ) ) {
+		$user = $this->login( $escaped_username, $escaped_password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.editPage' );
 		// Get the page data and make sure it is a page.
 		$actual_page = get_post( $page_id, ARRAY_A );
-		if ( ! $actual_page || ( $actual_page['post_type'] != 'page' ) ) {
+		if ( ! $actual_page || ( 'page' !== $actual_page['post_type'] ) ) {
 			return new IXR_Error( 404, __( 'Sorry, no such page.' ) );
 		}
 		// Make sure the user is allowed to edit pages.
 		if ( ! current_user_can( 'edit_page', $page_id ) ) {
 		}
 		// Mark this as content for a page.
 		$content['post_type'] = 'page';
-		// Arrange args in the way mw_editPost understands.
+		// Arrange args in the way mw_editPost() understands.
 		$args = array(
 			$page_id,
 			$username,
 			$password,
 			$content,
 			$publish,
 		);
-		// Let mw_editPost do all of the heavy lifting.
+		// Let mw_editPost() do all of the heavy lifting.
 		return $this->mw_editPost( $args );
 	}
 	/**
 	 * Retrieve page list.
 	 *
 	 * @since 2.2.0
 	 *
 	 * @global wpdb $wpdb WordPress database abstraction object.
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_pages' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit pages.' ) );
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getPageList' );
-		// Get list of pages ids and titles
+		// Get list of page IDs and titles.
 		$page_list = $wpdb->get_results(
 			"
 			SELECT ID page_id,
 				post_title page_title,
 				post_parent page_parent_id,
 	/**
 	 * Retrieve authors list.
 	 *
 	 * @since 2.2.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit posts.' ) );
 	/**
 	 * Get list of all tags
 	 *
 	 * @since 2.7.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you must be able to edit posts on this site in order to view tags.' ) );
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getKeywords' );
 		$tags = array();
-		if ( $all_tags = get_tags() ) {
+		$all_tags = get_tags();
+		if ( $all_tags ) {
 			foreach ( (array) $all_tags as $tag ) {
 				$struct             = array();
 				$struct['tag_id']   = $tag->term_id;
 				$struct['name']     = $tag->name;
 				$struct['count']    = $tag->count;
 	/**
 	 * Create new category.
 	 *
 	 * @since 2.2.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username = $args[1];
 		$password = $args[2];
 		$category = $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.newCategory' );
 		// Make sure the user is allowed to add a category.
 		if ( ! current_user_can( 'manage_categories' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to add a category.' ) );
 		}
-		// If no slug was provided make it empty so that
+		// If no slug was provided, make it empty
-		// WordPress will generate one.
+		// so that WordPress will generate one.
 		if ( empty( $category['slug'] ) ) {
 			$category['slug'] = '';
 		}
-		// If no parent_id was provided make it empty
+		// If no parent_id was provided, make it empty
-		// so that it will be a top level page (no parent).
+		// so that it will be a top-level page (no parent).
 		if ( ! isset( $category['parent_id'] ) ) {
 			$category['parent_id'] = '';
 		}
-		// If no description was provided make it empty.
+		// If no description was provided, make it empty.
 		if ( empty( $category['description'] ) ) {
 			$category['description'] = '';
 		}
 		$new_category = array(
 			'category_description' => $category['description'],
 		);
 		$cat_id = wp_insert_category( $new_category, true );
 		if ( is_wp_error( $cat_id ) ) {
-			if ( 'term_exists' == $cat_id->get_error_code() ) {
+			if ( 'term_exists' === $cat_id->get_error_code() ) {
 				return (int) $cat_id->get_error_data();
 			} else {
-				return new IXR_Error( 500, __( 'Sorry, the new category failed.' ) );
+				return new IXR_Error( 500, __( 'Sorry, the category could not be created.' ) );
 			}
 		} elseif ( ! $cat_id ) {
-			return new IXR_Error( 500, __( 'Sorry, the new category failed.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the category could not be created.' ) );
 		}
 		/**
 		 * Fires after a new category has been successfully created via XML-RPC.
 		 *
 		 * @since 3.4.0
 		 *
 		 * @param int   $cat_id ID of the new category.
 		 * @param array $args   An array of new category arguments.
 		 */
-		do_action( 'xmlrpc_call_success_wp_newCategory', $cat_id, $args );
+		do_action( 'xmlrpc_call_success_wp_newCategory', $cat_id, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return $cat_id;
 	}
 	/**
 	 * Remove category.
 	 *
 	 * @since 2.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username    = $args[1];
 		$password    = $args[2];
 		$category_id = (int) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.deleteCategory' );
 			 * @since 3.4.0
 			 *
 			 * @param int   $category_id ID of the deleted category.
 			 * @param array $args        An array of arguments to delete the category.
 			 */
-			do_action( 'xmlrpc_call_success_wp_deleteCategory', $category_id, $args );
+			do_action( 'xmlrpc_call_success_wp_deleteCategory', $category_id, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		}
 		return $status;
 	}
 	/**
 	 * Retrieve category list.
 	 *
 	 * @since 2.2.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username    = $args[1];
 		$password    = $args[2];
 		$category    = $args[3];
 		$max_results = (int) $args[4];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you must be able to edit posts on this site in order to view categories.' ) );
 	/**
 	 * Retrieve comment.
 	 *
 	 * @since 2.7.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username   = $args[1];
 		$password   = $args[2];
 		$comment_id = (int) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getComment' );
-		if ( ! $comment = get_comment( $comment_id ) ) {
+		$comment = get_comment( $comment_id );
+		if ( ! $comment ) {
 			return new IXR_Error( 404, __( 'Invalid comment ID.' ) );
 		}
 		if ( ! current_user_can( 'edit_comment', $comment_id ) ) {
 			return new IXR_Error( 403, __( 'Sorry, you are not allowed to moderate or edit this comment.' ) );
 	 * - 'number' - Default is 10. Total number of media items to retrieve.
 	 * - 'offset' - Default is 0. See WP_Query::query() for more.
 	 *
 	 * @since 2.7.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username = $args[1];
 		$password = $args[2];
 		$struct   = isset( $args[3] ) ? $args[3] : array();
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getComments' );
 	}
 	/**
 	 * Delete a comment.
 	 *
-	 * By default, the comment will be moved to the trash instead of deleted.
+	 * By default, the comment will be moved to the Trash instead of deleted.
 	 * See wp_delete_comment() for more information on this behavior.
 	 *
 	 * @since 2.7.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username   = $args[1];
 		$password   = $args[2];
 		$comment_ID = (int) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! get_comment( $comment_ID ) ) {
 			return new IXR_Error( 404, __( 'Invalid comment ID.' ) );
 			 * @since 3.4.0
 			 *
 			 * @param int   $comment_ID ID of the deleted comment.
 			 * @param array $args       An array of arguments to delete the comment.
 			 */
-			do_action( 'xmlrpc_call_success_wp_deleteComment', $comment_ID, $args );
+			do_action( 'xmlrpc_call_success_wp_deleteComment', $comment_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		}
 		return $status;
 	}
 	 *  - 'date_created_gmt'
 	 *  - 'status'. Common statuses are 'approve', 'hold', 'spam'. See get_comment_statuses() for more details
 	 *
 	 * @since 2.7.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username       = $args[1];
 		$password       = $args[2];
 		$comment_ID     = (int) $args[3];
 		$content_struct = $args[4];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! get_comment( $comment_ID ) ) {
 			return new IXR_Error( 404, __( 'Invalid comment ID.' ) );
 		if ( isset( $content_struct['status'] ) ) {
 			$statuses = get_comment_statuses();
 			$statuses = array_keys( $statuses );
-			if ( ! in_array( $content_struct['status'], $statuses ) ) {
+			if ( ! in_array( $content_struct['status'], $statuses, true ) ) {
 				return new IXR_Error( 401, __( 'Invalid comment status.' ) );
 			}
 			$comment['comment_approved'] = $content_struct['status'];
 		}
-		// Do some timestamp voodoo
+		// Do some timestamp voodoo.
 		if ( ! empty( $content_struct['date_created_gmt'] ) ) {
-			// We know this is supposed to be GMT, so we're going to slap that Z on there by force
+			// We know this is supposed to be GMT, so we're going to slap that Z on there by force.
 			$dateCreated                 = rtrim( $content_struct['date_created_gmt']->getIso(), 'Z' ) . 'Z';
-			$comment['comment_date']     = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
+			$comment['comment_date']     = get_date_from_gmt( $dateCreated );
-			$comment['comment_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' );
+			$comment['comment_date_gmt'] = iso8601_to_datetime( $dateCreated, 'gmt' );
 		}
 		if ( isset( $content_struct['content'] ) ) {
 			$comment['comment_content'] = $content_struct['content'];
 		}
 		if ( isset( $content_struct['author_email'] ) ) {
 			$comment['comment_author_email'] = $content_struct['author_email'];
 		}
-		$result = wp_update_comment( $comment );
+		$result = wp_update_comment( $comment, true );
 		if ( is_wp_error( $result ) ) {
 			return new IXR_Error( 500, $result->get_error_message() );
 		}
 		if ( ! $result ) {
-			return new IXR_Error( 500, __( 'Sorry, the comment could not be edited.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the comment could not be updated.' ) );
 		}
 		/**
 		 * Fires after a comment has been successfully updated via XML-RPC.
 		 *
 		 * @since 3.4.0
 		 *
 		 * @param int   $comment_ID ID of the updated comment.
 		 * @param array $args       An array of arguments to update the comment.
 		 */
-		do_action( 'xmlrpc_call_success_wp_editComment', $comment_ID, $args );
+		do_action( 'xmlrpc_call_success_wp_editComment', $comment_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return true;
 	}
 	/**
 	 * Create new comment.
 	 *
 	 * @since 2.7.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int        $blog_id (unused)
 	 *     @type string     $username
 	 *     @type string     $password
 		$user = $this->login( $username, $password );
 		if ( ! $user ) {
 			$logged_in = false;
 			if ( $allow_anon && get_option( 'comment_registration' ) ) {
-				return new IXR_Error( 403, __( 'You must be registered to comment.' ) );
+				return new IXR_Error( 403, __( 'Sorry, you must be logged in to comment.' ) );
 			} elseif ( ! $allow_anon ) {
 				return $this->error;
 			}
 		} else {
 			$logged_in = true;
 			}
 			$comment['user_ID'] = 0;
 			if ( get_option( 'require_name_email' ) ) {
-				if ( 6 > strlen( $comment['comment_author_email'] ) || '' == $comment['comment_author'] ) {
+				if ( strlen( $comment['comment_author_email'] < 6 ) || '' === $comment['comment_author'] ) {
 					return new IXR_Error( 403, __( 'Comment author name and email are required.' ) );
 				} elseif ( ! is_email( $comment['comment_author_email'] ) ) {
 					return new IXR_Error( 403, __( 'A valid email address is required.' ) );
 				}
 			}
 		 * @since 3.4.0
 		 *
 		 * @param int   $comment_ID ID of the new comment.
 		 * @param array $args       An array of new comment arguments.
 		 */
-		do_action( 'xmlrpc_call_success_wp_newComment', $comment_ID, $args );
+		do_action( 'xmlrpc_call_success_wp_newComment', $comment_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return $comment_ID;
 	}
 	/**
 	 * Retrieve all of the comment status.
 	 *
 	 * @since 2.7.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'publish_posts' ) ) {
 			return new IXR_Error( 403, __( 'Sorry, you are not allowed to access details about this site.' ) );
 	/**
 	 * Retrieve comment count.
 	 *
 	 * @since 2.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username = $args[1];
 		$password = $args[2];
 		$post_id  = (int) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		$post = get_post( $post_id, ARRAY_A );
 		if ( empty( $post['ID'] ) ) {
 	/**
 	 * Retrieve post statuses.
 	 *
 	 * @since 2.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 403, __( 'Sorry, you are not allowed to access details about this site.' ) );
 	/**
 	 * Retrieve page statuses.
 	 *
 	 * @since 2.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_pages' ) ) {
 			return new IXR_Error( 403, __( 'Sorry, you are not allowed to access details about this site.' ) );
 	/**
 	 * Retrieve page templates.
 	 *
 	 * @since 2.6.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_pages' ) ) {
 			return new IXR_Error( 403, __( 'Sorry, you are not allowed to access details about this site.' ) );
 	/**
 	 * Retrieve blog options.
 	 *
 	 * @since 2.6.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username = $args[1];
 		$password = $args[2];
 		$options  = isset( $args[3] ) ? (array) $args[3] : array();
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
-			return $this->error;
+		if ( ! $user ) {
-		}
+			return $this->error;
+		}
-		// If no specific options where asked for, return all of them
+		// If no specific options where asked for, return all of them.
 		if ( count( $options ) == 0 ) {
 			$options = array_keys( $this->blog_options );
 		}
 		return $this->_getOptions( $options );
 		$data       = array();
 		$can_manage = current_user_can( 'manage_options' );
 		foreach ( $options as $option ) {
 			if ( array_key_exists( $option, $this->blog_options ) ) {
 				$data[ $option ] = $this->blog_options[ $option ];
-				//Is the value static or dynamic?
+				// Is the value static or dynamic?
 				if ( isset( $data[ $option ]['option'] ) ) {
 					$data[ $option ]['value'] = get_option( $data[ $option ]['option'] );
 					unset( $data[ $option ]['option'] );
 				}
 	/**
 	 * Update blog options.
 	 *
 	 * @since 2.6.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username = $args[1];
 		$password = $args[2];
 		$options  = (array) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'manage_options' ) ) {
 			return new IXR_Error( 403, __( 'Sorry, you are not allowed to update options.' ) );
 			$option_names[] = $o_name;
 			if ( ! array_key_exists( $o_name, $this->blog_options ) ) {
 				continue;
 			}
-			if ( $this->blog_options[ $o_name ]['readonly'] == true ) {
+			if ( true == $this->blog_options[ $o_name ]['readonly'] ) {
 				continue;
 			}
 			update_option( $this->blog_options[ $o_name ]['option'], wp_unslash( $o_value ) );
 		}
-		//Now return the updated values
+		// Now return the updated values.
 		return $this->_getOptions( $option_names );
 	}
 	/**
 	 * Retrieve a media item by ID
 	 *
 	 * @since 3.1.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username      = $args[1];
 		$password      = $args[2];
 		$attachment_id = (int) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'upload_files' ) ) {
 			return new IXR_Error( 403, __( 'Sorry, you are not allowed to upload files.' ) );
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getMediaItem' );
-		if ( ! $attachment = get_post( $attachment_id ) ) {
+		$attachment = get_post( $attachment_id );
+		if ( ! $attachment ) {
 			return new IXR_Error( 404, __( 'Invalid attachment ID.' ) );
 		}
 		return $this->_prepare_media_item( $attachment );
 	}
 	 * - 'parent_id' - Default is ''. The post where the media item is attached. Empty string shows all media items. 0 shows unattached media items.
 	 * - 'mime_type' - Default is ''. Filter by mime type (e.g., 'image/jpeg', 'application/pdf')
 	 *
 	 * @since 3.1.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username = $args[1];
 		$password = $args[2];
 		$struct   = isset( $args[3] ) ? $args[3] : array();
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'upload_files' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to upload files.' ) );
 	/**
 	 * Retrieves a list of post formats used by the site.
 	 *
 	 * @since 3.1.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 403, __( 'Sorry, you are not allowed to access details about this site.' ) );
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getPostFormats' );
 		$formats = get_post_format_strings();
-		// find out if they want a list of currently supports formats
+		// Find out if they want a list of currently supports formats.
 		if ( isset( $args[3] ) && is_array( $args[3] ) ) {
 			if ( $args[3]['show-supported'] ) {
 				if ( current_theme_supports( 'post-formats' ) ) {
 					$supported = get_theme_support( 'post-formats' );
 	 *
 	 * @since 3.4.0
 	 *
 	 * @see get_post_type_object()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 			 * @param string $method The method name.
 			 */
 			$fields = apply_filters( 'xmlrpc_default_posttype_fields', array( 'labels', 'cap', 'taxonomies' ), 'wp.getPostType' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getPostType' );
 	 *
 	 * @since 3.4.0
 	 *
 	 * @see get_post_types()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		} else {
 			/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 			$fields = apply_filters( 'xmlrpc_default_posttype_fields', array( 'labels', 'cap', 'taxonomies' ), 'wp.getPostTypes' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getPostTypes' );
 	 * in the response array.
 	 *
 	 * @uses wp_get_post_revisions()
 	 * @see wp_getPost() for more on $fields
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 			 * @param string $method The method name.
 			 */
 			$fields = apply_filters( 'xmlrpc_default_revision_fields', array( 'post_date', 'post_date_gmt' ), 'wp.getRevisions' );
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.getRevisions' );
-		if ( ! $post = get_post( $post_id ) ) {
+		$post = get_post( $post_id );
+		if ( ! $post ) {
 			return new IXR_Error( 404, __( 'Invalid post ID.' ) );
 		}
 		if ( ! current_user_can( 'edit_post', $post_id ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit posts.' ) );
 		foreach ( $revisions as $revision ) {
 			if ( ! current_user_can( 'read_post', $revision->ID ) ) {
 				continue;
 			}
-			// Skip autosaves
+			// Skip autosaves.
 			if ( wp_is_post_autosave( $revision ) ) {
 				continue;
 			}
 			$struct[] = $this->_prepare_post( get_object_vars( $revision ), $fields );
 	 *
 	 * @since 3.5.0
 	 *
 	 * @uses wp_restore_post_revision()
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username    = $args[1];
 		$password    = $args[2];
 		$revision_id = (int) $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'wp.restoreRevision' );
-		if ( ! $revision = wp_get_post_revision( $revision_id ) ) {
+		$revision = wp_get_post_revision( $revision_id );
+		if ( ! $revision ) {
 			return new IXR_Error( 404, __( 'Invalid post ID.' ) );
 		}
 		if ( wp_is_post_autosave( $revision ) ) {
 			return new IXR_Error( 404, __( 'Invalid post ID.' ) );
 		}
-		if ( ! $post = get_post( $revision->post_parent ) ) {
+		$post = get_post( $revision->post_parent );
+		if ( ! $post ) {
 			return new IXR_Error( 404, __( 'Invalid post ID.' ) );
 		}
 		if ( ! current_user_can( 'edit_post', $revision->post_parent ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit this post.' ) );
 		$post = wp_restore_post_revision( $revision_id );
 		return (bool) $post;
 	}
-	/* Blogger API functions.
+	/*
-	 * specs on http://plant.blogger.com/api and https://groups.yahoo.com/group/bloggerDev/
+	 * Blogger API functions.
+	 * Specs on http://plant.blogger.com/api and https://groups.yahoo.com/group/bloggerDev/
 	 */
 	/**
 	 * Retrieve blogs that user owns.
 	 *
 	 * Will make more sense once we support multiple blogs.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'blogger.getUsersBlogs' );
 	 *
 	 * Gives your client some info about you, so you don't have to.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to access user data on this site.' ) );
 	/**
 	 * Retrieve post.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type int    $post_ID
 	 *     @type string $username
 		$post_ID  = (int) $args[1];
 		$username = $args[2];
 		$password = $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		$post_data = get_post( $post_ID, ARRAY_A );
 		if ( ! $post_data ) {
 	/**
 	 * Retrieve list of recent posts.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type string $appkey (unused)
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 */
 	public function blogger_getRecentPosts( $args ) {
 		$this->escape( $args );
-		// $args[0] = appkey - ignored
+		// $args[0] = appkey - ignored.
 		$username = $args[2];
 		$password = $args[3];
 		if ( isset( $args[4] ) ) {
 			$query = array( 'numberposts' => absint( $args[4] ) );
 		} else {
 			$query = array();
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit posts.' ) );
 	 *
 	 * @param array $args Unused.
 	 * @return IXR_Error Error object.
 	 */
 	public function blogger_getTemplate( $args ) {
-		return new IXR_Error( 403, __( 'Sorry, that file cannot be edited.' ) );
+		return new IXR_Error( 403, __( 'Sorry, this method is not supported.' ) );
 	}
 	/**
 	 * Deprecated.
 	 *
 	 *
 	 * @param array $args Unused.
 	 * @return IXR_Error Error object.
 	 */
 	public function blogger_setTemplate( $args ) {
-		return new IXR_Error( 403, __( 'Sorry, that file cannot be edited.' ) );
+		return new IXR_Error( 403, __( 'Sorry, this method is not supported.' ) );
 	}
 	/**
 	 * Creates new post.
 	 *
 		$username = $args[2];
 		$password = $args[3];
 		$content  = $args[4];
 		$publish  = $args[5];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'blogger.newPost' );
 		if ( is_wp_error( $post_ID ) ) {
 			return new IXR_Error( 500, $post_ID->get_error_message() );
 		}
 		if ( ! $post_ID ) {
-			return new IXR_Error( 500, __( 'Sorry, your entry could not be posted.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the post could not be created.' ) );
 		}
 		$this->attach_uploads( $post_ID, $post_content );
 		/**
 		 * @since 3.4.0
 		 *
 		 * @param int   $post_ID ID of the new post.
 		 * @param array $args    An array of new post arguments.
 		 */
-		do_action( 'xmlrpc_call_success_blogger_newPost', $post_ID, $args );
+		do_action( 'xmlrpc_call_success_blogger_newPost', $post_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return $post_ID;
 	}
 	/**
 	 * Edit a post.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type int    $post_ID
 	 *     @type string $username
 		$username = $args[2];
 		$password = $args[3];
 		$content  = $args[4];
 		$publish  = $args[5];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'blogger.editPost' );
 		$actual_post = get_post( $post_ID, ARRAY_A );
-		if ( ! $actual_post || $actual_post['post_type'] != 'post' ) {
+		if ( ! $actual_post || 'post' !== $actual_post['post_type'] ) {
 			return new IXR_Error( 404, __( 'Sorry, no such post.' ) );
 		}
 		$this->escape( $actual_post );
 		if ( ! current_user_can( 'edit_post', $post_ID ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit this post.' ) );
 		}
-		if ( 'publish' == $actual_post['post_status'] && ! current_user_can( 'publish_posts' ) ) {
+		if ( 'publish' === $actual_post['post_status'] && ! current_user_can( 'publish_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to publish this post.' ) );
 		}
 		$postdata                  = array();
 		$postdata['ID']            = $actual_post['ID'];
 		$postdata['post_status']   = $publish ? 'publish' : 'draft';
 		$result = wp_update_post( $postdata );
 		if ( ! $result ) {
-			return new IXR_Error( 500, __( 'For some strange yet very annoying reason, this post could not be edited.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the post could not be updated.' ) );
 		}
 		$this->attach_uploads( $actual_post['ID'], $postdata['post_content'] );
 		/**
 		 * Fires after a post has been successfully updated via the XML-RPC Blogger API.
 		 * @since 3.4.0
 		 *
 		 * @param int   $post_ID ID of the updated post.
 		 * @param array $args    An array of arguments for the post to edit.
 		 */
-		do_action( 'xmlrpc_call_success_blogger_editPost', $post_ID, $args );
+		do_action( 'xmlrpc_call_success_blogger_editPost', $post_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return true;
 	}
 	/**
 	 * Remove a post.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type int    $post_ID
 	 *     @type string $username
 		$post_ID  = (int) $args[1];
 		$username = $args[2];
 		$password = $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'blogger.deletePost' );
 		$actual_post = get_post( $post_ID, ARRAY_A );
-		if ( ! $actual_post || $actual_post['post_type'] != 'post' ) {
+		if ( ! $actual_post || 'post' !== $actual_post['post_type'] ) {
 			return new IXR_Error( 404, __( 'Sorry, no such post.' ) );
 		}
 		if ( ! current_user_can( 'delete_post', $post_ID ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to delete this post.' ) );
 		}
 		$result = wp_delete_post( $post_ID );
 		if ( ! $result ) {
-			return new IXR_Error( 500, __( 'The post cannot be deleted.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the post could not be deleted.' ) );
 		}
 		/**
 		 * Fires after a post has been successfully deleted via the XML-RPC Blogger API.
 		 *
 		 * @since 3.4.0
 		 *
 		 * @param int   $post_ID ID of the deleted post.
 		 * @param array $args    An array of arguments to delete the post.
 		 */
-		do_action( 'xmlrpc_call_success_blogger_deletePost', $post_ID, $args );
+		do_action( 'xmlrpc_call_success_blogger_deletePost', $post_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return true;
 	}
-	/* MetaWeblog API functions
+	/*
-	 * specs on wherever Dave Winer wants them to be
+	 * MetaWeblog API functions.
+	 * Specs on wherever Dave Winer wants them to be.
 	 */
 	/**
 	 * Create a new post.
 	 *
 	 *  - dateCreated
 	 *  - wp_post_thumbnail
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username       = $args[1];
 		$password       = $args[2];
 		$content_struct = $args[3];
 		$publish        = isset( $args[4] ) ? $args[4] : 0;
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'metaWeblog.newPost' );
 		$page_template = '';
 		if ( ! empty( $content_struct['post_type'] ) ) {
-			if ( $content_struct['post_type'] == 'page' ) {
+			if ( 'page' === $content_struct['post_type'] ) {
 				if ( $publish ) {
 					$cap = 'publish_pages';
-				} elseif ( isset( $content_struct['page_status'] ) && 'publish' == $content_struct['page_status'] ) {
+				} elseif ( isset( $content_struct['page_status'] ) && 'publish' === $content_struct['page_status'] ) {
 					$cap = 'publish_pages';
 				} else {
 					$cap = 'edit_pages';
 				}
 				$error_message = __( 'Sorry, you are not allowed to publish pages on this site.' );
 				$post_type     = 'page';
 				if ( ! empty( $content_struct['wp_page_template'] ) ) {
 					$page_template = $content_struct['wp_page_template'];
 				}
-			} elseif ( $content_struct['post_type'] == 'post' ) {
+			} elseif ( 'post' === $content_struct['post_type'] ) {
 				if ( $publish ) {
 					$cap = 'publish_posts';
-				} elseif ( isset( $content_struct['post_status'] ) && 'publish' == $content_struct['post_status'] ) {
+				} elseif ( isset( $content_struct['post_status'] ) && 'publish' === $content_struct['post_status'] ) {
 					$cap = 'publish_posts';
 				} else {
 					$cap = 'edit_posts';
 				}
 				$error_message = __( 'Sorry, you are not allowed to publish posts on this site.' );
 				$post_type     = 'post';
 			} else {
-				// No other post_type values are allowed here
+				// No other 'post_type' values are allowed here.
 				return new IXR_Error( 401, __( 'Invalid post type.' ) );
 			}
 		} else {
 			if ( $publish ) {
 				$cap = 'publish_posts';
-			} elseif ( isset( $content_struct['post_status'] ) && 'publish' == $content_struct['post_status'] ) {
+			} elseif ( isset( $content_struct['post_status'] ) && 'publish' === $content_struct['post_status'] ) {
 				$cap = 'publish_posts';
 			} else {
 				$cap = 'edit_posts';
 			}
 			$error_message = __( 'Sorry, you are not allowed to publish posts on this site.' );
 		}
 		if ( ! current_user_can( $cap ) ) {
 			return new IXR_Error( 401, $error_message );
 		}
-		// Check for a valid post format if one was given
+		// Check for a valid post format if one was given.
 		if ( isset( $content_struct['wp_post_format'] ) ) {
 			$content_struct['wp_post_format'] = sanitize_key( $content_struct['wp_post_format'] );
 			if ( ! array_key_exists( $content_struct['wp_post_format'], get_post_format_strings() ) ) {
 				return new IXR_Error( 404, __( 'Invalid post format.' ) );
 			}
 		}
-		// Let WordPress generate the post_name (slug) unless
+		// Let WordPress generate the 'post_name' (slug) unless
 		// one has been provided.
 		$post_name = '';
 		if ( isset( $content_struct['wp_slug'] ) ) {
 			$post_name = $content_struct['wp_slug'];
 		}
 			$post_password = $content_struct['wp_password'];
 		} else {
 			$post_password = '';
 		}
-		// Only set a post parent if one was provided.
+		// Only set a post parent if one was given.
 		if ( isset( $content_struct['wp_page_parent_id'] ) ) {
 			$post_parent = $content_struct['wp_page_parent_id'];
 		} else {
 			$post_parent = 0;
 		}
-		// Only set the menu_order if it was provided.
+		// Only set the 'menu_order' if it was given.
 		if ( isset( $content_struct['wp_page_order'] ) ) {
 			$menu_order = $content_struct['wp_page_order'];
 		} else {
 			$menu_order = 0;
 		}
 			if ( is_array( $to_ping ) ) {
 				$to_ping = implode( ' ', $to_ping );
 			}
 		}
-		// Do some timestamp voodoo
+		// Do some timestamp voodoo.
 		if ( ! empty( $content_struct['date_created_gmt'] ) ) {
-			// We know this is supposed to be GMT, so we're going to slap that Z on there by force
+			// We know this is supposed to be GMT, so we're going to slap that Z on there by force.
 			$dateCreated = rtrim( $content_struct['date_created_gmt']->getIso(), 'Z' ) . 'Z';
 		} elseif ( ! empty( $content_struct['dateCreated'] ) ) {
 			$dateCreated = $content_struct['dateCreated']->getIso();
 		}
 		if ( ! empty( $dateCreated ) ) {
-			$post_date     = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
+			$post_date     = iso8601_to_datetime( $dateCreated );
-			$post_date_gmt = iso8601_to_datetime( $dateCreated, 'GMT' );
+			$post_date_gmt = iso8601_to_datetime( $dateCreated, 'gmt' );
 		} else {
 			$post_date     = '';
 			$post_date_gmt = '';
 		}
 			}
 		}
 		$postdata = compact( 'post_author', 'post_date', 'post_date_gmt', 'post_content', 'post_title', 'post_category', 'post_status', 'post_excerpt', 'comment_status', 'ping_status', 'to_ping', 'post_type', 'post_name', 'post_password', 'post_parent', 'menu_order', 'tags_input', 'page_template' );
-		$post_ID = $postdata['ID'] = get_default_post_to_edit( $post_type, true )->ID;
+		$post_ID        = get_default_post_to_edit( $post_type, true )->ID;
+		$postdata['ID'] = $post_ID;
-		// Only posts can be sticky
-		if ( $post_type == 'post' && isset( $content_struct['sticky'] ) ) {
+		// Only posts can be sticky.
+		if ( 'post' === $post_type && isset( $content_struct['sticky'] ) ) {
 			$data           = $postdata;
 			$data['sticky'] = $content_struct['sticky'];
 			$error          = $this->_toggle_sticky( $data );
 			if ( $error ) {
 				return $error;
 			}
 			unset( $content_struct['wp_post_thumbnail'] );
 		}
-		// Handle enclosures
+		// Handle enclosures.
 		$thisEnclosure = isset( $content_struct['enclosure'] ) ? $content_struct['enclosure'] : null;
 		$this->add_enclosure_if_new( $post_ID, $thisEnclosure );
 		$this->attach_uploads( $post_ID, $post_content );
 		// Handle post formats if assigned, value is validated earlier
-		// in this function
+		// in this function.
 		if ( isset( $content_struct['wp_post_format'] ) ) {
 			set_post_format( $post_ID, $content_struct['wp_post_format'] );
 		}
 		$post_ID = wp_insert_post( $postdata, true );
 		if ( is_wp_error( $post_ID ) ) {
 			return new IXR_Error( 500, $post_ID->get_error_message() );
 		}
 		if ( ! $post_ID ) {
-			return new IXR_Error( 500, __( 'Sorry, your entry could not be posted.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the post could not be created.' ) );
 		}
 		/**
 		 * Fires after a new post has been successfully created via the XML-RPC MovableType API.
 		 *
 		 * @since 3.4.0
 		 *
 		 * @param int   $post_ID ID of the new post.
 		 * @param array $args    An array of arguments to create the new post.
 		 */
-		do_action( 'xmlrpc_call_success_mw_newPost', $post_ID, $args );
+		do_action( 'xmlrpc_call_success_mw_newPost', $post_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return strval( $post_ID );
 	}
 	/**
 	 * @param integer $post_ID   Post ID.
 	 * @param array   $enclosure Enclosure data.
 	 */
 	public function add_enclosure_if_new( $post_ID, $enclosure ) {
 		if ( is_array( $enclosure ) && isset( $enclosure['url'] ) && isset( $enclosure['length'] ) && isset( $enclosure['type'] ) ) {
-			$encstring = $enclosure['url'] . "\n" . $enclosure['length'] . "\n" . $enclosure['type'] . "\n";
+			$encstring  = $enclosure['url'] . "\n" . $enclosure['length'] . "\n" . $enclosure['type'] . "\n";
-			$found     = false;
+			$found      = false;
-			if ( $enclosures = get_post_meta( $post_ID, 'enclosure' ) ) {
+			$enclosures = get_post_meta( $post_ID, 'enclosure' );
+			if ( $enclosures ) {
 				foreach ( $enclosures as $enc ) {
 					// This method used to omit the trailing new line. #23219
 					if ( rtrim( $enc, "\n" ) == rtrim( $encstring, "\n" ) ) {
 						$found = true;
 						break;
 	 *
 	 * @since 2.1.0
 	 *
 	 * @global wpdb $wpdb WordPress database abstraction object.
 	 *
-	 * @param int $post_ID Post ID.
+	 * @param int    $post_ID      Post ID.
 	 * @param string $post_content Post Content for attachment.
 	 */
 	public function attach_uploads( $post_ID, $post_content ) {
 		global $wpdb;
-		// find any unattached files
+		// Find any unattached files.
 		$attachments = $wpdb->get_results( "SELECT ID, guid FROM {$wpdb->posts} WHERE post_parent = '0' AND post_type = 'attachment'" );
 		if ( is_array( $attachments ) ) {
 			foreach ( $attachments as $file ) {
 				if ( ! empty( $file->guid ) && strpos( $post_content, $file->guid ) !== false ) {
 					$wpdb->update( $wpdb->posts, array( 'post_parent' => $post_ID ), array( 'ID' => $file->ID ) );
 	/**
 	 * Edit a post.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$username       = $args[1];
 		$password       = $args[2];
 		$content_struct = $args[3];
 		$publish        = isset( $args[4] ) ? $args[4] : 0;
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'metaWeblog.editPost' );
 		$postdata = get_post( $post_ID, ARRAY_A );
 		/*
-		 * If there is no post data for the give post id, stop now and return an error.
+		 * If there is no post data for the give post ID, stop now and return an error.
 		 * Otherwise a new post will be created (which was the old behavior).
 		 */
 		if ( ! $postdata || empty( $postdata['ID'] ) ) {
 			return new IXR_Error( 404, __( 'Invalid post ID.' ) );
 		}
 		if ( ! current_user_can( 'edit_post', $post_ID ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit this post.' ) );
 		}
 		// Use wp.editPost to edit post types other than post and page.
-		if ( ! in_array( $postdata['post_type'], array( 'post', 'page' ) ) ) {
+		if ( ! in_array( $postdata['post_type'], array( 'post', 'page' ), true ) ) {
 			return new IXR_Error( 401, __( 'Invalid post type.' ) );
 		}
 		// Thwart attempt to change the post type.
 		if ( ! empty( $content_struct['post_type'] ) && ( $content_struct['post_type'] != $postdata['post_type'] ) ) {
 			return new IXR_Error( 401, __( 'The post type may not be changed.' ) );
 		}
-		// Check for a valid post format if one was given
+		// Check for a valid post format if one was given.
 		if ( isset( $content_struct['wp_post_format'] ) ) {
 			$content_struct['wp_post_format'] = sanitize_key( $content_struct['wp_post_format'] );
 			if ( ! array_key_exists( $content_struct['wp_post_format'], get_post_format_strings() ) ) {
 				return new IXR_Error( 404, __( 'Invalid post format.' ) );
 			}
 		// Only set a post parent if one was given.
 		if ( isset( $content_struct['wp_page_parent_id'] ) ) {
 			$post_parent = $content_struct['wp_page_parent_id'];
 		}
-		// Only set the menu_order if it was given.
+		// Only set the 'menu_order' if it was given.
 		if ( isset( $content_struct['wp_page_order'] ) ) {
 			$menu_order = $content_struct['wp_page_order'];
 		}
 		$page_template = null;
-		if ( ! empty( $content_struct['wp_page_template'] ) && 'page' == $post_type ) {
+		if ( ! empty( $content_struct['wp_page_template'] ) && 'page' === $post_type ) {
 			$page_template = $content_struct['wp_page_template'];
 		}
 		$post_author = $postdata['post_author'];
-		// Only set the post_author if one is set.
+		// If an author id was provided then use it instead.
 		if ( isset( $content_struct['wp_author_id'] ) ) {
 			// Check permissions if attempting to switch author to or from another user.
 			if ( $user->ID != $content_struct['wp_author_id'] || $user->ID != $post_author ) {
 				switch ( $post_type ) {
 					case 'post':
 			}
 		}
 		$tags_input = isset( $content_struct['mt_keywords'] ) ? $content_struct['mt_keywords'] : null;
-		if ( 'publish' == $post_status || 'private' == $post_status ) {
+		if ( 'publish' === $post_status || 'private' === $post_status ) {
-			if ( 'page' == $post_type && ! current_user_can( 'publish_pages' ) ) {
+			if ( 'page' === $post_type && ! current_user_can( 'publish_pages' ) ) {
 				return new IXR_Error( 401, __( 'Sorry, you are not allowed to publish this page.' ) );
 			} elseif ( ! current_user_can( 'publish_posts' ) ) {
 				return new IXR_Error( 401, __( 'Sorry, you are not allowed to publish this post.' ) );
 			}
 		}
 		// Default to not flagging the post date to be edited unless it's intentional.
 		$edit_date = false;
 		if ( ! empty( $dateCreated ) ) {
-			$post_date     = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
+			$post_date     = iso8601_to_datetime( $dateCreated );
-			$post_date_gmt = iso8601_to_datetime( $dateCreated, 'GMT' );
+			$post_date_gmt = iso8601_to_datetime( $dateCreated, 'gmt' );
 			// Flag the post date to be edited.
 			$edit_date = true;
 		} else {
 			$post_date     = $postdata['post_date'];
 		if ( is_wp_error( $result ) ) {
 			return new IXR_Error( 500, $result->get_error_message() );
 		}
 		if ( ! $result ) {
-			return new IXR_Error( 500, __( 'Sorry, your entry could not be edited.' ) );
+			return new IXR_Error( 500, __( 'Sorry, the post could not be updated.' ) );
 		}
-		// Only posts can be sticky
+		// Only posts can be sticky.
-		if ( $post_type == 'post' && isset( $content_struct['sticky'] ) ) {
+		if ( 'post' === $post_type && isset( $content_struct['sticky'] ) ) {
 			$data              = $newpost;
 			$data['sticky']    = $content_struct['sticky'];
 			$data['post_type'] = 'post';
 			$error             = $this->_toggle_sticky( $data, true );
 			if ( $error ) {
 		 * @since 3.4.0
 		 *
 		 * @param int   $post_ID ID of the updated post.
 		 * @param array $args    An array of arguments to update the post.
 		 */
-		do_action( 'xmlrpc_call_success_mw_editPost', $post_ID, $args );
+		do_action( 'xmlrpc_call_success_mw_editPost', $post_ID, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		return true;
 	}
 	/**
 	 * Retrieve post.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type int    $post_ID
 	 *     @type string $username
 		$post_ID  = (int) $args[0];
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		$postdata = get_post( $post_ID, ARRAY_A );
 		if ( ! $postdata ) {
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'metaWeblog.getPost' );
-		if ( $postdata['post_date'] != '' ) {
+		if ( '' !== $postdata['post_date'] ) {
 			$post_date         = $this->_convert_date( $postdata['post_date'] );
 			$post_date_gmt     = $this->_convert_date_gmt( $postdata['post_date_gmt'], $postdata['post_date'] );
 			$post_modified     = $this->_convert_date( $postdata['post_modified'] );
 			$post_modified_gmt = $this->_convert_date_gmt( $postdata['post_modified_gmt'], $postdata['post_modified'] );
 			$link = get_permalink( $postdata['ID'] );
 			// Get the author info.
 			$author = get_userdata( $postdata['post_author'] );
-			$allow_comments = ( 'open' == $postdata['comment_status'] ) ? 1 : 0;
+			$allow_comments = ( 'open' === $postdata['comment_status'] ) ? 1 : 0;
-			$allow_pings    = ( 'open' == $postdata['ping_status'] ) ? 1 : 0;
+			$allow_pings    = ( 'open' === $postdata['ping_status'] ) ? 1 : 0;
-			// Consider future posts as published
+			// Consider future posts as published.
-			if ( $postdata['post_status'] === 'future' ) {
+			if ( 'future' === $postdata['post_status'] ) {
 				$postdata['post_status'] = 'publish';
 			}
-			// Get post format
+			// Get post format.
 			$post_format = get_post_format( $post_ID );
 			if ( empty( $post_format ) ) {
 				$post_format = 'standard';
 			}
 				$sticky = true;
 			}
 			$enclosure = array();
 			foreach ( (array) get_post_custom( $post_ID ) as $key => $val ) {
-				if ( $key == 'enclosure' ) {
+				if ( 'enclosure' === $key ) {
 					foreach ( (array) $val as $enc ) {
 						$encdata             = explode( "\n", $enc );
 						$enclosure['url']    = trim( htmlspecialchars( $encdata[0] ) );
 						$enclosure['length'] = (int) trim( $encdata[1] );
 						$enclosure['type']   = trim( $encdata[2] );
 				'postid'                 => $postdata['ID'],
 				'description'            => $post['main'],
 				'title'                  => $postdata['post_title'],
 				'link'                   => $link,
 				'permaLink'              => $link,
-				// commented out because no other tool seems to use this
+				// Commented out because no other tool seems to use this.
-				//	      'content' => $entry['post_content'],
+				// 'content' => $entry['post_content'],
 				'categories'             => $categories,
 				'mt_excerpt'             => $postdata['post_excerpt'],
 				'mt_text_more'           => $post['extended'],
 				'wp_more_text'           => $post['more_text'],
 				'mt_allow_comments'      => $allow_comments,
 	/**
 	 * Retrieve list of recent posts.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 			$query = array( 'numberposts' => absint( $args[3] ) );
 		} else {
 			$query = array();
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit posts.' ) );
 			$link = get_permalink( $entry['ID'] );
 			// Get the post author info.
 			$author = get_userdata( $entry['post_author'] );
-			$allow_comments = ( 'open' == $entry['comment_status'] ) ? 1 : 0;
+			$allow_comments = ( 'open' === $entry['comment_status'] ) ? 1 : 0;
-			$allow_pings    = ( 'open' == $entry['ping_status'] ) ? 1 : 0;
+			$allow_pings    = ( 'open' === $entry['ping_status'] ) ? 1 : 0;
-			// Consider future posts as published
+			// Consider future posts as published.
-			if ( $entry['post_status'] === 'future' ) {
+			if ( 'future' === $entry['post_status'] ) {
 				$entry['post_status'] = 'publish';
 			}
-			// Get post format
+			// Get post format.
 			$post_format = get_post_format( $entry['ID'] );
 			if ( empty( $post_format ) ) {
 				$post_format = 'standard';
 			}
 				'postid'                 => (string) $entry['ID'],
 				'description'            => $post['main'],
 				'title'                  => $entry['post_title'],
 				'link'                   => $link,
 				'permaLink'              => $link,
-				// commented out because no other tool seems to use this
+				// Commented out because no other tool seems to use this.
 				// 'content' => $entry['post_content'],
 				'categories'             => $categories,
 				'mt_excerpt'             => $entry['post_excerpt'],
 				'mt_text_more'           => $post['extended'],
 				'wp_more_text'           => $post['more_text'],
 				'post_status'            => $entry['post_status'],
 				'custom_fields'          => $this->get_custom_fields( $entry['ID'] ),
 				'wp_post_format'         => $post_format,
 				'date_modified'          => $post_modified,
 				'date_modified_gmt'      => $post_modified_gmt,
-				'sticky'                 => ( $entry['post_type'] === 'post' && is_sticky( $entry['ID'] ) ),
+				'sticky'                 => ( 'post' === $entry['post_type'] && is_sticky( $entry['ID'] ) ),
 				'wp_post_thumbnail'      => get_post_thumbnail_id( $entry['ID'] ),
 			);
 		}
 		return $recent_posts;
 	/**
 	 * Retrieve the list of categories on a given blog.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you must be able to edit posts on this site in order to view categories.' ) );
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'metaWeblog.getCategories' );
 		$categories_struct = array();
-		if ( $cats = get_categories( array( 'get' => 'all' ) ) ) {
+		$cats = get_categories( array( 'get' => 'all' ) );
+		if ( $cats ) {
 			foreach ( $cats as $cat ) {
 				$struct                        = array();
 				$struct['categoryId']          = $cat->term_id;
 				$struct['parentId']            = $cat->parent;
 				$struct['description']         = $cat->name;
 	 *
 	 * @since 1.5.0
 	 *
 	 * @global wpdb $wpdb WordPress database abstraction object.
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$name = sanitize_file_name( $data['name'] );
 		$type = $data['type'];
 		$bits = $data['bits'];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'metaWeblog.newMediaObject' );
 		if ( is_multisite() && upload_is_user_over_quota( false ) ) {
 			$this->error = new IXR_Error(
 				401,
 				sprintf(
-					/* translators: %s: allowed space allocation */
+					/* translators: %s: Allowed space allocation. */
 					__( 'Sorry, you have used your space allocation of %s. Please delete some files to upload more files.' ),
 					size_format( get_space_allowed() * MB_IN_BYTES )
 				)
 			);
 			return $this->error;
 		 *
 		 * @since 2.1.0
 		 *
 		 * @param bool $error Whether to pre-empt the media upload. Default false.
 		 */
-		if ( $upload_err = apply_filters( 'pre_upload_error', false ) ) {
+		$upload_err = apply_filters( 'pre_upload_error', false );
+		if ( $upload_err ) {
 			return new IXR_Error( 500, $upload_err );
 		}
 		$upload = wp_upload_bits( $name, null, $bits );
 		if ( ! empty( $upload['error'] ) ) {
-			/* translators: 1: file name, 2: error message */
+			/* translators: 1: File name, 2: Error message. */
 			$errorString = sprintf( __( 'Could not write file %1$s (%2$s).' ), $name, $upload['error'] );
 			return new IXR_Error( 500, $errorString );
 		}
-		// Construct the attachment array
+		// Construct the attachment array.
 		$post_id = 0;
 		if ( ! empty( $data['post_id'] ) ) {
 			$post_id = (int) $data['post_id'];
 			if ( ! current_user_can( 'edit_post', $post_id ) ) {
 			'post_parent'    => $post_id,
 			'post_mime_type' => $type,
 			'guid'           => $upload['url'],
 		);
-		// Save the data
+		// Save the data.
 		$id = wp_insert_attachment( $attachment, $upload['file'], $post_id );
 		wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $upload['file'] ) );
 		/**
 		 * Fires after a new attachment has been added via the XML-RPC MovableType API.
 		 * @since 3.4.0
 		 *
 		 * @param int   $id   ID of the new attachment.
 		 * @param array $args An array of arguments to add the attachment.
 		 */
-		do_action( 'xmlrpc_call_success_mw_newMediaObject', $id, $args );
+		do_action( 'xmlrpc_call_success_mw_newMediaObject', $id, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
 		$struct = $this->_prepare_media_item( get_post( $id ) );
-		// Deprecated values
+		// Deprecated values.
 		$struct['id']   = $struct['attachment_id'];
 		$struct['file'] = $struct['title'];
 		$struct['url']  = $struct['link'];
 		return $struct;
 	}
-	/* MovableType API functions
+	/*
-	 * specs on http://www.movabletype.org/docs/mtmanual_programmatic.html
+	 * MovableType API functions.
+	 * Specs on http://www.movabletype.org/docs/mtmanual_programmatic.html
 	 */
 	/**
 	 * Retrieve the post titles of recent posts.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 			$query = array( 'numberposts' => absint( $args[3] ) );
 		} else {
 			$query = array();
 		}
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'mt.getRecentPostTitles' );
 	/**
 	 * Retrieve list of all categories on blog.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $blog_id (unused)
 	 *     @type string $username
 	 *     @type string $password
 		$this->escape( $args );
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! current_user_can( 'edit_posts' ) ) {
 			return new IXR_Error( 401, __( 'Sorry, you must be able to edit posts on this site in order to view categories.' ) );
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'mt.getCategoryList' );
 		$categories_struct = array();
-		if ( $cats = get_categories(
+		$cats = get_categories(
 			array(
 				'hide_empty'   => 0,
 				'hierarchical' => 0,
 			)
-		) ) {
+		);
+		if ( $cats ) {
 			foreach ( $cats as $cat ) {
 				$struct                 = array();
 				$struct['categoryId']   = $cat->term_id;
 				$struct['categoryName'] = $cat->name;
 	/**
 	 * Retrieve post categories.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $post_ID
 	 *     @type string $username
 	 *     @type string $password
 		$post_ID  = (int) $args[0];
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		if ( ! get_post( $post_ID ) ) {
 			return new IXR_Error( 404, __( 'Invalid post ID.' ) );
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'mt.getPostCategories' );
 		$categories = array();
 		$catids     = wp_get_post_categories( intval( $post_ID ) );
-		// first listed category will be the primary category
+		// First listed category will be the primary category.
 		$isPrimary = true;
 		foreach ( $catids as $catid ) {
 			$categories[] = array(
 				'categoryName' => get_cat_name( $catid ),
 				'categoryId'   => (string) $catid,
 	/**
 	 * Sets categories for a post.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $post_ID
 	 *     @type string $username
 	 *     @type string $password
 		$post_ID    = (int) $args[0];
 		$username   = $args[1];
 		$password   = $args[2];
 		$categories = $args[3];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'mt.setPostCategories' );
 			return array();
 		}
 		$trackback_pings = array();
 		foreach ( $comments as $comment ) {
-			if ( 'trackback' == $comment->comment_type ) {
+			if ( 'trackback' === $comment->comment_type ) {
 				$content           = $comment->comment_content;
 				$title             = substr( $content, 8, ( strpos( $content, '</strong>' ) - 8 ) );
 				$trackback_pings[] = array(
 					'pingTitle' => $title,
 					'pingURL'   => $comment->comment_author_url,
 	/**
 	 * Sets a post's publish status to 'publish'.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type int    $post_ID
 	 *     @type string $username
 	 *     @type string $password
 		$post_ID  = (int) $args[0];
 		$username = $args[1];
 		$password = $args[2];
-		if ( ! $user = $this->login( $username, $password ) ) {
+		$user = $this->login( $username, $password );
+		if ( ! $user ) {
 			return $this->error;
 		}
 		/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
 		do_action( 'xmlrpc_call', 'mt.publishPost' );
 			return new IXR_Error( 401, __( 'Sorry, you are not allowed to publish this post.' ) );
 		}
 		$postdata['post_status'] = 'publish';
-		// retain old cats
+		// Retain old categories.
-		$cats                      = wp_get_post_categories( $post_ID );
+		$postdata['post_category'] = wp_get_post_categories( $post_ID );
-		$postdata['post_category'] = $cats;
 		$this->escape( $postdata );
 		return wp_update_post( $postdata );
 	}
-	/* PingBack functions
+	/*
-	 * specs on www.hixie.ch/specs/pingback/pingback
+	 * Pingback functions.
+	 * Specs on www.hixie.ch/specs/pingback/pingback
 	 */
 	/**
 	 * Retrieves a pingback and registers it.
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array  $args {
+	 * @param array $args {
 	 *     Method arguments. Note: arguments must be ordered as documented.
 	 *
 	 *     @type string $pagelinkedfrom
 	 *     @type string $pagelinkedto
 	 * }
 		if ( ! $pagelinkedfrom ) {
 			return $this->pingback_error( 0, __( 'A valid URL was not provided.' ) );
 		}
-		// Check if the page linked to is in our site
+		// Check if the page linked to is on our site.
 		$pos1 = strpos( $pagelinkedto, str_replace( array( 'http://www.', 'http://', 'https://www.', 'https://' ), '', get_option( 'home' ) ) );
 		if ( ! $pos1 ) {
 			return $this->pingback_error( 0, __( 'Is there no link to us?' ) );
 		}
-		// let's find which post is linked to
+		/*
-		// FIXME: does url_to_postid() cover all these cases already?
+		 * Let's find which post is linked to.
-		//        if so, then let's use it and drop the old code.
+		 * FIXME: Does url_to_postid() cover all these cases already?
+		 * If so, then let's use it and drop the old code.
+		 */
 		$urltest = parse_url( $pagelinkedto );
-		if ( $post_ID = url_to_postid( $pagelinkedto ) ) {
+		$post_ID = url_to_postid( $pagelinkedto );
+		if ( $post_ID ) {
 			// $way
 		} elseif ( isset( $urltest['path'] ) && preg_match( '#p/[0-9]{1,}#', $urltest['path'], $match ) ) {
-			// the path defines the post_ID (archives/p/XXXX)
+			// The path defines the post_ID (archives/p/XXXX).
 			$blah    = explode( '/', $match[0] );
 			$post_ID = (int) $blah[1];
 		} elseif ( isset( $urltest['query'] ) && preg_match( '#p=[0-9]{1,}#', $urltest['query'], $match ) ) {
-			// the querystring defines the post_ID (?p=XXXX)
+			// The query string defines the post_ID (?p=XXXX).
 			$blah    = explode( '=', $match[0] );
 			$post_ID = (int) $blah[1];
 		} elseif ( isset( $urltest['fragment'] ) ) {
-			// an #anchor is there, it's either...
+			// An #anchor is there, it's either...
 			if ( intval( $urltest['fragment'] ) ) {
-				// ...an integer #XXXX (simplest case)
+				// ...an integer #XXXX (simplest case),
 				$post_ID = (int) $urltest['fragment'];
 			} elseif ( preg_match( '/post-[0-9]+/', $urltest['fragment'] ) ) {
-				// ...a post id in the form 'post-###'
+				// ...a post ID in the form 'post-###',
 				$post_ID = preg_replace( '/[^0-9]+/', '', $urltest['fragment'] );
 			} elseif ( is_string( $urltest['fragment'] ) ) {
-				// ...or a string #title, a little more complicated
+				// ...or a string #title, a little more complicated.
-				$title = preg_replace( '/[^a-z0-9]/i', '.', $urltest['fragment'] );
+				$title   = preg_replace( '/[^a-z0-9]/i', '.', $urltest['fragment'] );
-				$sql   = $wpdb->prepare( "SELECT ID FROM $wpdb->posts WHERE post_title RLIKE %s", $title );
+				$sql     = $wpdb->prepare( "SELECT ID FROM $wpdb->posts WHERE post_title RLIKE %s", $title );
-				if ( ! ( $post_ID = $wpdb->get_var( $sql ) ) ) {
+				$post_ID = $wpdb->get_var( $sql );
-					// returning unknown error '0' is better than die()ing
+				if ( ! $post_ID ) {
+					// Returning unknown error '0' is better than die()'ing.
 					return $this->pingback_error( 0, '' );
 				}
 			}
 		} else {
-			// TODO: Attempt to extract a post ID from the given URL
+			// TODO: Attempt to extract a post ID from the given URL.
 			return $this->pingback_error( 33, __( 'The specified target URL cannot be used as a target. It either doesn&#8217;t exist, or it is not a pingback-enabled resource.' ) );
 		}
 		$post_ID = (int) $post_ID;
 		$post = get_post( $post_ID );
-		if ( ! $post ) { // Post_ID not found
+		if ( ! $post ) { // Post not found.
 			return $this->pingback_error( 33, __( 'The specified target URL cannot be used as a target. It either doesn&#8217;t exist, or it is not a pingback-enabled resource.' ) );
 		}
-		if ( $post_ID == url_to_postid( $pagelinkedfrom ) ) {
+		if ( url_to_postid( $pagelinkedfrom ) == $post_ID ) {
 			return $this->pingback_error( 0, __( 'The source URL and the target URL cannot both point to the same resource.' ) );
 		}
-		// Check if pings are on
+		// Check if pings are on.
 		if ( ! pings_open( $post ) ) {
 			return $this->pingback_error( 33, __( 'The specified target URL cannot be used as a target. It either doesn&#8217;t exist, or it is not a pingback-enabled resource.' ) );
 		}
-		// Let's check that the remote site didn't already pingback this entry
+		// Let's check that the remote site didn't already pingback this entry.
 		if ( $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $wpdb->comments WHERE comment_post_ID = %d AND comment_author_url = %s", $post_ID, $pagelinkedfrom ) ) ) {
 			return $this->pingback_error( 48, __( 'The pingback has already been registered.' ) );
 		}
-		// very stupid, but gives time to the 'from' server to publish !
+		// Very stupid, but gives time to the 'from' server to publish!
 		sleep( 1 );
 		$remote_ip = preg_replace( '/[^0-9a-fA-F:., ]/', '', $_SERVER['REMOTE_ADDR'] );
 		/** This filter is documented in wp-includes/class-http.php */
-		$user_agent = apply_filters( 'http_headers_useragent', 'WordPress/' . get_bloginfo( 'version' ) . '; ' . get_bloginfo( 'url' ), $url );
+		$user_agent = apply_filters( 'http_headers_useragent', 'WordPress/' . get_bloginfo( 'version' ) . '; ' . get_bloginfo( 'url' ), $pagelinkedfrom );
-		// Let's check the remote site
+		// Let's check the remote site.
 		$http_api_args = array(
 			'timeout'             => 10,
 			'redirection'         => 0,
 			'limit_response_size' => 153600, // 150 KB
 			'user-agent'          => "$user_agent; verifying pingback from $remote_ip",
 			'headers'             => array(
 				'X-Pingback-Forwarded-For' => $remote_ip,
 			),
 		);
-		$request       = wp_safe_remote_get( $pagelinkedfrom, $http_api_args );
+		$request                = wp_safe_remote_get( $pagelinkedfrom, $http_api_args );
-		$remote_source = $remote_source_original = wp_remote_retrieve_body( $request );
+		$remote_source          = wp_remote_retrieve_body( $request );
+		$remote_source_original = $remote_source;
 		if ( ! $remote_source ) {
 			return $this->pingback_error( 16, __( 'The source URL does not exist.' ) );
 		}
 		$title = isset( $matchtitle[1] ) ? $matchtitle[1] : '';
 		if ( empty( $title ) ) {
 			return $this->pingback_error( 32, __( 'We cannot find a title on that page.' ) );
 		}
-		$remote_source = strip_tags( $remote_source, '<a>' ); // just keep the tag we need
+		// Remove all script and style tags including their content.
+		$remote_source = preg_replace( '@<(script|style)[^>]*?>.*?</\\1>@si', '', $remote_source );
+		// Just keep the tag we need.
+		$remote_source = strip_tags( $remote_source, '<a>' );
 		$p = explode( "\n\n", $remote_source );
 		$preg_target = preg_quote( $pagelinkedto, '|' );
 		foreach ( $p as $para ) {
-			if ( strpos( $para, $pagelinkedto ) !== false ) { // it exists, but is it a link?
+			if ( strpos( $para, $pagelinkedto ) !== false ) { // It exists, but is it a link?
 				preg_match( '|<a[^>]+?' . $preg_target . '[^>]*>([^>]+?)</a>|', $para, $context );
-				// If the URL isn't in a link context, keep looking
+				// If the URL isn't in a link context, keep looking.
 				if ( empty( $context ) ) {
 					continue;
 				}
-				// We're going to use this fake tag to mark the context in a bit
+				// We're going to use this fake tag to mark the context in a bit.
-				// the marker is needed in case the link text appears more than once in the paragraph
+				// The marker is needed in case the link text appears more than once in the paragraph.
 				$excerpt = preg_replace( '|\</?wpcontext\>|', '', $para );
 				// prevent really long link text
 				if ( strlen( $context[1] ) > 100 ) {
 					$context[1] = substr( $context[1], 0, 100 ) . '&#8230;';
 				}
-				$marker      = '<wpcontext>' . $context[1] . '</wpcontext>';    // set up our marker
+				$marker      = '<wpcontext>' . $context[1] . '</wpcontext>';  // Set up our marker.
-				$excerpt     = str_replace( $context[0], $marker, $excerpt ); // swap out the link for our marker
+				$excerpt     = str_replace( $context[0], $marker, $excerpt ); // Swap out the link for our marker.
-				$excerpt     = strip_tags( $excerpt, '<wpcontext>' );        // strip all tags but our context marker
+				$excerpt     = strip_tags( $excerpt, '<wpcontext>' );         // Strip all tags but our context marker.
 				$excerpt     = trim( $excerpt );
 				$preg_marker = preg_quote( $marker, '|' );
 				$excerpt     = preg_replace( "|.*?\s(.{0,100}$preg_marker.{0,100})\s.*|s", '$1', $excerpt );
-				$excerpt     = strip_tags( $excerpt ); // YES, again, to remove the marker wrapper
+				$excerpt     = strip_tags( $excerpt ); // YES, again, to remove the marker wrapper.
 				break;
 			}
 		}
-		if ( empty( $context ) ) { // Link to target not found
+		if ( empty( $context ) ) { // Link to target not found.
 			return $this->pingback_error( 17, __( 'The source URL does not contain a link to the target URL, and so cannot be used as a source.' ) );
 		}
 		$pagelinkedfrom = str_replace( '&', '&amp;', $pagelinkedfrom );
 		 *
 		 * @param int $comment_ID Comment ID.
 		 */
 		do_action( 'pingback_post', $comment_ID );
-		/* translators: 1: URL of the page linked from, 2: URL of the page linked to */
+		/* translators: 1: URL of the page linked from, 2: URL of the page linked to. */
 		return sprintf( __( 'Pingback from %1$s to %2$s registered. Keep the web talking! :-)' ), $pagelinkedfrom, $pagelinkedto );
 	}
 	/**
 	 * Retrieve array of URLs that pingbacked the given URL.
 		$url = $this->escape( $url );
 		$post_ID = url_to_postid( $url );
 		if ( ! $post_ID ) {
-			// We aren't sure that the resource is available and/or pingback enabled
+			// We aren't sure that the resource is available and/or pingback enabled.
 			return $this->pingback_error( 33, __( 'The specified target URL cannot be used as a target. It either doesn&#8217;t exist, or it is not a pingback-enabled resource.' ) );
 		}
 		$actual_post = get_post( $post_ID, ARRAY_A );
 		if ( ! $actual_post ) {
-			// No such post = resource not found
+			// No such post = resource not found.
 			return $this->pingback_error( 32, __( 'The specified target URL does not exist.' ) );
 		}
 		$comments = $wpdb->get_results( $wpdb->prepare( "SELECT comment_author_url, comment_content, comment_author_IP, comment_type FROM $wpdb->comments WHERE comment_post_ID = %d", $post_ID ) );
 			return array();
 		}
 		$pingbacks = array();
 		foreach ( $comments as $comment ) {
-			if ( 'pingback' == $comment->comment_type ) {
+			if ( 'pingback' === $comment->comment_type ) {
 				$pingbacks[] = $comment->comment_author_url;
 			}
 		}
 		return $pingbacks;

changeset 16	a86126ab1dd4
parent 9	177826044cd9
child 18	be944660c56a