enmi-conf.org: comparison wp/wp-admin/js/image-edit.js

Mercurial Mercurial > enmi-conf.org / comparison

summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help

wp/wp-admin/js/image-edit.js

changeset 16	a86126ab1dd4
parent 9	177826044cd9
child 18	be944660c56a

equal deleted inserted replaced

-:3d4e9c994f10
+:a86126ab1dd4
 *
 * @since 2.9.0
 * @output wp-admin/js/image-edit.js
 */
-/* global imageEditL10n, ajaxurl, confirm */
+/* global ajaxurl, confirm */
 (function($) {
+	var __ = wp.i18n.__;
 	/**
 	 * Contains all the methods to initialise and control the image editor.
 	 *
 	 * @namespace imageEdit
 	},
 	/**
 	 * Converts a value to an integer.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
+	 * @memberof imageEdit
 	 *
 	 * @param {number} f The float value that should be converted.
 	 *
 	 * @return {number} The integer representation from the float value.
 	 */
 	},
 	/**
 	 * Adds the disabled attribute and class to a single form element or a field set.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
+	 * @memberof imageEdit
 	 *
 	 * @param {jQuery}         el The element that should be modified.
-	 * @param {bool|number}    s  The state for the element. If set to true
+	 * @param {boolean|number} s  The state for the element. If set to true
 	 *                            the element is disabled,
 	 *                            otherwise the element is enabled.
 	 *                            The function is sometimes called with a 0 or 1
 	 *                            instead of true or false.
 	 *
-	 * @returns {void}
+	 * @return {void}
 	 */
 	setDisabled : function( el, s ) {
 		/*
 		 * `el` can be a single form element or a fieldset. Before #28864, the disabled state on
 		 * some text fields  was handled targeting $('input', el). Now we need to handle the
 	},
 	/**
 	 * Initializes the image editor.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
-	 *
+	 * @param {number} postid The post ID.
-	 * @returns {void}
+	 *
+	 * @return {void}
 	 */
 	init : function(postid) {
 		var t = this, old = $('#image-editor-' + t.postid),
 			x = t.intval( $('#imgedit-x-' + postid).val() ),
 			y = t.intval( $('#imgedit-y-' + postid).val() );
 		$('#imgedit-response-' + postid).empty();
 		$('input[type="text"]', '#imgedit-panel-' + postid).keypress(function(e) {
 			var k = e.keyCode;
-			// Key codes 37 thru 40 are the arrow keys.
+			// Key codes 37 through 40 are the arrow keys.
 			if ( 36 < k && k < 41 ) {
 				$(this).blur();
 			}
-			// The key code 13 is the enter key.
+			// The key code 13 is the Enter key.
 			if ( 13 === k ) {
 				e.preventDefault();
 				e.stopPropagation();
 				return false;
 			}
 		});
+		$( document ).on( 'image-editor-ui-ready', this.focusManager );
 	},
 	/**
 	 * Toggles the wait/load icon in the editor.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 * @since 5.5.0 Added the triggerUIReady parameter.
 	 *
-	 * @param {number} postid The post id.
+	 * @memberof imageEdit
-	 * @param {number} toggle Is 0 or 1, fades the icon in then 1 and out when 0.
+	 *
-	 *
+	 * @param {number}  postid         The post ID.
-	 * @returns {void}
+	 * @param {number}  toggle         Is 0 or 1, fades the icon in when 1 and out when 0.
-	 */
+	 * @param {boolean} triggerUIReady Whether to trigger a custom event when the UI is ready. Default false.
-	toggleEditor : function(postid, toggle) {
+	 *
+	 * @return {void}
+	 */
+	toggleEditor: function( postid, toggle, triggerUIReady ) {
 		var wait = $('#imgedit-wait-' + postid);
 		if ( toggle ) {
 			wait.fadeIn( 'fast' );
 		} else {
-			wait.fadeOut('fast');
+			wait.fadeOut( 'fast', function() {
+				if ( triggerUIReady ) {
+					$( document ).trigger( 'image-editor-ui-ready' );
+				}
+			} );
 		}
 	},
 	/**
 	 * Shows or hides the image edit help box.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
+	 * @memberof imageEdit
 	 *
 	 * @param {HTMLElement} el The element to create the help window in.
 	 *
-	 * @returns {boolean} Always returns false.
+	 * @return {boolean} Always returns false.
 	 */
 	toggleHelp : function(el) {
 		var $el = $( el );
 		$el
 			.attr( 'aria-expanded', 'false' === $el.attr( 'aria-expanded' ) ? 'true' : 'false' )
 	 * Gets the value from the image edit target.
 	 *
 	 * The image edit target contains the image sizes where the (possible) changes
 	 * have to be applied to.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
-	 *
+	 * @param {number} postid The post ID.
-	 * @returns {string} The value from the imagedit-save-target input field when available,
+	 *
-	 *                   or 'full' when not available.
+	 * @return {string} The value from the imagedit-save-target input field when available,
+	 *                  or 'full' when not available.
 	 */
 	getTarget : function(postid) {
 		return $('input[name="imgedit-target-' + postid + '"]:checked', '#imgedit-save-target-' + postid).val() || 'full';
 	},
 	/**
 	 * Recalculates the height or width and keeps the original aspect ratio.
 	 *
 	 * If the original image size is exceeded a red exclamation mark is shown.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number}         postid The current post id.
+	 *
+	 * @param {number}         postid The current post ID.
 	 * @param {number}         x      Is 0 when it applies the y-axis
 	 *                                and 1 when applicable for the x-axis.
 	 * @param {jQuery}         el     Element.
 	 *
-	 * @returns {void}
+	 * @return {void}
 	 */
 	scaleChanged : function( postid, x, el ) {
 		var w = $('#imgedit-scale-width-' + postid), h = $('#imgedit-scale-height-' + postid),
 		warn = $('#imgedit-scale-warn-' + postid), w1 = '', h1 = '';
 	},
 	/**
 	 * Gets the selected aspect ratio.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
-	 *
+	 * @param {number} postid The post ID.
-	 * @returns {string} The aspect ratio.
+	 *
+	 * @return {string} The aspect ratio.
 	 */
 	getSelRatio : function(postid) {
 		var x = this.hold.w, y = this.hold.h,
 			X = this.intval( $('#imgedit-crop-width-' + postid).val() ),
 			Y = this.intval( $('#imgedit-crop-height-' + postid).val() );
 	/**
 	 * Removes the last action from the image edit history.
 	 * The history consist of (edit) actions performed on the image.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid  The post id.
+	 *
+	 * @param {number} postid  The post ID.
 	 * @param {number} setSize 0 or 1, when 1 the image resets to its original size.
 	 *
-	 * @returns {string} JSON string containing the history or an empty string if no history exists.
+	 * @return {string} JSON string containing the history or an empty string if no history exists.
 	 */
 	filterHistory : function(postid, setSize) {
 		// Apply undo state to history.
 		var history = $('#imgedit-history-' + postid).val(), pop, n, o, i, op = [];
 				}
 				// Restore original 'o'.
 				o = history[history.length - 1];
-				// c = 'crop', r = 'rotate', f = 'flip'
+				// c = 'crop', r = 'rotate', f = 'flip'.
 				o = o.c || o.r || o.f || false;
 				if ( o ) {
-					// fw = Full image width
+					// fw = Full image width.
 					this.hold.w = o.fw;
-					// fh = Full image height
+					// fh = Full image height.
 					this.hold.h = o.fh;
 				}
 			}
 			// Filter the last step/action from the history.
 	/**
 	 * Binds the necessary events to the image.
 	 *
 	 * When the image source is reloaded the image will be reloaded.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number}   postid   The post id.
+	 *
+	 * @param {number}   postid   The post ID.
 	 * @param {string}   nonce    The nonce to verify the request.
 	 * @param {function} callback Function to execute when the image is loaded.
 	 *
-	 * @returns {void}
+	 * @return {void}
 	 */
 	refreshEditor : function(postid, nonce, callback) {
 		var t = this, data, img;
 		t.toggleEditor(postid, 1);
 					}
 				}
 				parent.empty().append(img);
-				// w, h are the new full size dims
+				// w, h are the new full size dimensions.
 				max1 = Math.max( t.hold.w, t.hold.h );
 				max2 = Math.max( $(img).width(), $(img).height() );
 				t.hold.sizer = max1 > max2 ? max2 / max1 : 1;
 				t.initCrop(postid, img, parent);
 					$('input.imgedit-submit-btn', '#imgedit-panel-' + postid).prop('disabled', true);
 				}
 				t.toggleEditor(postid, 0);
 			})
-			.on('error', function() {
+			.on( 'error', function() {
-				$('#imgedit-crop-' + postid).empty().append('<div class="error"><p>' + imageEditL10n.error + '</p></div>');
+				var errorMessage = __( 'Could not load the preview image. Please reload the page and try again.' );
-				t.toggleEditor(postid, 0);
-			})
+				$( '#imgedit-crop-' + postid )
+					.empty()
+					.append( '<div class="notice notice-error" tabindex="-1" role="alert"><p>' + errorMessage + '</p></div>' );
+				t.toggleEditor( postid, 0, true );
+				wp.a11y.speak( errorMessage, 'assertive' );
+			} )
 			.attr('src', ajaxurl + '?' + $.param(data));
 	},
 	/**
 	 * Performs an image edit action.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param  {number}  postid The post id.
+	 *
-	 * @param  {string}  nonce  The nonce to verify the request.
+	 * @param {number} postid The post ID.
-	 * @param  {string}  action The action to perform on the image.
+	 * @param {string} nonce  The nonce to verify the request.
-	 *                          The possible actions are: "scale" and "restore".
+	 * @param {string} action The action to perform on the image.
-	 *
+	 *                        The possible actions are: "scale" and "restore".
-	 * @returns {boolean|void} Executes a post request that refreshes the page
+	 *
-	 *                         when the action is performed.
+	 * @return {boolean|void} Executes a post request that refreshes the page
-	 *                         Returns false if a invalid action is given,
+	 *                        when the action is performed.
-	 *                         or when the action cannot be performed.
+	 *                        Returns false if a invalid action is given,
+	 *                        or when the action cannot be performed.
 	 */
 	action : function(postid, nonce, action) {
 		var t = this, data, w, h, fw, fh;
 		if ( t.notsaved(postid) ) {
 		} else {
 			return false;
 		}
 		t.toggleEditor(postid, 1);
-		$.post(ajaxurl, data, function(r) {
+		$.post( ajaxurl, data, function( response ) {
-			$('#image-editor-' + postid).empty().append(r);
+			$( '#image-editor-' + postid ).empty().append( response.data.html );
-			t.toggleEditor(postid, 0);
+			t.toggleEditor( postid, 0, true );
-			// refresh the attachment model so that changes propagate
+			// Refresh the attachment model so that changes propagate.
 			if ( t._view ) {
 				t._view.refresh();
 			}
-		});
+		} ).done( function( response ) {
+			// Whether the executed action was `scale` or `restore`, the response does have a message.
+			if ( response && response.data.message.msg ) {
+				wp.a11y.speak( response.data.message.msg );
+				return;
+			}
+			if ( response && response.data.message.error ) {
+				wp.a11y.speak( response.data.message.error );
+			}
+		} );
 	},
 	/**
 	 * Stores the changes that are made to the image.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number}  postid   The post id to get the image from the database.
+	 *
+	 * @param {number}  postid   The post ID to get the image from the database.
 	 * @param {string}  nonce    The nonce to verify the request.
 	 *
-	 * @returns {boolean|void}  If the actions are successfully saved a response message is shown.
+	 * @return {boolean|void}  If the actions are successfully saved a response message is shown.
-	 *                          Returns false if there is no image editing history,
+	 *                         Returns false if there is no image editing history,
-	 *                          thus there are not edit-actions performed on the image.
+	 *                         thus there are not edit-actions performed on the image.
 	 */
 	save : function(postid, nonce) {
 		var data,
 			target = this.getTarget(postid),
 			history = this.filterHistory(postid, 0),
 			'target': target,
 			'context': $('#image-edit-context').length ? $('#image-edit-context').val() : null,
 			'do': 'save'
 		};
 		// Post the image edit data to the backend.
-		$.post(ajaxurl, data, function(r) {
+		$.post( ajaxurl, data, function( response ) {
-			// Read the response.
-			var ret = JSON.parse(r);
 			// If a response is returned, close the editor and show an error.
-			if ( ret.error ) {
+			if ( response.data.error ) {
-				$('#imgedit-response-' + postid).html('<div class="error"><p>' + ret.error + '</p></div>');
+				$( '#imgedit-response-' + postid )
+					.html( '<div class="notice notice-error" tabindex="-1" role="alert"><p>' + response.data.error + '</p></div>' );
 				imageEdit.close(postid);
+				wp.a11y.speak( response.data.error );
 				return;
 			}
-			if ( ret.fw && ret.fh ) {
+			if ( response.data.fw && response.data.fh ) {
-				$('#media-dims-' + postid).html( ret.fw + ' &times; ' + ret.fh );
+				$( '#media-dims-' + postid ).html( response.data.fw + ' &times; ' + response.data.fh );
 			}
-			if ( ret.thumbnail ) {
+			if ( response.data.thumbnail ) {
-				$('.thumbnail', '#thumbnail-head-' + postid).attr('src', ''+ret.thumbnail);
+				$( '.thumbnail', '#thumbnail-head-' + postid ).attr( 'src', '' + response.data.thumbnail );
 			}
-			if ( ret.msg ) {
+			if ( response.data.msg ) {
-				$('#imgedit-response-' + postid).html('<div class="updated"><p>' + ret.msg + '</p></div>');
+				$( '#imgedit-response-' + postid )
+					.html( '<div class="notice notice-success" tabindex="-1" role="alert"><p>' + response.data.msg + '</p></div>' );
+				wp.a11y.speak( response.data.msg );
 			}
 			if ( self._view ) {
 				self._view.save();
 			} else {
 	},
 	/**
 	 * Creates the image edit window.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid   The post id for the image.
+	 *
+	 * @param {number} postid   The post ID for the image.
 	 * @param {string} nonce    The nonce to verify the request.
-	 * @param {object} view     The image editor view to be used for the editing.
+	 * @param {Object} view     The image editor view to be used for the editing.
 	 *
-	 * @returns {void|promise} Either returns void if the button was already activated
+	 * @return {void|promise} Either returns void if the button was already activated
-	 *                         or returns an instance of the image editor, wrapped in a promise.
+	 *                        or returns an instance of the image editor, wrapped in a promise.
 	 */
 	open : function( postid, nonce, view ) {
 		this._view = view;
-		var dfd, data, elem = $('#image-editor-' + postid), head = $('#media-head-' + postid),
+		var dfd, data,
-			btn = $('#imgedit-open-btn-' + postid), spin = btn.siblings('.spinner');
+			elem = $( '#image-editor-' + postid ),
+			head = $( '#media-head-' + postid ),
+			btn = $( '#imgedit-open-btn-' + postid ),
+			spin = btn.siblings( '.spinner' );
 		/*
 		 * Instead of disabling the button, which causes a focus loss and makes screen
 		 * readers announce "unavailable", return if the button was already clicked.
 		 */
 			'_ajax_nonce': nonce,
 			'postid': postid,
 			'do': 'open'
 		};
-		dfd = $.ajax({
+		dfd = $.ajax( {
 			url:  ajaxurl,
 			type: 'post',
 			data: data,
 			beforeSend: function() {
 				btn.addClass( 'button-activated' );
 			}
-		}).done(function( html ) {
+		} ).done( function( response ) {
-			elem.html( html );
+			var errorMessage;
-			head.fadeOut('fast', function(){
-				elem.fadeIn('fast');
+			if ( '-1' === response ) {
+				errorMessage = __( 'Could not load the preview image.' );
+				elem.html( '<div class="notice notice-error" tabindex="-1" role="alert"><p>' + errorMessage + '</p></div>' );
+			}
+			if ( response.data && response.data.html ) {
+				elem.html( response.data.html );
+			}
+			head.fadeOut( 'fast', function() {
+				elem.fadeIn( 'fast', function() {
+					if ( errorMessage ) {
+						$( document ).trigger( 'image-editor-ui-ready' );
+					}
+				} );
 				btn.removeClass( 'button-activated' );
 				spin.removeClass( 'is-active' );
-			});
+			} );
 			// Initialise the Image Editor now that everything is ready.
 			imageEdit.init( postid );
-		});
+		} );
 		return dfd;
 	},
 	/**
 	 * Initializes the cropping tool and sets a default cropping selection.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
-	 *
+	 * @param {number} postid The post ID.
-	 * @returns {void}
+	 *
+	 * @return {void}
 	 */
 	imgLoaded : function(postid) {
 		var img = $('#image-preview-' + postid), parent = $('#imgedit-crop-' + postid);
 		// Ensure init has run even when directly loaded.
 		}
 		this.initCrop(postid, img, parent);
 		this.setCropSelection( postid, { 'x1': 0, 'y1': 0, 'x2': 0, 'y2': 0, 'width': img.innerWidth(), 'height': img.innerHeight() } );
-		this.toggleEditor(postid, 0);
+		this.toggleEditor( postid, 0, true );
-		// Editor is ready, move focus to the first focusable element.
+	},
-		$( '.imgedit-wrap .imgedit-help-toggle' ).eq( 0 ).focus();
+	/**
+	 * Manages keyboard focus in the Image Editor user interface.
+	 *
+	 * @since 5.5.0
+	 *
+	 * @return {void}
+	 */
+	focusManager: function() {
+		/*
+		 * Editor is ready. Move focus to one of the admin alert notices displayed
+		 * after a user action or to the first focusable element. Since the DOM
+		 * update is pretty large, the timeout helps browsers update their
+		 * accessibility tree to better support assistive technologies.
+		 */
+		setTimeout( function() {
+			var elementToSetFocusTo = $( '.notice[role="alert"]' );
+			if ( ! elementToSetFocusTo.length ) {
+				elementToSetFocusTo = $( '.imgedit-wrap' ).find( ':tabbable:first' );
+			}
+			elementToSetFocusTo.focus();
+		}, 100 );
 	},
 	/**
 	 * Initializes the cropping tool.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number}      postid The post id.
+	 *
+	 * @param {number}      postid The post ID.
 	 * @param {HTMLElement} image  The preview image.
 	 * @param {HTMLElement} parent The preview image container.
 	 *
-	 * @returns {void}
+	 * @return {void}
 	 */
 	initCrop : function(postid, image, parent) {
 		var t = this,
 			selW = $('#imgedit-sel-width-' + postid),
 			selH = $('#imgedit-sel-height-' + postid),
+			$image = $( image ),
 			$img;
-		t.iasapi = $(image).imgAreaSelect({
+		// Already initialized?
+		if ( $image.data( 'imgAreaSelect' ) ) {
+			return;
+		}
+		t.iasapi = $image.imgAreaSelect({
 			parent: parent,
 			instance: true,
 			handles: true,
 			keys: true,
 			minWidth: 3,
 			 * @ignore
 			 *
 			 * @param {jQuery} img The preview image.
 			 */
 			onInit: function( img ) {
-				// Ensure that the imgAreaSelect wrapper elements are position:absolute.
+				// Ensure that the imgAreaSelect wrapper elements are position:absolute
-				// (even if we're in a position:fixed modal)
+				// (even if we're in a position:fixed modal).
 				$img = $( img );
 				$img.next().css( 'position', 'absolute' )
 					.nextAll( '.imgareaselect-outer' ).css( 'position', 'absolute' );
 				/**
 				 * Binds mouse down event to the cropping container.
 				 *
-				 * @returns {void}
+				 * @return {void}
 				 */
 				parent.children().on( 'mousedown, touchstart', function(e){
 					var ratio = false, sel, defRatio;
 					if ( e.shiftKey ) {
 			/**
 			 * Event triggered when starting a selection.
 			 *
 			 * @ignore
 			 *
-			 * @returns {void}
+			 * @return {void}
 			 */
 			onSelectStart: function() {
 				imageEdit.setDisabled($('#imgedit-crop-sel-' + postid), 1);
 			},
 			/**
 			 * Event triggered when the selection is ended.
 			 *
 			 * @ignore
 			 *
-			 * @param {object} img jQuery object representing the image.
+			 * @param {Object} img jQuery object representing the image.
-			 * @param {object} c   The selection.
+			 * @param {Object} c   The selection.
 			 *
-			 * @returns {object}
+			 * @return {Object}
 			 */
 			onSelectEnd: function(img, c) {
 				imageEdit.setCropSelection(postid, c);
 			},
 			/**
 			 * Event triggered when the selection changes.
 			 *
 			 * @ignore
 			 *
-			 * @param {object} img jQuery object representing the image.
+			 * @param {Object} img jQuery object representing the image.
-			 * @param {object} c   The selection.
+			 * @param {Object} c   The selection.
 			 *
-			 * @returns {void}
+			 * @return {void}
 			 */
 			onSelectChange: function(img, c) {
 				var sizer = imageEdit.hold.sizer;
 				selW.val( imageEdit.round(c.width / sizer) );
 				selH.val( imageEdit.round(c.height / sizer) );
 	},
 	/**
 	 * Stores the current crop selection.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
-	 * @param {object} c      The selection.
+	 * @param {number} postid The post ID.
-	 *
+	 * @param {Object} c      The selection.
-	 * @returns {boolean}
+	 *
+	 * @return {boolean}
 	 */
 	setCropSelection : function(postid, c) {
 		var sel;
 		c = c || 0;
 	/**
 	 * Closes the image editor.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number}  postid The post id.
+	 *
-	 * @param {bool}    warn   Warning message.
+	 * @param {number}  postid The post ID.
-	 *
+	 * @param {boolean} warn   Warning message.
-	 * @returns {void|bool} Returns false if there is a warning.
+	 *
+	 * @return {void|boolean} Returns false if there is a warning.
 	 */
 	close : function(postid, warn) {
 		warn = warn || false;
 		if ( warn && this.notsaved(postid) ) {
 		}
 		this.iasapi = {};
 		this.hold = {};
-		// If we've loaded the editor in the context of a Media Modal, then switch to the previous view,
+		// If we've loaded the editor in the context of a Media Modal,
-		// whatever that might have been.
+		// then switch to the previous view, whatever that might have been.
 		if ( this._view ){
 			this._view.back();
 		}
-		// In case we are not accessing the image editor in the context of a View, close the editor the old-skool way
+		// In case we are not accessing the image editor in the context of a View,
+		// close the editor the old-school way.
 		else {
 			$('#image-editor-' + postid).fadeOut('fast', function() {
 				$( '#media-head-' + postid ).fadeIn( 'fast', function() {
 					// Move focus back to the Edit Image button. Runs also when saving.
 					$( '#imgedit-open-btn-' + postid ).focus();
 	},
 	/**
 	 * Checks if the image edit history is saved.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
-	 *
+	 * @param {number} postid The post ID.
-	 * @returns {boolean} Returns true if the history is not saved.
+	 *
+	 * @return {boolean} Returns true if the history is not saved.
 	 */
 	notsaved : function(postid) {
 		var h = $('#imgedit-history-' + postid).val(),
 			history = ( h !== '' ) ? JSON.parse(h) : [],
 			pop = this.intval( $('#imgedit-undone-' + postid).val() );
 	},
 	/**
 	 * Adds an image edit action to the history.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {object} op     The original position.
+	 *
-	 * @param {number} postid The post id.
+	 * @param {Object} op     The original position.
+	 * @param {number} postid The post ID.
 	 * @param {string} nonce  The nonce.
 	 *
-	 * @returns {void}
+	 * @return {void}
 	 */
 	addStep : function(op, postid, nonce) {
 		var t = this, elem = $('#imgedit-history-' + postid),
 			history = ( elem.val() !== '' ) ? JSON.parse( elem.val() ) : [],
 			undone = $( '#imgedit-undone-' + postid ),
 		while ( pop > 0 ) {
 			history.pop();
 			pop--;
 		}
-		undone.val(0); // reset
+		undone.val(0); // Reset.
 		history.push(op);
 		elem.val( JSON.stringify(history) );
 		t.refreshEditor(postid, nonce, function() {
 	},
 	/**
 	 * Rotates the image.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
+	 * @memberof imageEdit
 	 *
 	 * @param {string} angle  The angle the image is rotated with.
-	 * @param {number} postid The post id.
+	 * @param {number} postid The post ID.
 	 * @param {string} nonce  The nonce.
-	 * @param {object} t      The target element.
+	 * @param {Object} t      The target element.
 	 *
-	 * @returns {boolean}
+	 * @return {boolean}
 	 */
 	rotate : function(angle, postid, nonce, t) {
 		if ( $(t).hasClass('disabled') ) {
 			return false;
 		}
 	},
 	/**
 	 * Flips the image.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
+	 * @memberof imageEdit
 	 *
 	 * @param {number} axis   The axle the image is flipped on.
-	 * @param {number} postid The post id.
+	 * @param {number} postid The post ID.
 	 * @param {string} nonce  The nonce.
-	 * @param {object} t      The target element.
+	 * @param {Object} t      The target element.
 	 *
-	 * @returns {boolean}
+	 * @return {boolean}
 	 */
 	flip : function (axis, postid, nonce, t) {
 		if ( $(t).hasClass('disabled') ) {
 			return false;
 		}
 	},
 	/**
 	 * Crops the image.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
+	 * @param {number} postid The post ID.
 	 * @param {string} nonce  The nonce.
-	 * @param {object} t      The target object.
+	 * @param {Object} t      The target object.
 	 *
-	 * @returns {void|boolean} Returns false if the crop button is disabled.
+	 * @return {void|boolean} Returns false if the crop button is disabled.
 	 */
 	crop : function (postid, nonce, t) {
 		var sel = $('#imgedit-selection-' + postid).val(),
 			w = this.intval( $('#imgedit-sel-width-' + postid).val() ),
 			h = this.intval( $('#imgedit-sel-height-' + postid).val() );
 	},
 	/**
 	 * Undoes an image edit action.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid   The post id.
+	 *
+	 * @param {number} postid   The post ID.
 	 * @param {string} nonce    The nonce.
 	 *
-	 * @returns {void|false} Returns false if the undo button is disabled.
+	 * @return {void|false} Returns false if the undo button is disabled.
 	 */
 	undo : function (postid, nonce) {
 		var t = this, button = $('#image-undo-' + postid), elem = $('#imgedit-undone-' + postid),
 			pop = t.intval( elem.val() ) + 1;
 	},
 	/**
 	 * Reverts a undo action.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
+	 * @param {number} postid The post ID.
 	 * @param {string} nonce  The nonce.
 	 *
-	 * @returns {void}
+	 * @return {void}
 	 */
 	redo : function(postid, nonce) {
 		var t = this, button = $('#image-redo-' + postid), elem = $('#imgedit-undone-' + postid),
 			pop = t.intval( elem.val() ) - 1;
 	},
 	/**
 	 * Sets the selection for the height and width in pixels.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid The post id.
+	 *
+	 * @param {number} postid The post ID.
 	 * @param {jQuery} el     The element containing the values.
 	 *
-	 * @returns {void|boolean} Returns false when the x or y value is lower than 1,
+	 * @return {void|boolean} Returns false when the x or y value is lower than 1,
-	 *                         void when the value is not numeric or when the operation
+	 *                        void when the value is not numeric or when the operation
-	 *                         is successful.
+	 *                        is successful.
 	 */
 	setNumSelection : function( postid, el ) {
 		var sel, elX = $('#imgedit-sel-width-' + postid), elY = $('#imgedit-sel-height-' + postid),
 			x = this.intval( elX.val() ), y = this.intval( elY.val() ),
 			img = $('#image-preview-' + postid), imgh = img.height(), imgw = img.width(),
 	},
 	/**
 	 * Rounds a number to a whole.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
+	 * @memberof imageEdit
 	 *
 	 * @param {number} num The number.
 	 *
-	 * @returns {number} The number rounded to a whole number.
+	 * @return {number} The number rounded to a whole number.
 	 */
 	round : function(num) {
 		var s;
 		num = Math.round(num);
 	},
 	/**
 	 * Sets a locked aspect ratio for the selection.
 	 *
-	 * @memberof imageEdit
+	 * @since 2.9.0
-	 * @since    2.9.0
+	 *
-	 *
+	 * @memberof imageEdit
-	 * @param {number} postid     The post id.
+	 *
+	 * @param {number} postid     The post ID.
 	 * @param {number} n          The ratio to set.
 	 * @param {jQuery} el         The element containing the values.
 	 *
-	 * @returns {void}
+	 * @return {void}
 	 */
 	setRatioSelection : function(postid, n, el) {
 		var sel, r, x = this.intval( $('#imgedit-crop-width-' + postid).val() ),
 			y = this.intval( $('#imgedit-crop-height-' + postid).val() ),
 			h = $('#image-preview-' + postid).height();
 		if ( false === this.validateNumeric( el ) ) {
+			this.iasapi.setOptions({
+				aspectRatio: null
+			});
 			return;
 		}
 		if ( x && y ) {
 			this.iasapi.setOptions({
 	},
 	/**
 	 * Validates if a value in a jQuery.HTMLElement is numeric.
 	 *
-	 * @memberof imageEdit
+	 * @since 4.6.0
-	 * @since    4.6
+	 *
+	 * @memberof imageEdit
 	 *
 	 * @param {jQuery} el The html element.
 	 *
-	 * @returns {void|boolean} Returns false if the value is not numeric,
+	 * @return {void|boolean} Returns false if the value is not numeric,
-	 *                         void when it is.
+	 *                        void when it is.
 	 */
 	validateNumeric: function( el ) {
 		if ( ! this.intval( $( el ).val() ) ) {
 			$( el ).val( '' );
 			return false;

enmi-conf.org