web/lib/django/core/management/validation.py
author ymh <ymh.work@gmail.com>
Thu, 05 Aug 2010 17:28:09 +0200
changeset 50 012451a812f1
parent 38 77b6da96e6f1
permissions -rw-r--r--
Merge with a2711e44ba5de8b1675d7e0ee6aaa4a6c56a9b46
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
38
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     1
import sys
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     2
from django.core.management.color import color_style
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     3
from django.utils.itercompat import is_iterable
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     4
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     5
class ModelErrorCollection:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     6
    def __init__(self, outfile=sys.stdout):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     7
        self.errors = []
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     8
        self.outfile = outfile
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
     9
        self.style = color_style()
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    10
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    11
    def add(self, context, error):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    12
        self.errors.append((context, error))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    13
        self.outfile.write(self.style.ERROR("%s: %s\n" % (context, error)))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    14
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    15
def get_validation_errors(outfile, app=None):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    16
    """
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    17
    Validates all models that are part of the specified app. If no app name is provided,
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    18
    validates all models of all installed apps. Writes errors, if any, to outfile.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    19
    Returns number of errors.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    20
    """
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    21
    from django.conf import settings
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    22
    from django.db import models, connection
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    23
    from django.db.models.loading import get_app_errors
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    24
    from django.db.models.fields.related import RelatedObject
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    25
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    26
    e = ModelErrorCollection(outfile)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    27
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    28
    for (app_name, error) in get_app_errors().items():
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    29
        e.add(app_name, error)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    30
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    31
    for cls in models.get_models(app):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    32
        opts = cls._meta
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    33
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    34
        # Do field-specific validation.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    35
        for f in opts.local_fields:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    36
            if f.name == 'id' and not f.primary_key and opts.pk.name == 'id':
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    37
                e.add(opts, '"%s": You can\'t use "id" as a field name, because each model automatically gets an "id" field if none of the fields have primary_key=True. You need to either remove/rename your "id" field or add primary_key=True to a field.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    38
            if f.name.endswith('_'):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    39
                e.add(opts, '"%s": Field names cannot end with underscores, because this would lead to ambiguous queryset filters.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    40
            if isinstance(f, models.CharField):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    41
                try:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    42
                    max_length = int(f.max_length)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    43
                    if max_length <= 0:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    44
                        e.add(opts, '"%s": CharFields require a "max_length" attribute that is a positive integer.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    45
                except (ValueError, TypeError):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    46
                    e.add(opts, '"%s": CharFields require a "max_length" attribute that is a positive integer.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    47
            if isinstance(f, models.DecimalField):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    48
                decimalp_msg ='"%s": DecimalFields require a "decimal_places" attribute that is a non-negative integer.'
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    49
                try:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    50
                    decimal_places = int(f.decimal_places)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    51
                    if decimal_places < 0:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    52
                        e.add(opts, decimalp_msg % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    53
                except (ValueError, TypeError):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    54
                    e.add(opts, decimalp_msg % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    55
                mdigits_msg = '"%s": DecimalFields require a "max_digits" attribute that is a positive integer.'
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    56
                try:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    57
                    max_digits = int(f.max_digits)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    58
                    if max_digits <= 0:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    59
                        e.add(opts,  mdigits_msg % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    60
                except (ValueError, TypeError):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    61
                    e.add(opts, mdigits_msg % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    62
            if isinstance(f, models.FileField) and not f.upload_to:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    63
                e.add(opts, '"%s": FileFields require an "upload_to" attribute.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    64
            if isinstance(f, models.ImageField):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    65
                # Try to import PIL in either of the two ways it can end up installed.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    66
                try:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    67
                    from PIL import Image
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    68
                except ImportError:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    69
                    try:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    70
                        import Image
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    71
                    except ImportError:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    72
                        e.add(opts, '"%s": To use ImageFields, you need to install the Python Imaging Library. Get it at http://www.pythonware.com/products/pil/ .' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    73
            if isinstance(f, models.BooleanField) and getattr(f, 'null', False):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    74
                e.add(opts, '"%s": BooleanFields do not accept null values. Use a NullBooleanField instead.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    75
            if f.choices:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    76
                if isinstance(f.choices, basestring) or not is_iterable(f.choices):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    77
                    e.add(opts, '"%s": "choices" should be iterable (e.g., a tuple or list).' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    78
                else:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    79
                    for c in f.choices:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    80
                        if not isinstance(c, (list, tuple)) or len(c) != 2:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    81
                            e.add(opts, '"%s": "choices" should be a sequence of two-tuples.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    82
            if f.db_index not in (None, True, False):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    83
                e.add(opts, '"%s": "db_index" should be either None, True or False.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    84
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    85
            # Perform any backend-specific field validation.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    86
            connection.validation.validate_field(e, opts, f)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    87
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    88
            # Check to see if the related field will clash with any existing
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    89
            # fields, m2m fields, m2m related objects or related objects
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    90
            if f.rel:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    91
                if f.rel.to not in models.get_models():
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    92
                    e.add(opts, "'%s' has a relation with model %s, which has either not been installed or is abstract." % (f.name, f.rel.to))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    93
                # it is a string and we could not find the model it refers to
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    94
                # so skip the next section
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    95
                if isinstance(f.rel.to, (str, unicode)):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    96
                    continue
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    97
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    98
                # Make sure the related field specified by a ForeignKey is unique
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
    99
                if not f.rel.to._meta.get_field(f.rel.field_name).unique:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   100
                    e.add(opts, "Field '%s' under model '%s' must have a unique=True constraint." % (f.rel.field_name, f.rel.to.__name__))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   101
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   102
                rel_opts = f.rel.to._meta
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   103
                rel_name = RelatedObject(f.rel.to, cls, f).get_accessor_name()
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   104
                rel_query_name = f.related_query_name()
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   105
                if not f.rel.is_hidden():
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   106
                    for r in rel_opts.fields:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   107
                        if r.name == rel_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   108
                            e.add(opts, "Accessor for field '%s' clashes with field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.name, f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   109
                        if r.name == rel_query_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   110
                            e.add(opts, "Reverse query name for field '%s' clashes with field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.name, f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   111
                    for r in rel_opts.local_many_to_many:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   112
                        if r.name == rel_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   113
                            e.add(opts, "Accessor for field '%s' clashes with m2m field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.name, f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   114
                        if r.name == rel_query_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   115
                            e.add(opts, "Reverse query name for field '%s' clashes with m2m field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.name, f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   116
                    for r in rel_opts.get_all_related_many_to_many_objects():
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   117
                        if r.get_accessor_name() == rel_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   118
                            e.add(opts, "Accessor for field '%s' clashes with related m2m field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   119
                        if r.get_accessor_name() == rel_query_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   120
                            e.add(opts, "Reverse query name for field '%s' clashes with related m2m field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   121
                    for r in rel_opts.get_all_related_objects():
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   122
                        if r.field is not f:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   123
                            if r.get_accessor_name() == rel_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   124
                                e.add(opts, "Accessor for field '%s' clashes with related field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   125
                            if r.get_accessor_name() == rel_query_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   126
                                e.add(opts, "Reverse query name for field '%s' clashes with related field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   127
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   128
        seen_intermediary_signatures = []
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   129
        for i, f in enumerate(opts.local_many_to_many):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   130
            # Check to see if the related m2m field will clash with any
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   131
            # existing fields, m2m fields, m2m related objects or related
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   132
            # objects
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   133
            if f.rel.to not in models.get_models():
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   134
                e.add(opts, "'%s' has an m2m relation with model %s, which has either not been installed or is abstract." % (f.name, f.rel.to))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   135
                # it is a string and we could not find the model it refers to
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   136
                # so skip the next section
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   137
                if isinstance(f.rel.to, (str, unicode)):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   138
                    continue
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   139
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   140
            # Check that the field is not set to unique.  ManyToManyFields do not support unique.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   141
            if f.unique:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   142
                e.add(opts, "ManyToManyFields cannot be unique.  Remove the unique argument on '%s'." % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   143
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   144
            if f.rel.through is not None and not isinstance(f.rel.through, basestring):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   145
                from_model, to_model = cls, f.rel.to
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   146
                if from_model == to_model and f.rel.symmetrical and not f.rel.through._meta.auto_created:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   147
                    e.add(opts, "Many-to-many fields with intermediate tables cannot be symmetrical.")
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   148
                seen_from, seen_to, seen_self = False, False, 0
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   149
                for inter_field in f.rel.through._meta.fields:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   150
                    rel_to = getattr(inter_field.rel, 'to', None)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   151
                    if from_model == to_model: # relation to self
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   152
                        if rel_to == from_model:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   153
                            seen_self += 1
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   154
                        if seen_self > 2:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   155
                            e.add(opts, "Intermediary model %s has more than "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   156
                                "two foreign keys to %s, which is ambiguous "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   157
                                "and is not permitted." % (
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   158
                                    f.rel.through._meta.object_name,
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   159
                                    from_model._meta.object_name
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   160
                                )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   161
                            )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   162
                    else:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   163
                        if rel_to == from_model:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   164
                            if seen_from:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   165
                                e.add(opts, "Intermediary model %s has more "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   166
                                    "than one foreign key to %s, which is "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   167
                                    "ambiguous and is not permitted." % (
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   168
                                        f.rel.through._meta.object_name,
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   169
                                         from_model._meta.object_name
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   170
                                     )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   171
                                 )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   172
                            else:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   173
                                seen_from = True
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   174
                        elif rel_to == to_model:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   175
                            if seen_to:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   176
                                e.add(opts, "Intermediary model %s has more "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   177
                                    "than one foreign key to %s, which is "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   178
                                    "ambiguous and is not permitted." % (
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   179
                                        f.rel.through._meta.object_name,
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   180
                                        rel_to._meta.object_name
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   181
                                    )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   182
                                )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   183
                            else:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   184
                                seen_to = True
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   185
                if f.rel.through not in models.get_models(include_auto_created=True):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   186
                    e.add(opts, "'%s' specifies an m2m relation through model "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   187
                        "%s, which has not been installed." % (f.name, f.rel.through)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   188
                    )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   189
                signature = (f.rel.to, cls, f.rel.through)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   190
                if signature in seen_intermediary_signatures:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   191
                    e.add(opts, "The model %s has two manually-defined m2m "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   192
                        "relations through the model %s, which is not "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   193
                        "permitted. Please consider using an extra field on "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   194
                        "your intermediary model instead." % (
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   195
                            cls._meta.object_name,
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   196
                            f.rel.through._meta.object_name
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   197
                        )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   198
                    )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   199
                else:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   200
                    seen_intermediary_signatures.append(signature)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   201
                if not f.rel.through._meta.auto_created:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   202
                    seen_related_fk, seen_this_fk = False, False
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   203
                    for field in f.rel.through._meta.fields:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   204
                        if field.rel:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   205
                            if not seen_related_fk and field.rel.to == f.rel.to:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   206
                                seen_related_fk = True
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   207
                            elif field.rel.to == cls:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   208
                                seen_this_fk = True
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   209
                    if not seen_related_fk or not seen_this_fk:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   210
                        e.add(opts, "'%s' is a manually-defined m2m relation "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   211
                            "through model %s, which does not have foreign keys "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   212
                            "to %s and %s" % (f.name, f.rel.through._meta.object_name,
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   213
                                f.rel.to._meta.object_name, cls._meta.object_name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   214
                        )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   215
            elif isinstance(f.rel.through, basestring):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   216
                e.add(opts, "'%s' specifies an m2m relation through model %s, "
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   217
                    "which has not been installed" % (f.name, f.rel.through)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   218
                )
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   219
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   220
            rel_opts = f.rel.to._meta
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   221
            rel_name = RelatedObject(f.rel.to, cls, f).get_accessor_name()
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   222
            rel_query_name = f.related_query_name()
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   223
            # If rel_name is none, there is no reverse accessor (this only
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   224
            # occurs for symmetrical m2m relations to self). If this is the
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   225
            # case, there are no clashes to check for this field, as there are
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   226
            # no reverse descriptors for this field.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   227
            if rel_name is not None:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   228
                for r in rel_opts.fields:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   229
                    if r.name == rel_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   230
                        e.add(opts, "Accessor for m2m field '%s' clashes with field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.name, f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   231
                    if r.name == rel_query_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   232
                        e.add(opts, "Reverse query name for m2m field '%s' clashes with field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.name, f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   233
                for r in rel_opts.local_many_to_many:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   234
                    if r.name == rel_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   235
                        e.add(opts, "Accessor for m2m field '%s' clashes with m2m field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.name, f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   236
                    if r.name == rel_query_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   237
                        e.add(opts, "Reverse query name for m2m field '%s' clashes with m2m field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.name, f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   238
                for r in rel_opts.get_all_related_many_to_many_objects():
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   239
                    if r.field is not f:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   240
                        if r.get_accessor_name() == rel_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   241
                            e.add(opts, "Accessor for m2m field '%s' clashes with related m2m field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   242
                        if r.get_accessor_name() == rel_query_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   243
                            e.add(opts, "Reverse query name for m2m field '%s' clashes with related m2m field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   244
                for r in rel_opts.get_all_related_objects():
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   245
                    if r.get_accessor_name() == rel_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   246
                        e.add(opts, "Accessor for m2m field '%s' clashes with related field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   247
                    if r.get_accessor_name() == rel_query_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   248
                        e.add(opts, "Reverse query name for m2m field '%s' clashes with related field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   249
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   250
        # Check ordering attribute.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   251
        if opts.ordering:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   252
            for field_name in opts.ordering:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   253
                if field_name == '?': continue
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   254
                if field_name.startswith('-'):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   255
                    field_name = field_name[1:]
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   256
                if opts.order_with_respect_to and field_name == '_order':
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   257
                    continue
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   258
                # Skip ordering in the format field1__field2 (FIXME: checking
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   259
                # this format would be nice, but it's a little fiddly).
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   260
                if '_' in field_name:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   261
                    continue
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   262
                try:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   263
                    opts.get_field(field_name, many_to_many=False)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   264
                except models.FieldDoesNotExist:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   265
                    e.add(opts, '"ordering" refers to "%s", a field that doesn\'t exist.' % field_name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   266
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   267
        # Check unique_together.
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   268
        for ut in opts.unique_together:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   269
            for field_name in ut:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   270
                try:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   271
                    f = opts.get_field(field_name, many_to_many=True)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   272
                except models.FieldDoesNotExist:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   273
                    e.add(opts, '"unique_together" refers to %s, a field that doesn\'t exist. Check your syntax.' % field_name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   274
                else:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   275
                    if isinstance(f.rel, models.ManyToManyRel):
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   276
                        e.add(opts, '"unique_together" refers to %s. ManyToManyFields are not supported in unique_together.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   277
                    if f not in opts.local_fields:
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   278
                        e.add(opts, '"unique_together" refers to %s. This is not in the same model as the unique_together statement.' % f.name)
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   279
77b6da96e6f1 update django
ymh <ymh.work@gmail.com>
parents:
diff changeset
   280
    return len(e.errors)